Files
Timmy-time-dashboard/docs/DECISIONS.md

54 lines
1.9 KiB
Markdown
Raw Normal View History

# DECISIONS.md — Architectural Decision Log
This file documents major architectural decisions and their rationale.
---
## Decision: Dynamic Model Name in System Prompts
**Date:** 2026-02-26
**Context:** Timmy's system prompts hardcoded "llama3.2" but the actual model is "llama3.1:8b-instruct", causing confusion.
**Decision:** Make model name dynamic by:
- Using `{model_name}` placeholder in prompt templates
- Injecting actual value from `settings.ollama_model` at runtime via `get_system_prompt()`
**Rationale:** Single source of truth. If model changes in config, prompts reflect it automatically.
---
## Decision: Unified Repo Root Detection
**Date:** 2026-02-26
**Context:** Multiple places in code detected repo root differently (git_tools.py, file_ops.py, timmy.py).
**Decision:** Add `repo_root` to config.py with auto-detection:
- Walk up from `__file__` to find `.git`
- Fall back to environment or current directory
**Rationale:** Consistent path resolution for all tools.
---
## Decision: XSS Prevention in Mission Control Dashboard
**Date:** 2026-03-02
**Context:** The Mission Control dashboard was using `innerHTML` to render dependency details and recommendations from the `/health/sovereignty` endpoint. While these sources are currently internal, using `innerHTML` with dynamic data is a security risk and violates the "Non-Negotiable Rules" in `AGENTS.md`.
**Decision:** Refactored the JavaScript in `mission_control.html` to use `document.createElement` and `textContent` for all dynamic data rendering.
**Rationale:** This approach provides built-in XSS protection by ensuring that any data from the API is treated as plain text rather than HTML, fulfilling the security requirements of the project.
---
## Add New Decisions Above This Line
When making significant architectural choices, document:
1. Date
2. Context (what problem prompted the decision)
3. Decision (what was chosen)
4. Rationale (why this approach was better than alternatives)