From 653109663a647faeaf2bdd8ac86c4848f76146bd Mon Sep 17 00:00:00 2001
From: Alexander Whitestone <alexpaynex@gmail.com>
Date: Sun, 22 Mar 2026 19:05:16 -0400
Subject: [PATCH] refactor: DRY up tasks_pending/active/completed HTMX partials

Extract _render_task_list() helper to consolidate the identical
fetch-render-join pattern shared by the three HTMX partial endpoints.

Fixes #942

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
---
 src/dashboard/routes/tasks.py | 75 ++++++++++++++---------------------
 1 file changed, 30 insertions(+), 45 deletions(-)

diff --git a/src/dashboard/routes/tasks.py b/src/dashboard/routes/tasks.py
index 69f2fc72..f6d1ffee 100644
--- a/src/dashboard/routes/tasks.py
+++ b/src/dashboard/routes/tasks.py
@@ -143,64 +143,49 @@ async def tasks_page(request: Request):
 # ---------------------------------------------------------------------------
 
 
+def _render_task_list(request: Request, query: str, empty_msg: str) -> HTMLResponse:
+    """Fetch tasks by query and render as HTMX task-card partials."""
+    with _get_db() as db:
+        rows = db.execute(query).fetchall()
+    parts = [
+        templates.TemplateResponse(
+            request, "partials/task_card.html", {"task": _TaskView(_row_to_dict(r))}
+        ).body.decode()
+        for r in rows
+    ]
+    if not parts:
+        return HTMLResponse(f'<div class="empty-column">{empty_msg}</div>')
+    return HTMLResponse("".join(parts))
+
+
 @router.get("/tasks/pending", response_class=HTMLResponse)
 async def tasks_pending(request: Request):
     """Return HTMX partial for pending approval tasks."""
-    with _get_db() as db:
-        rows = db.execute(
-            "SELECT * FROM tasks WHERE status='pending_approval' ORDER BY created_at DESC"
-        ).fetchall()
-    tasks = [_TaskView(_row_to_dict(r)) for r in rows]
-    parts = []
-    for task in tasks:
-        parts.append(
-            templates.TemplateResponse(
-                request, "partials/task_card.html", {"task": task}
-            ).body.decode()
-        )
-    if not parts:
-        return HTMLResponse('<div class="empty-column">No pending tasks</div>')
-    return HTMLResponse("".join(parts))
+    return _render_task_list(
+        request,
+        "SELECT * FROM tasks WHERE status='pending_approval' ORDER BY created_at DESC",
+        "No pending tasks",
+    )
 
 
 @router.get("/tasks/active", response_class=HTMLResponse)
 async def tasks_active(request: Request):
     """Return HTMX partial for active (approved/running/paused) tasks."""
-    with _get_db() as db:
-        rows = db.execute(
-            "SELECT * FROM tasks WHERE status IN ('approved','running','paused') ORDER BY created_at DESC"
-        ).fetchall()
-    tasks = [_TaskView(_row_to_dict(r)) for r in rows]
-    parts = []
-    for task in tasks:
-        parts.append(
-            templates.TemplateResponse(
-                request, "partials/task_card.html", {"task": task}
-            ).body.decode()
-        )
-    if not parts:
-        return HTMLResponse('<div class="empty-column">No active tasks</div>')
-    return HTMLResponse("".join(parts))
+    return _render_task_list(
+        request,
+        "SELECT * FROM tasks WHERE status IN ('approved','running','paused') ORDER BY created_at DESC",
+        "No active tasks",
+    )
 
 
 @router.get("/tasks/completed", response_class=HTMLResponse)
 async def tasks_completed(request: Request):
     """Return HTMX partial for completed/vetoed/failed tasks (last 50)."""
-    with _get_db() as db:
-        rows = db.execute(
-            "SELECT * FROM tasks WHERE status IN ('completed','vetoed','failed') ORDER BY completed_at DESC LIMIT 50"
-        ).fetchall()
-    tasks = [_TaskView(_row_to_dict(r)) for r in rows]
-    parts = []
-    for task in tasks:
-        parts.append(
-            templates.TemplateResponse(
-                request, "partials/task_card.html", {"task": task}
-            ).body.decode()
-        )
-    if not parts:
-        return HTMLResponse('<div class="empty-column">No completed tasks yet</div>')
-    return HTMLResponse("".join(parts))
+    return _render_task_list(
+        request,
+        "SELECT * FROM tasks WHERE status IN ('completed','vetoed','failed') ORDER BY completed_at DESC LIMIT 50",
+        "No completed tasks yet",
+    )
 
 
 # ---------------------------------------------------------------------------