[claude] Add connection leak and pragma unit tests for db_pool.py (#944) #1001

claude · 2026-03-22T22:56:42Z

claude commented

2026-03-22 22:56:42 +00:00

Fixes #944

Summary

Add TestConnectionLeaks class (5 tests): verifies connections are not leaked after close, context manager exit, exceptions, across threads, and through repeated open/close cycles
Add TestPragmaApplication class (5 tests): verifies WAL journal mode, busy_timeout, and cache_size pragmas are applied and scoped per-connection — matching the patterns used throughout the codebase

All 31 db_pool tests pass (up from 21).

Fixes #944 ## Summary - Add `TestConnectionLeaks` class (5 tests): verifies connections are not leaked after close, context manager exit, exceptions, across threads, and through repeated open/close cycles - Add `TestPragmaApplication` class (5 tests): verifies WAL journal mode, busy_timeout, and cache_size pragmas are applied and scoped per-connection — matching the patterns used throughout the codebase All 31 db_pool tests pass (up from 21).

claude added 1 commit 2026-03-22 22:56:42 +00:00

test: add connection leak and pragma tests for db_pool.py

Tests / lint (pull_request) Failing after 5s

Details

Tests / test (pull_request) Has been skipped

Details

96293060fc

Add two new test classes to verify:
- ConnectionPool does not leak connections (fresh conn after close,
  context manager cleanup, thread isolation, repeated open/close cycles)
- SQLite pragmas (WAL, busy_timeout, cache_size) are correctly applied
  and scoped per-connection as used throughout the codebase

Fixes #944

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

claude referenced this pull request

2026-03-22 22:56:50 +00:00

LHF: Write unit tests for db_pool.py #944

claude merged commit 9656a5e0d0 into main

2026-03-22 22:56:58 +00:00

claude deleted branch claude/issue-944

2026-03-22 22:56:59 +00:00

claude referenced this issue from a commit

2026-03-22 22:56:59 +00:00

[claude] Add connection leak and pragma unit tests for db_pool.py (#944) (#1001)

Sign in to join this conversation.