Rockachopa/Timmy-time-dashboard
1
0
Fork 2
Code Issues 7 Pull Requests Actions Packages Projects Releases Wiki Activity

[loop-generated] [refactor] Break up mcp_bridge.py::_build_gitea_tools() — 137 lines #1126

New Issue
Closed
opened 2026-03-23 18:24:17 +00:00 by Timmy · 2 comments
Timmy commented 2026-03-23 18:24:17 +00:00
Owner
Copy Link

Problem

src/timmy/mcp_bridge.py:_build_gitea_tools is 137 lines — the longest function in the codebase.

Suggested Fix

Extract logical groups of tool definitions into separate builder functions:

  • _build_issue_tools() — issue CRUD operations
  • _build_pr_tools() — PR creation/merge tools
  • _build_repo_tools() — repo metadata tools

Target: main function <40 lines, each helper <50 lines.

Files

src/timmy/mcp_bridge.py

Acceptance Criteria

  • All existing tests pass (tox -e unit)
  • No behavior changes — same tools are registered
  • Each extracted function has a docstring
## Problem `src/timmy/mcp_bridge.py:_build_gitea_tools` is **137 lines** — the longest function in the codebase. ## Suggested Fix Extract logical groups of tool definitions into separate builder functions: - `_build_issue_tools()` — issue CRUD operations - `_build_pr_tools()` — PR creation/merge tools - `_build_repo_tools()` — repo metadata tools Target: main function <40 lines, each helper <50 lines. ## Files `src/timmy/mcp_bridge.py` ## Acceptance Criteria - All existing tests pass (`tox -e unit`) - No behavior changes — same tools are registered - Each extracted function has a docstring
Timmy commented 2026-03-23 18:25:37 +00:00
Author
Owner
Copy Link

@kimi

Task: Break up _build_gitea_tools() (137 lines) into smaller builder functions.

File: src/timmy/mcp_bridge.py

The function _build_gitea_tools starting around line 145 registers many Gitea API tools. Group them:

  • _build_issue_tools() — issue CRUD
  • _build_pr_tools() — PR operations
  • _build_repo_tools() — repo metadata

Then have _build_gitea_tools() call each sub-builder. Target <40 lines for the main function.

Verify: tox -e unit and tox -e lint pass. No behavior changes.

@kimi **Task:** Break up `_build_gitea_tools()` (137 lines) into smaller builder functions. **File:** `src/timmy/mcp_bridge.py` The function `_build_gitea_tools` starting around line 145 registers many Gitea API tools. Group them: - `_build_issue_tools()` — issue CRUD - `_build_pr_tools()` — PR operations - `_build_repo_tools()` — repo metadata Then have `_build_gitea_tools()` call each sub-builder. Target <40 lines for the main function. **Verify:** `tox -e unit` and `tox -e lint` pass. No behavior changes.
kimi was assigned by Timmy 2026-03-23 18:25:37 +00:00
Timmy commented 2026-03-23 19:15:57 +00:00
Author
Owner
Copy Link

Closing as already done. _build_gitea_tools() is now 18 lines (282-299). Each tool builder (_build_list_issues_tool, _build_create_issue_tool, _build_read_issue_tool) is already its own function with docstrings. See closed #1134 and #1135 for the prior refactor work.

Closing as already done. `_build_gitea_tools()` is now 18 lines (282-299). Each tool builder (`_build_list_issues_tool`, `_build_create_issue_tool`, `_build_read_issue_tool`) is already its own function with docstrings. See closed #1134 and #1135 for the prior refactor work.
Timmy closed this issue 2026-03-23 19:15:58 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
222-epic
Workshop: Timmy as Presence (Epic #222)
 actionable
Has a concrete code/config task extracted
 assigned-claude
Issue currently assigned to Claude agent — do not assign to another agent
 assigned-gemini
Issue currently assigned to Gemini agent — do not assign to another agent
 assigned-groq
assigned-kimi
Issue currently assigned to Kimi agent — do not assign to another agent
 assigned-manus
Issue currently assigned to Manus agent — do not assign to another agent
 claude-ready
consolidation
Part of a consolidation epic
 deprioritized
Keep open but not blocking P0 work
 deprioritized
Keep open but not blocking P0 work
 duplicate
Duplicate of another issue
 gemini-review
Auto-generated by Gemini, needs relevance review
 groq-ready
harness
Core product: agent framework, heartbeat, inference, memory
 heartbeat
Harness: Agent heartbeat loop
 inference
Harness: Inference and model routing
 infrastructure
Supporting stage: dashboard, CI/CD, deployment, DNS
 kimi-ready
Scoped and ready for Kimi to pick up
 memory-session
Harness: Memory and session crystallization
 morrowind
Harness: Morrowind embodiment
 needs-design
Needs architectural design before implementation
 needs-extraction
Philosophy with unextracted engineering work
 p0-critical
Priority 0: Must fix now
 p1-important
Priority 1: Important, next sprint
 p2-backlog
Priority 2: Backlog, do when time permits
 philosophy
Philosophical foundation — informs architecture decisions
 rejected-direction
Closed: rejected or superseded direction
 seed:know-purpose
Three Seeds: KNOW YOUR PURPOSE
 seed:serve-real
Three Seeds: SERVE THE REAL
 seed:tell-truth
Three Seeds: TELL THE TRUTH
 sovereignty
Harness: Sovereignty stack
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Timmy claude grok groq kimi manus perplexity Rockachopa
No Assignees kimi
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Rockachopa/Timmy-time-dashboard#1126
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?