Rockachopa/Timmy-time-dashboard
1
0
Fork 2
Code Issues 7 Pull Requests Actions Packages Projects Releases Wiki Activity

[loop-generated] [refactor] Break up scorecards.py — two functions over 100 lines each #1127

New Issue
Closed
opened 2026-03-23 18:24:17 +00:00 by Timmy · 2 comments
Timmy commented 2026-03-23 18:24:17 +00:00
Owner
Copy Link

Problem

src/dashboard/routes/scorecards.py has two large functions:

  • agent_scorecard_panel() — 108 lines
  • all_scorecard_panels() — 106 lines

Suggested Fix

Extract shared logic:

  • Metric computation helpers
  • HTML template assembly helpers
  • Period filtering logic

Target: each function <50 lines.

Files

src/dashboard/routes/scorecards.py

Acceptance Criteria

  • All existing tests pass (tox -e unit)
  • Dashboard scorecards render identically
  • Extracted helpers have docstrings
## Problem `src/dashboard/routes/scorecards.py` has two large functions: - `agent_scorecard_panel()` — 108 lines - `all_scorecard_panels()` — 106 lines ## Suggested Fix Extract shared logic: - Metric computation helpers - HTML template assembly helpers - Period filtering logic Target: each function <50 lines. ## Files `src/dashboard/routes/scorecards.py` ## Acceptance Criteria - All existing tests pass (`tox -e unit`) - Dashboard scorecards render identically - Extracted helpers have docstrings
Timmy commented 2026-03-23 18:24:46 +00:00
Author
Owner
Copy Link

@kimi

Task: Refactor two oversized functions in scorecards.py.

File: src/dashboard/routes/scorecards.py

  • agent_scorecard_panel() — 108 lines → extract metric computation and HTML assembly helpers
  • all_scorecard_panels() — 106 lines → extract shared filtering and panel assembly logic

Rules:

  • Target each function <50 lines
  • Extract helpers with descriptive names and docstrings
  • No behavior changes
  • All tests must pass: tox -e unit and tox -e lint
@kimi **Task:** Refactor two oversized functions in scorecards.py. **File:** `src/dashboard/routes/scorecards.py` - `agent_scorecard_panel()` — 108 lines → extract metric computation and HTML assembly helpers - `all_scorecard_panels()` — 106 lines → extract shared filtering and panel assembly logic **Rules:** - Target each function <50 lines - Extract helpers with descriptive names and docstrings - No behavior changes - All tests must pass: `tox -e unit` and `tox -e lint`
kimi was assigned by Timmy 2026-03-23 18:24:48 +00:00
kimi commented 2026-03-23 18:50:27 +00:00
Collaborator
Copy Link

PR created: http://143.198.27.163:3000/rockachopa/Timmy-time-dashboard/pulls

Summary:

  • Refactored agent_scorecard_panel() from 108 → 26 lines
  • Refactored all_scorecard_panels() from 106 → 26 lines
  • Extracted 11 helper functions with docstrings
  • All 49 tests pass
  • No behavior changes - HTML output remains identical
PR created: http://143.198.27.163:3000/rockachopa/Timmy-time-dashboard/pulls **Summary:** - Refactored `agent_scorecard_panel()` from 108 → 26 lines - Refactored `all_scorecard_panels()` from 106 → 26 lines - Extracted 11 helper functions with docstrings - All 49 tests pass - No behavior changes - HTML output remains identical
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
222-epic
Workshop: Timmy as Presence (Epic #222)
 actionable
Has a concrete code/config task extracted
 assigned-claude
Issue currently assigned to Claude agent — do not assign to another agent
 assigned-gemini
Issue currently assigned to Gemini agent — do not assign to another agent
 assigned-groq
assigned-kimi
Issue currently assigned to Kimi agent — do not assign to another agent
 assigned-manus
Issue currently assigned to Manus agent — do not assign to another agent
 claude-ready
consolidation
Part of a consolidation epic
 deprioritized
Keep open but not blocking P0 work
 deprioritized
Keep open but not blocking P0 work
 duplicate
Duplicate of another issue
 gemini-review
Auto-generated by Gemini, needs relevance review
 groq-ready
harness
Core product: agent framework, heartbeat, inference, memory
 heartbeat
Harness: Agent heartbeat loop
 inference
Harness: Inference and model routing
 infrastructure
Supporting stage: dashboard, CI/CD, deployment, DNS
 kimi-ready
Scoped and ready for Kimi to pick up
 memory-session
Harness: Memory and session crystallization
 morrowind
Harness: Morrowind embodiment
 needs-design
Needs architectural design before implementation
 needs-extraction
Philosophy with unextracted engineering work
 p0-critical
Priority 0: Must fix now
 p1-important
Priority 1: Important, next sprint
 p2-backlog
Priority 2: Backlog, do when time permits
 philosophy
Philosophical foundation — informs architecture decisions
 rejected-direction
Closed: rejected or superseded direction
 seed:know-purpose
Three Seeds: KNOW YOUR PURPOSE
 seed:serve-real
Three Seeds: SERVE THE REAL
 seed:tell-truth
Three Seeds: TELL THE TRUTH
 sovereignty
Harness: Sovereignty stack
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Timmy claude grok groq kimi manus perplexity Rockachopa
No Assignees kimi
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Rockachopa/Timmy-time-dashboard#1127
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?