Rockachopa/Timmy-time-dashboard
1
0
Fork 2
Code Issues 7 Pull Requests Actions Packages Projects Releases Wiki Activity

[loop-generated] [refactor] Clean up unused imports in memory_system.py #1129

New Issue
Closed
opened 2026-03-23 18:24:18 +00:00 by Timmy · 1 comment
Timmy commented 2026-03-23 18:24:18 +00:00
Owner
Copy Link

Problem

src/timmy/memory_system.py imports three symbols from its local module that are never used:

  • EMBEDDING_MODEL
  • _cosine_similarity
  • _simple_hash_embedding

Also src/dashboard/app.py has an unused _discord_check import.

Suggested Fix

Remove the unused imports. Verify they aren't re-exported (check __all__ or usage in other files).

Files

  • src/timmy/memory_system.py
  • src/dashboard/app.py

Acceptance Criteria

  • tox -e lint passes
  • tox -e unit passes
  • No runtime import errors
## Problem `src/timmy/memory_system.py` imports three symbols from its local module that are never used: - `EMBEDDING_MODEL` - `_cosine_similarity` - `_simple_hash_embedding` Also `src/dashboard/app.py` has an unused `_discord_check` import. ## Suggested Fix Remove the unused imports. Verify they aren't re-exported (check `__all__` or usage in other files). ## Files - `src/timmy/memory_system.py` - `src/dashboard/app.py` ## Acceptance Criteria - `tox -e lint` passes - `tox -e unit` passes - No runtime import errors
claude self-assigned this 2026-03-23 18:24:58 +00:00
Timmy commented 2026-03-23 18:25:21 +00:00
Author
Owner
Copy Link

Closing — false positives. All flagged imports have # noqa: F401 annotations:

  • memory_system.py: EMBEDDING_MODEL, _cosine_similarity, _simple_hash_embedding are re-exported for backward compatibility
  • dashboard/app.py: _discord_check is an import availability probe

No cleanup needed.

Closing — false positives. All flagged imports have `# noqa: F401` annotations: - `memory_system.py`: `EMBEDDING_MODEL`, `_cosine_similarity`, `_simple_hash_embedding` are re-exported for backward compatibility - `dashboard/app.py`: `_discord_check` is an import availability probe No cleanup needed.
Timmy closed this issue 2026-03-23 18:25:21 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
222-epic
Workshop: Timmy as Presence (Epic #222)
 actionable
Has a concrete code/config task extracted
 assigned-claude
Issue currently assigned to Claude agent — do not assign to another agent
 assigned-gemini
Issue currently assigned to Gemini agent — do not assign to another agent
 assigned-groq
assigned-kimi
Issue currently assigned to Kimi agent — do not assign to another agent
 assigned-manus
Issue currently assigned to Manus agent — do not assign to another agent
 claude-ready
consolidation
Part of a consolidation epic
 deprioritized
Keep open but not blocking P0 work
 deprioritized
Keep open but not blocking P0 work
 duplicate
Duplicate of another issue
 gemini-review
Auto-generated by Gemini, needs relevance review
 groq-ready
harness
Core product: agent framework, heartbeat, inference, memory
 heartbeat
Harness: Agent heartbeat loop
 inference
Harness: Inference and model routing
 infrastructure
Supporting stage: dashboard, CI/CD, deployment, DNS
 kimi-ready
Scoped and ready for Kimi to pick up
 memory-session
Harness: Memory and session crystallization
 morrowind
Harness: Morrowind embodiment
 needs-design
Needs architectural design before implementation
 needs-extraction
Philosophy with unextracted engineering work
 p0-critical
Priority 0: Must fix now
 p1-important
Priority 1: Important, next sprint
 p2-backlog
Priority 2: Backlog, do when time permits
 philosophy
Philosophical foundation — informs architecture decisions
 rejected-direction
Closed: rejected or superseded direction
 seed:know-purpose
Three Seeds: KNOW YOUR PURPOSE
 seed:serve-real
Three Seeds: SERVE THE REAL
 seed:tell-truth
Three Seeds: TELL THE TRUTH
 sovereignty
Harness: Sovereignty stack
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Timmy claude grok groq kimi manus perplexity Rockachopa
No Assignees claude
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Rockachopa/Timmy-time-dashboard#1129
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?