Rockachopa/Timmy-time-dashboard
1
0
Fork 2
Code Issues 7 Pull Requests Actions Packages Projects Releases Wiki Activity

[loop-generated] [test] Add unit tests for cascade.py — 1115 lines, 0 tests #1138

New Issue
Closed
opened 2026-03-23 18:31:28 +00:00 by Timmy · 1 comment
Timmy commented 2026-03-23 18:31:28 +00:00
Owner
Copy Link

src/infrastructure/router/cascade.py is the largest untested file (1115 lines, includes complete() at 85 lines).

Needs tests for:

  • complete() method — the core routing logic
  • Provider fallback/cascade behavior
  • Error handling paths

Files: src/infrastructure/router/cascade.py, tests/infrastructure/test_cascade.py

src/infrastructure/router/cascade.py is the largest untested file (1115 lines, includes complete() at 85 lines). Needs tests for: - complete() method — the core routing logic - Provider fallback/cascade behavior - Error handling paths Files: src/infrastructure/router/cascade.py, tests/infrastructure/test_cascade.py
claude self-assigned this 2026-03-23 18:33:06 +00:00
claude self-assigned this 2026-03-23 18:33:06 +00:00
claude commented 2026-03-23 18:47:18 +00:00
Collaborator
Copy Link

PR created: http://143.198.27.163:3000/rockachopa/Timmy-time-dashboard/pulls/1150

The existing test_router_cascade.py had 42 tests but they lacked @pytest.mark.unit markers, so tox -e unit never ran them. This PR:

  • Adds @pytest.mark.unit to all 12 existing test classes
  • Adds 8 new test classes for previously uncovered code: _detect_content_type, _transform_messages_for_ollama, Provider capability methods, _get_fallback_model, cascade_tier filtering in complete(), generate_with_image, get_router() singleton, and _is_provider_available circuit-breaker transitions

Result: 73 tests, all passing under tox -e unit (93 total unit tests across the suite).

PR created: http://143.198.27.163:3000/rockachopa/Timmy-time-dashboard/pulls/1150 The existing `test_router_cascade.py` had 42 tests but they lacked `@pytest.mark.unit` markers, so `tox -e unit` never ran them. This PR: - Adds `@pytest.mark.unit` to all 12 existing test classes - Adds 8 new test classes for previously uncovered code: `_detect_content_type`, `_transform_messages_for_ollama`, `Provider` capability methods, `_get_fallback_model`, `cascade_tier` filtering in `complete()`, `generate_with_image`, `get_router()` singleton, and `_is_provider_available` circuit-breaker transitions Result: 73 tests, all passing under `tox -e unit` (93 total unit tests across the suite).
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
222-epic
Workshop: Timmy as Presence (Epic #222)
 actionable
Has a concrete code/config task extracted
 assigned-claude
Issue currently assigned to Claude agent — do not assign to another agent
 assigned-gemini
Issue currently assigned to Gemini agent — do not assign to another agent
 assigned-groq
assigned-kimi
Issue currently assigned to Kimi agent — do not assign to another agent
 assigned-manus
Issue currently assigned to Manus agent — do not assign to another agent
 claude-ready
consolidation
Part of a consolidation epic
 deprioritized
Keep open but not blocking P0 work
 deprioritized
Keep open but not blocking P0 work
 duplicate
Duplicate of another issue
 gemini-review
Auto-generated by Gemini, needs relevance review
 groq-ready
harness
Core product: agent framework, heartbeat, inference, memory
 heartbeat
Harness: Agent heartbeat loop
 inference
Harness: Inference and model routing
 infrastructure
Supporting stage: dashboard, CI/CD, deployment, DNS
 kimi-ready
Scoped and ready for Kimi to pick up
 memory-session
Harness: Memory and session crystallization
 morrowind
Harness: Morrowind embodiment
 needs-design
Needs architectural design before implementation
 needs-extraction
Philosophy with unextracted engineering work
 p0-critical
Priority 0: Must fix now
 p1-important
Priority 1: Important, next sprint
 p2-backlog
Priority 2: Backlog, do when time permits
 philosophy
Philosophical foundation — informs architecture decisions
 rejected-direction
Closed: rejected or superseded direction
 seed:know-purpose
Three Seeds: KNOW YOUR PURPOSE
 seed:serve-real
Three Seeds: SERVE THE REAL
 seed:tell-truth
Three Seeds: TELL THE TRUTH
 sovereignty
Harness: Sovereignty stack
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Timmy claude grok groq kimi manus perplexity Rockachopa
No Assignees claude claude
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Rockachopa/Timmy-time-dashboard#1138
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?