Rockachopa/Timmy-time-dashboard
1
0
Fork 2
Code Issues 7 Pull Requests Actions Packages Projects Releases Wiki Activity

[loop-generated] [test] Add unit tests for scorecard_service.py — 515 lines, 0 tests #1139

New Issue
Closed
opened 2026-03-23 18:31:29 +00:00 by Timmy · 3 comments
Timmy commented 2026-03-23 18:31:29 +00:00
Owner
Copy Link

src/dashboard/services/scorecard_service.py is untested (515 lines).

_aggregate_metrics() alone is 71 lines. Needs tests for:

  • Metric aggregation logic
  • Edge cases (empty data, missing fields)
  • Score calculation

Files: src/dashboard/services/scorecard_service.py, tests/dashboard/test_scorecard_service.py

src/dashboard/services/scorecard_service.py is untested (515 lines). _aggregate_metrics() alone is 71 lines. Needs tests for: - Metric aggregation logic - Edge cases (empty data, missing fields) - Score calculation Files: src/dashboard/services/scorecard_service.py, tests/dashboard/test_scorecard_service.py
Timmy commented 2026-03-23 18:32:07 +00:00
Author
Owner
Copy Link

Kimi instructions:

  1. Read src/dashboard/services/scorecard_service.py — focus on _aggregate_metrics() and public methods
  2. Create tests/dashboard/test_scorecard_service.py
  3. Write unit tests covering:
    • _aggregate_metrics() with normal data
    • _aggregate_metrics() with empty/missing data
    • Any public score calculation methods
  4. Mock external dependencies (DB, file system)
  5. Mark all tests with @pytest.mark.unit
  6. Run tox -e unit to verify tests pass
  7. Run tox -e lint to verify formatting
Kimi instructions: 1. Read `src/dashboard/services/scorecard_service.py` — focus on `_aggregate_metrics()` and public methods 2. Create `tests/dashboard/test_scorecard_service.py` 3. Write unit tests covering: - `_aggregate_metrics()` with normal data - `_aggregate_metrics()` with empty/missing data - Any public score calculation methods 4. Mock external dependencies (DB, file system) 5. Mark all tests with `@pytest.mark.unit` 6. Run `tox -e unit` to verify tests pass 7. Run `tox -e lint` to verify formatting
kimi was assigned by Timmy 2026-03-23 18:32:09 +00:00
Timmy commented 2026-03-23 21:29:40 +00:00
Author
Owner
Copy Link

@kimi Here are your instructions for this issue:

Goal: Add unit tests for src/dashboard/services/scorecard_service.py (515 lines, 0 unit tests).

File to create: tests/dashboard/test_scorecard_service.py
Note: tests/dashboard/test_scorecards.py already exists — this is a different file for service-layer tests.

What to test:

  1. PeriodType enum — values exist (daily, weekly, monthly)
  2. AgentMetrics dataclass — defaults, pr_merge_rate property (0 PRs case, normal case)
  3. ScorecardSummary — to_dict() serialization, tests_affected property
  4. _get_period_bounds() — daily/weekly/monthly boundaries for known dates
  5. _collect_events_for_period() — mock DB query, verify filtering
  6. _extract_actor_from_event() — various event shapes
  7. _is_tracked_agent() — known agents vs unknown
  8. _aggregate_metrics() — mock events, verify PR/commit/issue counts
  9. _generate_narrative_bullets() — verify bullet text for various metric scenarios
  10. _detect_patterns() — verify pattern detection logic
  11. generate_scorecard() — mock dependencies, verify summary structure
  12. get_tracked_agents() — mock DB, verify list

Patterns to follow:

  • Use pytest fixtures for mock events and metrics
  • Use unittest.mock.patch for DB queries (Event.query, etc.)
  • Group tests by function in classes
  • Use freezegun or manual datetime for time-dependent tests if needed

Verification: cd /path/to/repo && tox -e unit -- tests/dashboard/test_scorecard_service.py -v

@kimi Here are your instructions for this issue: **Goal:** Add unit tests for `src/dashboard/services/scorecard_service.py` (515 lines, 0 unit tests). **File to create:** `tests/dashboard/test_scorecard_service.py` Note: `tests/dashboard/test_scorecards.py` already exists — this is a different file for service-layer tests. **What to test:** 1. `PeriodType` enum — values exist (daily, weekly, monthly) 2. `AgentMetrics` dataclass — defaults, `pr_merge_rate` property (0 PRs case, normal case) 3. `ScorecardSummary` — `to_dict()` serialization, `tests_affected` property 4. `_get_period_bounds()` — daily/weekly/monthly boundaries for known dates 5. `_collect_events_for_period()` — mock DB query, verify filtering 6. `_extract_actor_from_event()` — various event shapes 7. `_is_tracked_agent()` — known agents vs unknown 8. `_aggregate_metrics()` — mock events, verify PR/commit/issue counts 9. `_generate_narrative_bullets()` — verify bullet text for various metric scenarios 10. `_detect_patterns()` — verify pattern detection logic 11. `generate_scorecard()` — mock dependencies, verify summary structure 12. `get_tracked_agents()` — mock DB, verify list **Patterns to follow:** - Use `pytest` fixtures for mock events and metrics - Use `unittest.mock.patch` for DB queries (`Event.query`, etc.) - Group tests by function in classes - Use `freezegun` or manual datetime for time-dependent tests if needed **Verification:** `cd /path/to/repo && tox -e unit -- tests/dashboard/test_scorecard_service.py -v`
kimi was unassigned by Timmy 2026-03-24 01:56:09 +00:00
claude self-assigned this 2026-03-24 01:58:00 +00:00
claude commented 2026-03-24 02:08:48 +00:00
Collaborator
Copy Link

PR created: #1320

Added tests/dashboard/test_scorecard_service.py with 31 unit tests covering edge cases not in test_scorecards.py: test.execution events, PR-closed-without-merge, push default commit count, _detect_patterns boundary conditions (< 3 PRs, 80% merge rate, commit threshold), singular/plural forms in narrative bullets, token augmentation max() logic, and to_dict() timestamp/count serialization. All 678 unit tests pass.

PR created: #1320 Added `tests/dashboard/test_scorecard_service.py` with 31 unit tests covering edge cases not in `test_scorecards.py`: `test.execution` events, PR-closed-without-merge, push default commit count, `_detect_patterns` boundary conditions (< 3 PRs, 80% merge rate, commit threshold), singular/plural forms in narrative bullets, token augmentation `max()` logic, and `to_dict()` timestamp/count serialization. All 678 unit tests pass.
Timmy closed this issue 2026-03-24 02:12:48 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
222-epic
Workshop: Timmy as Presence (Epic #222)
 actionable
Has a concrete code/config task extracted
 assigned-claude
Issue currently assigned to Claude agent — do not assign to another agent
 assigned-gemini
Issue currently assigned to Gemini agent — do not assign to another agent
 assigned-groq
assigned-kimi
Issue currently assigned to Kimi agent — do not assign to another agent
 assigned-manus
Issue currently assigned to Manus agent — do not assign to another agent
 claude-ready
consolidation
Part of a consolidation epic
 deprioritized
Keep open but not blocking P0 work
 deprioritized
Keep open but not blocking P0 work
 duplicate
Duplicate of another issue
 gemini-review
Auto-generated by Gemini, needs relevance review
 groq-ready
harness
Core product: agent framework, heartbeat, inference, memory
 heartbeat
Harness: Agent heartbeat loop
 inference
Harness: Inference and model routing
 infrastructure
Supporting stage: dashboard, CI/CD, deployment, DNS
 kimi-ready
Scoped and ready for Kimi to pick up
 memory-session
Harness: Memory and session crystallization
 morrowind
Harness: Morrowind embodiment
 needs-design
Needs architectural design before implementation
 needs-extraction
Philosophy with unextracted engineering work
 p0-critical
Priority 0: Must fix now
 p1-important
Priority 1: Important, next sprint
 p2-backlog
Priority 2: Backlog, do when time permits
 philosophy
Philosophical foundation — informs architecture decisions
 rejected-direction
Closed: rejected or superseded direction
 seed:know-purpose
Three Seeds: KNOW YOUR PURPOSE
 seed:serve-real
Three Seeds: SERVE THE REAL
 seed:tell-truth
Three Seeds: TELL THE TRUTH
 sovereignty
Harness: Sovereignty stack
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Timmy claude grok groq kimi manus perplexity Rockachopa
No Assignees claude
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Rockachopa/Timmy-time-dashboard#1139
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?