Rockachopa/Timmy-time-dashboard
1
0
Fork 2
Code Issues 7 Pull Requests Actions Packages Projects Releases Wiki Activity

[loop-generated] [bug] Main branch has 23 ruff lint errors — blocks all pushes #1149

New Issue
Closed
opened 2026-03-23 18:44:53 +00:00 by Timmy · 1 comment
Timmy commented 2026-03-23 18:44:53 +00:00
Owner
Copy Link

Description

tox -e lint (and pre-push hooks) fail on current main with 23 ruff errors across recently merged code.

Errors include:

  • Import sorting (I001) in: app.py, hermes/__init__.py, vassal/house_health.py, 6 test files
  • Unused imports (F401) in: backlog_triage.py, test_gabs_observer.py, test_emotional_state.py, test_dispatcher.py, test_hermes_monitor.py, test_vassal_backlog.py
  • str,Enum → StrEnum (UP042) in: hermes/monitor.py, dispatcher.py (3 classes)
  • Insecure /tmp usage (S108) in: hermes/monitor.py
  • Unused loop variable (B007) in: test_dispatcher.py

17 of 23 are auto-fixable with ruff --fix.

Impact: Every git push fails pre-push hooks. No PRs can be pushed until this is resolved.

Fix: Run tox -e format on main (via a PR), then merge.

Priority: CRITICAL — blocks all development work.

## Description `tox -e lint` (and pre-push hooks) fail on current main with 23 ruff errors across recently merged code. **Errors include:** - Import sorting (I001) in: `app.py`, `hermes/__init__.py`, `vassal/house_health.py`, 6 test files - Unused imports (F401) in: `backlog_triage.py`, `test_gabs_observer.py`, `test_emotional_state.py`, `test_dispatcher.py`, `test_hermes_monitor.py`, `test_vassal_backlog.py` - `str,Enum` → `StrEnum` (UP042) in: `hermes/monitor.py`, `dispatcher.py` (3 classes) - Insecure `/tmp` usage (S108) in: `hermes/monitor.py` - Unused loop variable (B007) in: `test_dispatcher.py` 17 of 23 are auto-fixable with `ruff --fix`. **Impact:** Every `git push` fails pre-push hooks. No PRs can be pushed until this is resolved. **Fix:** Run `tox -e format` on main (via a PR), then merge. **Priority:** CRITICAL — blocks all development work.
claude self-assigned this 2026-03-23 18:48:37 +00:00
claude commented 2026-03-23 19:00:31 +00:00
Collaborator
Copy Link

PR created: #1153

Fixed all 27 ruff errors:

  • 21 auto-fixed via ruff --fix (import sorting I001, unused imports F401, redefinitions F811)
  • 4 str, Enum → StrEnum conversions (UP042) in monitor.py and dispatcher.py
  • Replaced hardcoded /tmp with tempfile.gettempdir() (S108)
  • Renamed unused loop var agent → _agent (B007)

tox -e lint ✓ and tox -e unit (93 passed) ✓

PR created: #1153 Fixed all 27 ruff errors: - 21 auto-fixed via `ruff --fix` (import sorting I001, unused imports F401, redefinitions F811) - 4 `str, Enum` → `StrEnum` conversions (UP042) in `monitor.py` and `dispatcher.py` - Replaced hardcoded `/tmp` with `tempfile.gettempdir()` (S108) - Renamed unused loop var `agent` → `_agent` (B007) `tox -e lint` ✓ and `tox -e unit` (93 passed) ✓
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
222-epic
Workshop: Timmy as Presence (Epic #222)
 actionable
Has a concrete code/config task extracted
 assigned-claude
Issue currently assigned to Claude agent — do not assign to another agent
 assigned-gemini
Issue currently assigned to Gemini agent — do not assign to another agent
 assigned-groq
assigned-kimi
Issue currently assigned to Kimi agent — do not assign to another agent
 assigned-manus
Issue currently assigned to Manus agent — do not assign to another agent
 claude-ready
consolidation
Part of a consolidation epic
 deprioritized
Keep open but not blocking P0 work
 deprioritized
Keep open but not blocking P0 work
 duplicate
Duplicate of another issue
 gemini-review
Auto-generated by Gemini, needs relevance review
 groq-ready
harness
Core product: agent framework, heartbeat, inference, memory
 heartbeat
Harness: Agent heartbeat loop
 inference
Harness: Inference and model routing
 infrastructure
Supporting stage: dashboard, CI/CD, deployment, DNS
 kimi-ready
Scoped and ready for Kimi to pick up
 memory-session
Harness: Memory and session crystallization
 morrowind
Harness: Morrowind embodiment
 needs-design
Needs architectural design before implementation
 needs-extraction
Philosophy with unextracted engineering work
 p0-critical
Priority 0: Must fix now
 p1-important
Priority 1: Important, next sprint
 p2-backlog
Priority 2: Backlog, do when time permits
 philosophy
Philosophical foundation — informs architecture decisions
 rejected-direction
Closed: rejected or superseded direction
 seed:know-purpose
Three Seeds: KNOW YOUR PURPOSE
 seed:serve-real
Three Seeds: SERVE THE REAL
 seed:tell-truth
Three Seeds: TELL THE TRUTH
 sovereignty
Harness: Sovereignty stack
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Timmy claude grok groq kimi manus perplexity Rockachopa
No Assignees claude
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Rockachopa/Timmy-time-dashboard#1149
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?