Rockachopa/Timmy-time-dashboard
1
0
Fork 2
Code Issues 7 Pull Requests Actions Packages Projects Releases Wiki Activity

[loop-generated] [bug] tox -e format fails on main — 9 pre-existing ruff errors in bannerlord/ #1161

New Issue
Closed
opened 2026-03-23 19:47:16 +00:00 by Timmy · 1 comment
Timmy commented 2026-03-23 19:47:16 +00:00
Owner
Copy Link

Problem

tox -e format fails on main with 9 unfixable ruff errors in bannerlord code. This breaks the pre-commit hook for ALL commits.

Fix

  1. Add # noqa: S105/S106 to bannerlord token comparisons
  2. Fix pytest.raises(Exception) in test_models.py

Acceptance Criteria

  • tox -e format passes cleanly on main
## Problem `tox -e format` fails on main with 9 unfixable ruff errors in bannerlord code. This breaks the pre-commit hook for ALL commits. ## Fix 1. Add `# noqa: S105/S106` to bannerlord token comparisons 2. Fix `pytest.raises(Exception)` in test_models.py ## Acceptance Criteria - `tox -e format` passes cleanly on main
claude was assigned by Rockachopa 2026-03-23 19:51:47 +00:00
claude commented 2026-03-23 19:53:26 +00:00
Collaborator
Copy Link

PR created: http://143.198.27.163:3000/rockachopa/Timmy-time-dashboard/pulls/1165

Fixed all 10 ruff errors:

  • S106: Added # noqa: S106 to KingSubgoal(token="RECRUIT") in king.py
  • S105 (×7): Added # noqa: S105 to all subgoal.token == "..." comparisons in vassals.py
  • B017: Changed pytest.raises(Exception) → pytest.raises(ValueError) in test_models.py
  • E402: Moved pytestmark after local imports in test_metabolic_router.py

tox -e format and tox -e unit (141 tests) both pass cleanly.

PR created: http://143.198.27.163:3000/rockachopa/Timmy-time-dashboard/pulls/1165 Fixed all 10 ruff errors: - `S106`: Added `# noqa: S106` to `KingSubgoal(token="RECRUIT")` in `king.py` - `S105` (×7): Added `# noqa: S105` to all `subgoal.token == "..."` comparisons in `vassals.py` - `B017`: Changed `pytest.raises(Exception)` → `pytest.raises(ValueError)` in `test_models.py` - `E402`: Moved `pytestmark` after local imports in `test_metabolic_router.py` `tox -e format` and `tox -e unit` (141 tests) both pass cleanly.
Timmy closed this issue 2026-03-23 19:56:08 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
222-epic
Workshop: Timmy as Presence (Epic #222)
 actionable
Has a concrete code/config task extracted
 assigned-claude
Issue currently assigned to Claude agent — do not assign to another agent
 assigned-gemini
Issue currently assigned to Gemini agent — do not assign to another agent
 assigned-groq
assigned-kimi
Issue currently assigned to Kimi agent — do not assign to another agent
 assigned-manus
Issue currently assigned to Manus agent — do not assign to another agent
 claude-ready
consolidation
Part of a consolidation epic
 deprioritized
Keep open but not blocking P0 work
 deprioritized
Keep open but not blocking P0 work
 duplicate
Duplicate of another issue
 gemini-review
Auto-generated by Gemini, needs relevance review
 groq-ready
harness
Core product: agent framework, heartbeat, inference, memory
 heartbeat
Harness: Agent heartbeat loop
 inference
Harness: Inference and model routing
 infrastructure
Supporting stage: dashboard, CI/CD, deployment, DNS
 kimi-ready
Scoped and ready for Kimi to pick up
 memory-session
Harness: Memory and session crystallization
 morrowind
Harness: Morrowind embodiment
 needs-design
Needs architectural design before implementation
 needs-extraction
Philosophy with unextracted engineering work
 p0-critical
Priority 0: Must fix now
 p1-important
Priority 1: Important, next sprint
 p2-backlog
Priority 2: Backlog, do when time permits
 philosophy
Philosophical foundation — informs architecture decisions
 rejected-direction
Closed: rejected or superseded direction
 seed:know-purpose
Three Seeds: KNOW YOUR PURPOSE
 seed:serve-real
Three Seeds: SERVE THE REAL
 seed:tell-truth
Three Seeds: TELL THE TRUTH
 sovereignty
Harness: Sovereignty stack
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Timmy claude grok kimi manus perplexity Rockachopa
No Assignees claude
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Rockachopa/Timmy-time-dashboard#1161
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?