Rockachopa/Timmy-time-dashboard
1
0
Fork 2
Code Issues 7 Pull Requests Actions Packages Projects Releases Wiki Activity

[loop-generated] [refactor] Break up cli.py::daily_run() — 105 lines #1168

New Issue
Closed
opened 2026-03-23 20:30:58 +00:00 by Timmy · 2 comments
Timmy commented 2026-03-23 20:30:58 +00:00
Owner
Copy Link

Problem

src/timmyctl/cli.py::daily_run() is 105 lines — too long for a single function.

Acceptance Criteria

  • Extract logical sections into helper functions
  • Keep daily_run() under 40 lines as an orchestrator
  • All existing tests pass (tox -e unit)

Files

  • src/timmyctl/cli.py
## Problem `src/timmyctl/cli.py::daily_run()` is 105 lines — too long for a single function. ## Acceptance Criteria - Extract logical sections into helper functions - Keep `daily_run()` under 40 lines as an orchestrator - All existing tests pass (`tox -e unit`) ## Files - `src/timmyctl/cli.py`
Timmy commented 2026-03-23 20:31:39 +00:00
Author
Owner
Copy Link

Kimi, break up src/timmyctl/cli.py::daily_run() (105 lines).

Steps:

  1. Read the function, identify 3-4 logical sections
  2. Extract each section into a private helper function in the same file
  3. Have daily_run() call the helpers — it should be under 40 lines
  4. Run tox -e unit to verify nothing breaks
  5. Branch: kimi/issue-1168, commit: refactor: break up cli.py::daily_run() (#1168)
Kimi, break up `src/timmyctl/cli.py::daily_run()` (105 lines). Steps: 1. Read the function, identify 3-4 logical sections 2. Extract each section into a private helper function in the same file 3. Have `daily_run()` call the helpers — it should be under 40 lines 4. Run `tox -e unit` to verify nothing breaks 5. Branch: `kimi/issue-1168`, commit: `refactor: break up cli.py::daily_run() (#1168)`
kimi was assigned by Timmy 2026-03-23 20:31:41 +00:00
kimi commented 2026-03-23 21:51:34 +00:00
Collaborator
Copy Link

PR created: #1189

Refactored cli.py::daily_run() from 105 lines to 33 lines by extracting 5 helper functions:

  • _load_daily_run_config() - Load and validate config
  • _display_schedules_table(schedules) - Display schedules table
  • _display_triggers_table(triggers) - Display triggers table
  • _execute_automation(auto, verbose) - Execute single automation
  • _execute_all_automations(verbose) - Execute all enabled automations

All 293 unit tests pass. Format and lint clean. ✅

**PR created:** #1189 Refactored `cli.py::daily_run()` from 105 lines to 33 lines by extracting 5 helper functions: - `_load_daily_run_config()` - Load and validate config - `_display_schedules_table(schedules)` - Display schedules table - `_display_triggers_table(triggers)` - Display triggers table - `_execute_automation(auto, verbose)` - Execute single automation - `_execute_all_automations(verbose)` - Execute all enabled automations All 293 unit tests pass. Format and lint clean. ✅
kimi closed this issue 2026-03-23 21:51:48 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
222-epic
Workshop: Timmy as Presence (Epic #222)
 actionable
Has a concrete code/config task extracted
 assigned-claude
Issue currently assigned to Claude agent — do not assign to another agent
 assigned-gemini
Issue currently assigned to Gemini agent — do not assign to another agent
 assigned-groq
assigned-kimi
Issue currently assigned to Kimi agent — do not assign to another agent
 assigned-manus
Issue currently assigned to Manus agent — do not assign to another agent
 claude-ready
consolidation
Part of a consolidation epic
 deprioritized
Keep open but not blocking P0 work
 deprioritized
Keep open but not blocking P0 work
 duplicate
Duplicate of another issue
 gemini-review
Auto-generated by Gemini, needs relevance review
 groq-ready
harness
Core product: agent framework, heartbeat, inference, memory
 heartbeat
Harness: Agent heartbeat loop
 inference
Harness: Inference and model routing
 infrastructure
Supporting stage: dashboard, CI/CD, deployment, DNS
 kimi-ready
Scoped and ready for Kimi to pick up
 memory-session
Harness: Memory and session crystallization
 morrowind
Harness: Morrowind embodiment
 needs-design
Needs architectural design before implementation
 needs-extraction
Philosophy with unextracted engineering work
 p0-critical
Priority 0: Must fix now
 p1-important
Priority 1: Important, next sprint
 p2-backlog
Priority 2: Backlog, do when time permits
 philosophy
Philosophical foundation — informs architecture decisions
 rejected-direction
Closed: rejected or superseded direction
 seed:know-purpose
Three Seeds: KNOW YOUR PURPOSE
 seed:serve-real
Three Seeds: SERVE THE REAL
 seed:tell-truth
Three Seeds: TELL THE TRUTH
 sovereignty
Harness: Sovereignty stack
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Timmy claude grok kimi manus perplexity Rockachopa
No Assignees kimi
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Rockachopa/Timmy-time-dashboard#1168
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?