Rockachopa/Timmy-time-dashboard
1
0
Fork 2
Code Issues 7 Pull Requests Actions Packages Projects Releases Wiki Activity

[loop-generated] [test] Add unit tests for src/config.py — 599 lines, critical module #1172

New Issue
Closed
opened 2026-03-23 20:31:05 +00:00 by Timmy · 2 comments
Timmy commented 2026-03-23 20:31:05 +00:00
Owner
Copy Link

Problem

src/config.py is 599 lines with no dedicated unit tests. This is the configuration module — correctness matters.

Acceptance Criteria

  • Add tests/unit/test_config.py (there's a tests/test_config_module.py but check coverage)
  • Test config loading, defaults, overrides, env var handling
  • Aim for 80%+ line coverage of config.py
  • Tests pass with tox -e unit

Files

  • src/config.py
  • tests/unit/test_config.py (new)
## Problem `src/config.py` is 599 lines with no dedicated unit tests. This is the configuration module — correctness matters. ## Acceptance Criteria - Add `tests/unit/test_config.py` (there's a `tests/test_config_module.py` but check coverage) - Test config loading, defaults, overrides, env var handling - Aim for 80%+ line coverage of config.py - Tests pass with `tox -e unit` ## Files - `src/config.py` - `tests/unit/test_config.py` (new)
claude was assigned by Rockachopa 2026-03-23 20:33:15 +00:00
claude commented 2026-03-23 20:42:26 +00:00
Collaborator
Copy Link

PR created: http://143.198.27.163:3000/rockachopa/Timmy-time-dashboard/pulls/1175

Added tests/unit/test_config.py with 118 new unit tests (pytestmark=pytest.mark.unit). All 293 unit tests pass with tox -e unit. Covers: normalize_ollama_url, Settings defaults, env overrides, type validation, _compute_repo_root, model_post_init token fallback, check_ollama_model_available, get_effective_ollama_model, validate_startup (dev/prod modes), APP_START_TIME, and the module singleton.

PR created: http://143.198.27.163:3000/rockachopa/Timmy-time-dashboard/pulls/1175 Added `tests/unit/test_config.py` with 118 new unit tests (pytestmark=pytest.mark.unit). All 293 unit tests pass with `tox -e unit`. Covers: normalize_ollama_url, Settings defaults, env overrides, type validation, _compute_repo_root, model_post_init token fallback, check_ollama_model_available, get_effective_ollama_model, validate_startup (dev/prod modes), APP_START_TIME, and the module singleton.
Timmy commented 2026-03-23 21:01:04 +00:00
Author
Owner
Copy Link

Kimi Instructions

Add unit tests for src/config.py (599 lines, critical module, 0 tests).

Files to modify

  • Create tests/test_config.py

What to test

  • All public functions and classes in src/config.py
  • Focus on: config loading, validation, default values, environment variable overrides
  • Edge cases: missing config file, invalid values, empty config
  • Mock external dependencies (file I/O, env vars)

How to verify

tox -e unit

All new tests must pass. Aim for good coverage of the public API.

## Kimi Instructions Add unit tests for `src/config.py` (599 lines, critical module, 0 tests). ### Files to modify - Create `tests/test_config.py` ### What to test - All public functions and classes in `src/config.py` - Focus on: config loading, validation, default values, environment variable overrides - Edge cases: missing config file, invalid values, empty config - Mock external dependencies (file I/O, env vars) ### How to verify ``` tox -e unit ``` All new tests must pass. Aim for good coverage of the public API.
claude was unassigned by Timmy 2026-03-23 21:01:05 +00:00
kimi was assigned by Timmy 2026-03-23 21:01:05 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
222-epic
Workshop: Timmy as Presence (Epic #222)
 actionable
Has a concrete code/config task extracted
 assigned-claude
Issue currently assigned to Claude agent — do not assign to another agent
 assigned-gemini
Issue currently assigned to Gemini agent — do not assign to another agent
 assigned-groq
assigned-kimi
Issue currently assigned to Kimi agent — do not assign to another agent
 assigned-manus
Issue currently assigned to Manus agent — do not assign to another agent
 claude-ready
consolidation
Part of a consolidation epic
 deprioritized
Keep open but not blocking P0 work
 deprioritized
Keep open but not blocking P0 work
 duplicate
Duplicate of another issue
 gemini-review
Auto-generated by Gemini, needs relevance review
 groq-ready
harness
Core product: agent framework, heartbeat, inference, memory
 heartbeat
Harness: Agent heartbeat loop
 inference
Harness: Inference and model routing
 infrastructure
Supporting stage: dashboard, CI/CD, deployment, DNS
 kimi-ready
Scoped and ready for Kimi to pick up
 memory-session
Harness: Memory and session crystallization
 morrowind
Harness: Morrowind embodiment
 needs-design
Needs architectural design before implementation
 needs-extraction
Philosophy with unextracted engineering work
 p0-critical
Priority 0: Must fix now
 p1-important
Priority 1: Important, next sprint
 p2-backlog
Priority 2: Backlog, do when time permits
 philosophy
Philosophical foundation — informs architecture decisions
 rejected-direction
Closed: rejected or superseded direction
 seed:know-purpose
Three Seeds: KNOW YOUR PURPOSE
 seed:serve-real
Three Seeds: SERVE THE REAL
 seed:tell-truth
Three Seeds: TELL THE TRUTH
 sovereignty
Harness: Sovereignty stack
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Timmy claude grok groq kimi manus perplexity Rockachopa
No Assignees kimi
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Rockachopa/Timmy-time-dashboard#1172
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?