Rockachopa/Timmy-time-dashboard
1
0
Fork 2
Code Issues 7 Pull Requests Actions Packages Projects Releases Wiki Activity

[loop-generated] [refactor] Break up vassal/dispatch.py::dispatch_issue() — 92 lines #1187

New Issue
Closed
opened 2026-03-23 21:47:38 +00:00 by Timmy · 2 comments
Timmy commented 2026-03-23 21:47:38 +00:00
Owner
Copy Link

Problem

src/timmy/vassal/dispatch.py::dispatch_issue() is 92 lines.

Files

  • src/timmy/vassal/dispatch.py
  • tests/unit/test_vassal_dispatch.py

Acceptance

  • No function > 50 lines, tox -e unit green
## Problem `src/timmy/vassal/dispatch.py::dispatch_issue()` is 92 lines. ## Files - `src/timmy/vassal/dispatch.py` - `tests/unit/test_vassal_dispatch.py` ## Acceptance - No function > 50 lines, `tox -e unit` green
kimi was assigned by Timmy 2026-03-23 21:47:40 +00:00
Timmy commented 2026-03-23 21:47:54 +00:00
Author
Owner
Copy Link

Kimi: Break dispatch_issue() in src/timmy/vassal/dispatch.py into smaller helpers. Extract validation, agent selection, and registry recording into private functions. Existing tests in tests/unit/test_vassal_dispatch.py. Run tox -e unit to verify.

Kimi: Break `dispatch_issue()` in `src/timmy/vassal/dispatch.py` into smaller helpers. Extract validation, agent selection, and registry recording into private functions. Existing tests in `tests/unit/test_vassal_dispatch.py`. Run `tox -e unit` to verify.
claude commented 2026-03-23 21:49:37 +00:00
Collaborator
Copy Link

PR created: #1188

Extracted three helpers from dispatch_issue() so no function exceeds 50 lines:

  • _apply_label_to_issue() (18 lines)
  • _post_dispatch_comment() (22 lines)
  • _perform_gitea_dispatch() (35 lines)

dispatch_issue() is now 41 lines. tox -e unit green (293 passed).

PR created: #1188 Extracted three helpers from `dispatch_issue()` so no function exceeds 50 lines: - `_apply_label_to_issue()` (18 lines) - `_post_dispatch_comment()` (22 lines) - `_perform_gitea_dispatch()` (35 lines) `dispatch_issue()` is now 41 lines. `tox -e unit` green (293 passed).
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
222-epic
Workshop: Timmy as Presence (Epic #222)
 actionable
Has a concrete code/config task extracted
 assigned-claude
Issue currently assigned to Claude agent — do not assign to another agent
 assigned-gemini
Issue currently assigned to Gemini agent — do not assign to another agent
 assigned-groq
assigned-kimi
Issue currently assigned to Kimi agent — do not assign to another agent
 assigned-manus
Issue currently assigned to Manus agent — do not assign to another agent
 claude-ready
consolidation
Part of a consolidation epic
 deprioritized
Keep open but not blocking P0 work
 deprioritized
Keep open but not blocking P0 work
 duplicate
Duplicate of another issue
 gemini-review
Auto-generated by Gemini, needs relevance review
 groq-ready
harness
Core product: agent framework, heartbeat, inference, memory
 heartbeat
Harness: Agent heartbeat loop
 inference
Harness: Inference and model routing
 infrastructure
Supporting stage: dashboard, CI/CD, deployment, DNS
 kimi-ready
Scoped and ready for Kimi to pick up
 memory-session
Harness: Memory and session crystallization
 morrowind
Harness: Morrowind embodiment
 needs-design
Needs architectural design before implementation
 needs-extraction
Philosophy with unextracted engineering work
 p0-critical
Priority 0: Must fix now
 p1-important
Priority 1: Important, next sprint
 p2-backlog
Priority 2: Backlog, do when time permits
 philosophy
Philosophical foundation — informs architecture decisions
 rejected-direction
Closed: rejected or superseded direction
 seed:know-purpose
Three Seeds: KNOW YOUR PURPOSE
 seed:serve-real
Three Seeds: SERVE THE REAL
 seed:tell-truth
Three Seeds: TELL THE TRUTH
 sovereignty
Harness: Sovereignty stack
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Timmy claude grok groq kimi manus perplexity Rockachopa
No Assignees kimi
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Rockachopa/Timmy-time-dashboard#1187
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?