Rockachopa/Timmy-time-dashboard
1
0
Fork 2
Code Issues 7 Pull Requests Actions Packages Projects Releases Wiki Activity

[loop-generated] [test] Add unit tests for event bus (bus.py) — 356 lines, 0 tests #1191

New Issue
Closed
opened 2026-03-23 21:53:15 +00:00 by Timmy · 2 comments
Timmy commented 2026-03-23 21:53:15 +00:00
Owner
Copy Link

Problem

src/infrastructure/events/bus.py is 356 lines with zero test coverage. The event bus is core infrastructure — it routes events between components.

Acceptance Criteria

  • Create tests/infrastructure/test_event_bus.py
  • Test event registration, publishing, and subscriber notification
  • Test error handling in subscribers
  • Test async event handling if applicable
  • All new tests pass via tox -e unit
  • No changes to production code unless fixing discovered bugs
## Problem `src/infrastructure/events/bus.py` is 356 lines with zero test coverage. The event bus is core infrastructure — it routes events between components. ## Acceptance Criteria - [ ] Create `tests/infrastructure/test_event_bus.py` - [ ] Test event registration, publishing, and subscriber notification - [ ] Test error handling in subscribers - [ ] Test async event handling if applicable - [ ] All new tests pass via `tox -e unit` - [ ] No changes to production code unless fixing discovered bugs
claude self-assigned this 2026-03-23 21:53:29 +00:00
Timmy commented 2026-03-23 21:53:32 +00:00
Author
Owner
Copy Link

Kimi instructions:

  • File: src/infrastructure/events/bus.py
  • Create: tests/infrastructure/test_event_bus.py
  • Read the bus.py source, identify all public methods
  • Write tests for each: subscribe, publish, unsubscribe
  • Mock external dependencies
  • Run tox -e unit to verify
  • Target: 10+ test cases
Kimi instructions: - File: `src/infrastructure/events/bus.py` - Create: `tests/infrastructure/test_event_bus.py` - Read the bus.py source, identify all public methods - Write tests for each: subscribe, publish, unsubscribe - Mock external dependencies - Run `tox -e unit` to verify - Target: 10+ test cases
claude commented 2026-03-23 21:59:55 +00:00
Collaborator
Copy Link

PR created: #1201

The base test suite (30 tests) already existed from a prior commit. This PR adds 8 more tests covering the previously uncovered paths:

  • get_event_bus() singleton, init_event_bus_persistence() (idempotency + default path), module __getattr__ error path
  • Exception-swallowing in _persist_event() and replay()

Coverage: 92.7% → 99.3% (38 tests passing).

PR created: #1201 The base test suite (30 tests) already existed from a prior commit. This PR adds 8 more tests covering the previously uncovered paths: - `get_event_bus()` singleton, `init_event_bus_persistence()` (idempotency + default path), module `__getattr__` error path - Exception-swallowing in `_persist_event()` and `replay()` Coverage: **92.7% → 99.3%** (38 tests passing).
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
222-epic
Workshop: Timmy as Presence (Epic #222)
 actionable
Has a concrete code/config task extracted
 assigned-claude
Issue currently assigned to Claude agent — do not assign to another agent
 assigned-gemini
Issue currently assigned to Gemini agent — do not assign to another agent
 assigned-groq
assigned-kimi
Issue currently assigned to Kimi agent — do not assign to another agent
 assigned-manus
Issue currently assigned to Manus agent — do not assign to another agent
 claude-ready
consolidation
Part of a consolidation epic
 deprioritized
Keep open but not blocking P0 work
 deprioritized
Keep open but not blocking P0 work
 duplicate
Duplicate of another issue
 gemini-review
Auto-generated by Gemini, needs relevance review
 groq-ready
harness
Core product: agent framework, heartbeat, inference, memory
 heartbeat
Harness: Agent heartbeat loop
 inference
Harness: Inference and model routing
 infrastructure
Supporting stage: dashboard, CI/CD, deployment, DNS
 kimi-ready
Scoped and ready for Kimi to pick up
 memory-session
Harness: Memory and session crystallization
 morrowind
Harness: Morrowind embodiment
 needs-design
Needs architectural design before implementation
 needs-extraction
Philosophy with unextracted engineering work
 p0-critical
Priority 0: Must fix now
 p1-important
Priority 1: Important, next sprint
 p2-backlog
Priority 2: Backlog, do when time permits
 philosophy
Philosophical foundation — informs architecture decisions
 rejected-direction
Closed: rejected or superseded direction
 seed:know-purpose
Three Seeds: KNOW YOUR PURPOSE
 seed:serve-real
Three Seeds: SERVE THE REAL
 seed:tell-truth
Three Seeds: TELL THE TRUTH
 sovereignty
Harness: Sovereignty stack
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Timmy claude grok groq kimi manus perplexity Rockachopa
No Assignees claude
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Rockachopa/Timmy-time-dashboard#1191
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?