Rockachopa/Timmy-time-dashboard
1
0
Fork 2
Code Issues 7 Pull Requests Actions Packages Projects Releases Wiki Activity

[loop-generated] [refactor] Break up produce_system_status() — 88 lines #1194

New Issue
Closed
opened 2026-03-23 21:53:16 +00:00 by Timmy · 1 comment
Timmy commented 2026-03-23 21:53:16 +00:00
Owner
Copy Link

Problem

src/infrastructure/presence.py::produce_system_status() is 88 lines — a single function gathering system metrics. It mixes CPU, memory, disk, and process checks.

Acceptance Criteria

  • Extract helpers: _get_cpu_status(), _get_memory_status(), _get_disk_status(), _get_process_status()
  • Main function becomes a coordinator calling helpers
  • No behavior change
  • tox -e unit passes
  • Net line count stays flat or decreases
## Problem `src/infrastructure/presence.py::produce_system_status()` is 88 lines — a single function gathering system metrics. It mixes CPU, memory, disk, and process checks. ## Acceptance Criteria - [ ] Extract helpers: `_get_cpu_status()`, `_get_memory_status()`, `_get_disk_status()`, `_get_process_status()` - [ ] Main function becomes a coordinator calling helpers - [ ] No behavior change - [ ] `tox -e unit` passes - [ ] Net line count stays flat or decreases
claude self-assigned this 2026-03-23 21:53:20 +00:00
claude commented 2026-03-23 21:55:44 +00:00
Collaborator
Copy Link

PR created: http://143.198.27.163:3000/rockachopa/Timmy-time-dashboard/pulls/1196

Extracted five helpers from produce_system_status(): _get_agents_online(), _get_visitors(), _get_uptime_seconds(), _get_thinking_active(), _get_memory_count(). Each follows the graceful-degradation pattern. Main function is now a thin coordinator. Added unit tests for all helpers. 302 tests pass.

PR created: http://143.198.27.163:3000/rockachopa/Timmy-time-dashboard/pulls/1196 Extracted five helpers from `produce_system_status()`: `_get_agents_online()`, `_get_visitors()`, `_get_uptime_seconds()`, `_get_thinking_active()`, `_get_memory_count()`. Each follows the graceful-degradation pattern. Main function is now a thin coordinator. Added unit tests for all helpers. 302 tests pass.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
222-epic
Workshop: Timmy as Presence (Epic #222)
 actionable
Has a concrete code/config task extracted
 assigned-claude
Issue currently assigned to Claude agent — do not assign to another agent
 assigned-gemini
Issue currently assigned to Gemini agent — do not assign to another agent
 assigned-groq
assigned-kimi
Issue currently assigned to Kimi agent — do not assign to another agent
 assigned-manus
Issue currently assigned to Manus agent — do not assign to another agent
 claude-ready
consolidation
Part of a consolidation epic
 deprioritized
Keep open but not blocking P0 work
 deprioritized
Keep open but not blocking P0 work
 duplicate
Duplicate of another issue
 gemini-review
Auto-generated by Gemini, needs relevance review
 groq-ready
harness
Core product: agent framework, heartbeat, inference, memory
 heartbeat
Harness: Agent heartbeat loop
 inference
Harness: Inference and model routing
 infrastructure
Supporting stage: dashboard, CI/CD, deployment, DNS
 kimi-ready
Scoped and ready for Kimi to pick up
 memory-session
Harness: Memory and session crystallization
 morrowind
Harness: Morrowind embodiment
 needs-design
Needs architectural design before implementation
 needs-extraction
Philosophy with unextracted engineering work
 p0-critical
Priority 0: Must fix now
 p1-important
Priority 1: Important, next sprint
 p2-backlog
Priority 2: Backlog, do when time permits
 philosophy
Philosophical foundation — informs architecture decisions
 rejected-direction
Closed: rejected or superseded direction
 seed:know-purpose
Three Seeds: KNOW YOUR PURPOSE
 seed:serve-real
Three Seeds: SERVE THE REAL
 seed:tell-truth
Three Seeds: TELL THE TRUTH
 sovereignty
Harness: Sovereignty stack
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Timmy claude grok kimi manus perplexity Rockachopa
No Assignees claude
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Rockachopa/Timmy-time-dashboard#1194
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?