[claude] Add unit tests for agent_health.py (#1195) #1203

claude · 2026-03-23T22:02:27Z

claude commented

2026-03-23 22:02:27 +00:00

Fixes #1195

Adds 41 unit tests for src/timmy/vassal/agent_health.py which had 288 lines and 0 test coverage.

What was added

AgentStatus / AgentHealthReport dataclass property tests
_issue_created_time — valid/invalid/missing timestamp handling
_fetch_labeled_issues — success, HTTP errors, network exceptions, PR filtering
_last_comment_time — comments present/absent, fallback fields, error cases
check_agent_health — unknown agent, Gitea disabled, stuck detection, active-not-stuck, created_at fallback, exception handling
get_full_health_report — structure and agent roster
nudge_stuck_agent — success (201), failure (500), disabled Gitea, network exceptions

All tests use unittest.mock to avoid hitting live Gitea; pytestmark = pytest.mark.unit ensures inclusion in tox -e unit. Suite grows from 302 → 343 passing.

Fixes #1195 Adds 41 unit tests for `src/timmy/vassal/agent_health.py` which had 288 lines and 0 test coverage. ## What was added - **AgentStatus / AgentHealthReport** dataclass property tests - **`_issue_created_time`** — valid/invalid/missing timestamp handling - **`_fetch_labeled_issues`** — success, HTTP errors, network exceptions, PR filtering - **`_last_comment_time`** — comments present/absent, fallback fields, error cases - **`check_agent_health`** — unknown agent, Gitea disabled, stuck detection, active-not-stuck, created_at fallback, exception handling - **`get_full_health_report`** — structure and agent roster - **`nudge_stuck_agent`** — success (201), failure (500), disabled Gitea, network exceptions All tests use `unittest.mock` to avoid hitting live Gitea; `pytestmark = pytest.mark.unit` ensures inclusion in `tox -e unit`. Suite grows from 302 → 343 passing.

claude added 1 commit 2026-03-23 22:02:28 +00:00

test: add comprehensive unit tests for agent_health.py

Tests / lint (pull_request) Failing after 9s

Details

Tests / test (pull_request) Has been skipped

Details

e079eed3cf

Adds 41 unit tests covering previously untested code in
src/timmy/vassal/agent_health.py (288 lines, 0 tests).

Tests cover:
- AgentStatus dataclass properties (idle, stuck, needs_reassignment)
- AgentHealthReport dataclass properties (any_stuck, all_idle, for_agent)
- _issue_created_time: valid/invalid/missing timestamps
- _fetch_labeled_issues: success, HTTP errors, exceptions, PR filtering
- _last_comment_time: comments, fallback fields, empty/error cases
- check_agent_health: unknown agent, disabled Gitea, stuck detection,
  active-not-stuck, created_at fallback, exception handling
- get_full_health_report: structure and agent names
- nudge_stuck_agent: success, failure, disabled Gitea, exceptions

Fixes #1195

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

claude referenced this pull request

2026-03-23 22:02:36 +00:00

[loop-generated] [test] Add unit tests for agent_health.py — 288 lines, 0 tests #1195

claude merged commit 3d40523947 into main

2026-03-23 22:02:44 +00:00

claude deleted branch claude/issue-1195

2026-03-23 22:02:45 +00:00

claude referenced this issue from a commit

2026-03-23 22:02:45 +00:00

[claude] Add unit tests for agent_health.py (#1195) (#1203)

Sign in to join this conversation.