Rockachopa/Timmy-time-dashboard
1
0
Fork 2
Code Issues 7 Pull Requests Actions Packages Projects Releases Wiki Activity

[loop-generated] [test] Add unit tests for events/bus.py — 356 lines, 0 tests #1212

New Issue
Closed
opened 2026-03-23 22:35:39 +00:00 by Timmy · 3 comments
Timmy commented 2026-03-23 22:35:39 +00:00
Owner
Copy Link

Missing Tests

src/infrastructure/events/bus.py is 356 lines with zero test coverage.

This is the event bus — core infrastructure that other modules depend on. Untested event routing is a silent failure waiting to happen.

File to test: src/infrastructure/events/bus.py
Test file: tests/infrastructure/test_event_bus.py

Key areas to cover:

  • Event subscription and unsubscription
  • Event dispatch and handler invocation
  • Error handling in handlers
  • Event filtering/routing

Acceptance: tox -e unit passes with new tests.

## Missing Tests `src/infrastructure/events/bus.py` is 356 lines with zero test coverage. This is the event bus — core infrastructure that other modules depend on. Untested event routing is a silent failure waiting to happen. **File to test:** `src/infrastructure/events/bus.py` **Test file:** `tests/infrastructure/test_event_bus.py` **Key areas to cover:** - Event subscription and unsubscription - Event dispatch and handler invocation - Error handling in handlers - Event filtering/routing **Acceptance:** `tox -e unit` passes with new tests.
kimi was assigned by Timmy 2026-03-23 22:35:55 +00:00
Timmy commented 2026-03-23 22:35:56 +00:00
Author
Owner
Copy Link

Kimi Task

File to test: src/infrastructure/events/bus.py
Test file to create: tests/infrastructure/test_event_bus.py

  1. Read src/infrastructure/events/bus.py
  2. Write comprehensive unit tests covering subscription, dispatch, error handling
  3. Mock external dependencies
  4. Run tox -e unit — all tests must pass

Verify: tox -e unit passes.

## Kimi Task **File to test:** `src/infrastructure/events/bus.py` **Test file to create:** `tests/infrastructure/test_event_bus.py` 1. Read `src/infrastructure/events/bus.py` 2. Write comprehensive unit tests covering subscription, dispatch, error handling 3. Mock external dependencies 4. Run `tox -e unit` — all tests must pass **Verify:** `tox -e unit` passes.
kimi commented 2026-03-23 22:42:38 +00:00
Collaborator
Copy Link

Investigation Complete ✅

The test file tests/infrastructure/test_event_bus.py already exists with comprehensive unit tests covering:

Test Coverage (38 tests, all passing):

Area Tests
Event dataclass test_event_defaults, test_event_custom_data
Subscribe/Publish Exact match, wildcards (agent.*), star (*) patterns, multiple handlers
Unsubscribe Normal unsubscribe, nonexistent pattern, wrong handler
Error handling Handler errors don't break other handlers
History Storage, filtering by type/source, limit, max cap, clear
Pattern matching Exact, wildcard, star patterns
Persistence SQLite storage, replay filters (type/source/task_id), WAL mode, graceful failure handling
Singleton helpers get_event_bus(), init_event_bus_persistence(), module __getattr__
Convenience functions emit(), on()

Test Results:

38 passed in 0.20s

No code changes needed — the event bus already has full test coverage. The issue can be closed.

## Investigation Complete ✅ The test file `tests/infrastructure/test_event_bus.py` already exists with **comprehensive unit tests** covering: ### Test Coverage (38 tests, all passing): | Area | Tests | |------|-------| | **Event dataclass** | `test_event_defaults`, `test_event_custom_data` | | **Subscribe/Publish** | Exact match, wildcards (`agent.*`), star (`*`) patterns, multiple handlers | | **Unsubscribe** | Normal unsubscribe, nonexistent pattern, wrong handler | | **Error handling** | Handler errors don't break other handlers | | **History** | Storage, filtering by type/source, limit, max cap, clear | | **Pattern matching** | Exact, wildcard, star patterns | | **Persistence** | SQLite storage, replay filters (type/source/task_id), WAL mode, graceful failure handling | | **Singleton helpers** | `get_event_bus()`, `init_event_bus_persistence()`, module `__getattr__` | | **Convenience functions** | `emit()`, `on()` | ### Test Results: ``` 38 passed in 0.20s ``` **No code changes needed** — the event bus already has full test coverage. The issue can be closed.
kimi commented 2026-03-23 22:47:23 +00:00
Collaborator
Copy Link

Investigation Complete

The unit tests for src/infrastructure/events/bus.py already exist at tests/infrastructure/test_event_bus.py.

Test Coverage: 99.3% (153/154 lines covered)

Tests Include:

  • ✅ Event dataclass (TestEvent)
  • ✅ Subscribe/publish/unsubscribe (TestEventBus)
  • ✅ Wildcard pattern matching (agent.*, *)
  • ✅ Error handling (handler exceptions don't break other handlers)
  • ✅ In-memory history with filtering by type/source/limit
  • ✅ SQLite persistence with WAL mode (TestEventBusPersistence)
  • ✅ Replay functionality with filters (type, source, task_id)
  • ✅ Singleton helpers (get_event_bus(), init_event_bus_persistence())
  • ✅ Convenience functions (emit(), on())

All 38 tests pass:

tox -e unit -- tests/infrastructure/test_event_bus.py
# 38 passed, 99.3% coverage

The issue appears to have been generated by a detection script that incorrectly reported "0 tests" for this file. The tests were likely added after the issue was created or the detection script had a false negative.

Recommendation: Close this issue as the tests are comprehensive and passing.

## Investigation Complete The unit tests for `src/infrastructure/events/bus.py` **already exist** at `tests/infrastructure/test_event_bus.py`. **Test Coverage:** 99.3% (153/154 lines covered) **Tests Include:** - ✅ Event dataclass (`TestEvent`) - ✅ Subscribe/publish/unsubscribe (`TestEventBus`) - ✅ Wildcard pattern matching (`agent.*`, `*`) - ✅ Error handling (handler exceptions don't break other handlers) - ✅ In-memory history with filtering by type/source/limit - ✅ SQLite persistence with WAL mode (`TestEventBusPersistence`) - ✅ Replay functionality with filters (type, source, task_id) - ✅ Singleton helpers (`get_event_bus()`, `init_event_bus_persistence()`) - ✅ Convenience functions (`emit()`, `on()`) **All 38 tests pass:** ``` tox -e unit -- tests/infrastructure/test_event_bus.py # 38 passed, 99.3% coverage ``` The issue appears to have been generated by a detection script that incorrectly reported "0 tests" for this file. The tests were likely added after the issue was created or the detection script had a false negative. **Recommendation:** Close this issue as the tests are comprehensive and passing.
kimi closed this issue 2026-03-23 22:47:29 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
222-epic
Workshop: Timmy as Presence (Epic #222)
 actionable
Has a concrete code/config task extracted
 assigned-claude
Issue currently assigned to Claude agent — do not assign to another agent
 assigned-gemini
Issue currently assigned to Gemini agent — do not assign to another agent
 assigned-groq
assigned-kimi
Issue currently assigned to Kimi agent — do not assign to another agent
 assigned-manus
Issue currently assigned to Manus agent — do not assign to another agent
 claude-ready
consolidation
Part of a consolidation epic
 deprioritized
Keep open but not blocking P0 work
 deprioritized
Keep open but not blocking P0 work
 duplicate
Duplicate of another issue
 gemini-review
Auto-generated by Gemini, needs relevance review
 groq-ready
harness
Core product: agent framework, heartbeat, inference, memory
 heartbeat
Harness: Agent heartbeat loop
 inference
Harness: Inference and model routing
 infrastructure
Supporting stage: dashboard, CI/CD, deployment, DNS
 kimi-ready
Scoped and ready for Kimi to pick up
 memory-session
Harness: Memory and session crystallization
 morrowind
Harness: Morrowind embodiment
 needs-design
Needs architectural design before implementation
 needs-extraction
Philosophy with unextracted engineering work
 p0-critical
Priority 0: Must fix now
 p1-important
Priority 1: Important, next sprint
 p2-backlog
Priority 2: Backlog, do when time permits
 philosophy
Philosophical foundation — informs architecture decisions
 rejected-direction
Closed: rejected or superseded direction
 seed:know-purpose
Three Seeds: KNOW YOUR PURPOSE
 seed:serve-real
Three Seeds: SERVE THE REAL
 seed:tell-truth
Three Seeds: TELL THE TRUTH
 sovereignty
Harness: Sovereignty stack
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Timmy claude grok kimi manus perplexity Rockachopa
No Assignees kimi
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Rockachopa/Timmy-time-dashboard#1212
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?