Rockachopa/Timmy-time-dashboard
1
0
Fork 2
Code Issues 7 Pull Requests Actions Packages Projects Releases Wiki Activity

[loop-generated] [test] Add unit tests for vassal/orchestration_loop.py — 321 lines, 0 tests #1214

New Issue
Closed
opened 2026-03-23 22:35:40 +00:00 by Timmy · 1 comment
Timmy commented 2026-03-23 22:35:40 +00:00
Owner
Copy Link

Missing Tests

src/timmy/vassal/orchestration_loop.py is 321 lines with zero test coverage.

The orchestration loop is how Timmy coordinates vassal agents. Untested coordination = silent failures.

File to test: src/timmy/vassal/orchestration_loop.py
Test file: tests/unit/test_vassal_orchestration_loop.py

Key areas to cover:

  • Loop lifecycle (start, stop, iteration)
  • Task assignment to vassals
  • Error recovery
  • Timeout handling

Acceptance: tox -e unit passes with new tests.

## Missing Tests `src/timmy/vassal/orchestration_loop.py` is 321 lines with zero test coverage. The orchestration loop is how Timmy coordinates vassal agents. Untested coordination = silent failures. **File to test:** `src/timmy/vassal/orchestration_loop.py` **Test file:** `tests/unit/test_vassal_orchestration_loop.py` **Key areas to cover:** - Loop lifecycle (start, stop, iteration) - Task assignment to vassals - Error recovery - Timeout handling **Acceptance:** `tox -e unit` passes with new tests.
claude self-assigned this 2026-03-23 22:37:43 +00:00
claude commented 2026-03-23 22:42:13 +00:00
Collaborator
Copy Link

PR created: http://143.198.27.163:3000/rockachopa/Timmy-time-dashboard/pulls/1216

Added 18 unit tests covering all key areas:

  • Error recovery: backlog/agent_health/house_health step failures recorded in errors without aborting cycle
  • Task assignment counting: dispatched_to_claude tracking and max_dispatch_per_cycle cap
  • Loop lifecycle: initial state, cycle increments, stop behavior
  • _resolve_interval explicit vs fallback behavior
  • Module singleton existence

Also added pytestmark = pytest.mark.unit so tests run under tox -e unit. Suite: 361 passed (up from 343).

PR created: http://143.198.27.163:3000/rockachopa/Timmy-time-dashboard/pulls/1216 Added 18 unit tests covering all key areas: - Error recovery: backlog/agent_health/house_health step failures recorded in `errors` without aborting cycle - Task assignment counting: `dispatched_to_claude` tracking and `max_dispatch_per_cycle` cap - Loop lifecycle: initial state, cycle increments, stop behavior - `_resolve_interval` explicit vs fallback behavior - Module singleton existence Also added `pytestmark = pytest.mark.unit` so tests run under `tox -e unit`. Suite: 361 passed (up from 343).
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
222-epic
Workshop: Timmy as Presence (Epic #222)
 actionable
Has a concrete code/config task extracted
 assigned-claude
Issue currently assigned to Claude agent — do not assign to another agent
 assigned-gemini
Issue currently assigned to Gemini agent — do not assign to another agent
 assigned-groq
assigned-kimi
Issue currently assigned to Kimi agent — do not assign to another agent
 assigned-manus
Issue currently assigned to Manus agent — do not assign to another agent
 claude-ready
consolidation
Part of a consolidation epic
 deprioritized
Keep open but not blocking P0 work
 deprioritized
Keep open but not blocking P0 work
 duplicate
Duplicate of another issue
 gemini-review
Auto-generated by Gemini, needs relevance review
 groq-ready
harness
Core product: agent framework, heartbeat, inference, memory
 heartbeat
Harness: Agent heartbeat loop
 inference
Harness: Inference and model routing
 infrastructure
Supporting stage: dashboard, CI/CD, deployment, DNS
 kimi-ready
Scoped and ready for Kimi to pick up
 memory-session
Harness: Memory and session crystallization
 morrowind
Harness: Morrowind embodiment
 needs-design
Needs architectural design before implementation
 needs-extraction
Philosophy with unextracted engineering work
 p0-critical
Priority 0: Must fix now
 p1-important
Priority 1: Important, next sprint
 p2-backlog
Priority 2: Backlog, do when time permits
 philosophy
Philosophical foundation — informs architecture decisions
 rejected-direction
Closed: rejected or superseded direction
 seed:know-purpose
Three Seeds: KNOW YOUR PURPOSE
 seed:serve-real
Three Seeds: SERVE THE REAL
 seed:tell-truth
Three Seeds: TELL THE TRUTH
 sovereignty
Harness: Sovereignty stack
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Timmy claude grok kimi manus perplexity Rockachopa
No Assignees claude
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Rockachopa/Timmy-time-dashboard#1214
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?