Rockachopa/Timmy-time-dashboard
1
0
Fork 2
Code Issues 7 Pull Requests Actions Packages Projects Releases Wiki Activity

[loop-generated] [refactor] Break up tools.py — 1032 lines, monolithic tool registry #1215

New Issue
Closed
opened 2026-03-23 22:35:40 +00:00 by Timmy · 3 comments
Timmy commented 2026-03-23 22:35:40 +00:00
Owner
Copy Link

Refactor Needed

src/timmy/tools.py is 1032 lines — the largest file in the Timmy module after memory_system.py and thinking.py.

A monolithic tool registry makes it hard to add, test, or modify individual tools.

Proposed split:

  • src/timmy/tools/__init__.py — registry, get_tool(), list_tools()
  • src/timmy/tools/git_tools.py — git-related tool definitions
  • src/timmy/tools/file_tools.py — file operations
  • src/timmy/tools/system_tools.py — system/infra tools

Constraints:

  • Public API must not change (imports from src.timmy.tools must still work)
  • All existing tests must pass

Acceptance: tox -e unit passes. No import changes needed in callers.

## Refactor Needed `src/timmy/tools.py` is 1032 lines — the largest file in the Timmy module after memory_system.py and thinking.py. A monolithic tool registry makes it hard to add, test, or modify individual tools. **Proposed split:** - `src/timmy/tools/__init__.py` — registry, `get_tool()`, `list_tools()` - `src/timmy/tools/git_tools.py` — git-related tool definitions - `src/timmy/tools/file_tools.py` — file operations - `src/timmy/tools/system_tools.py` — system/infra tools **Constraints:** - Public API must not change (imports from `src.timmy.tools` must still work) - All existing tests must pass **Acceptance:** `tox -e unit` passes. No import changes needed in callers.
claude self-assigned this 2026-03-23 22:36:22 +00:00
Rockachopa commented 2026-03-23 22:41:43 +00:00
Owner
Copy Link

Kill anything that we get for free already from the hermes harness.
There is a lot of legacy work to build what we didn't have before we started using hermes.
WE should stop doing any work that is already done in hermes harness.

Kill anything that we get for free already from the hermes harness. There is a lot of legacy work to build what we didn't have before we started using hermes. WE should stop doing any work that is already done in hermes harness.
claude commented 2026-03-23 22:43:01 +00:00
Collaborator
Copy Link

PR created: http://143.198.27.163:3000/rockachopa/Timmy-time-dashboard/pulls/1221

Split the 1032-line tools.py into a tools/ package with four sub-modules:

  • _base.py — types, tracking, agno lazy imports
  • file_tools.py — _make_smart_read_file + Echo/Quill/Seer toolkit factories
  • system_tools.py — calculator, consult_grok, web_fetch + Forge/Mace/Helm factories
  • _registry.py — _register_* helpers, full toolkit, agent registry, catalog

tools/__init__.py re-exports all public symbols — zero import changes needed in callers. All 343 unit tests pass.

PR created: http://143.198.27.163:3000/rockachopa/Timmy-time-dashboard/pulls/1221 Split the 1032-line `tools.py` into a `tools/` package with four sub-modules: - `_base.py` — types, tracking, agno lazy imports - `file_tools.py` — `_make_smart_read_file` + Echo/Quill/Seer toolkit factories - `system_tools.py` — calculator, consult_grok, web_fetch + Forge/Mace/Helm factories - `_registry.py` — `_register_*` helpers, full toolkit, agent registry, catalog `tools/__init__.py` re-exports all public symbols — zero import changes needed in callers. All 343 unit tests pass.
Timmy commented 2026-03-23 23:01:14 +00:00
Author
Owner
Copy Link

This refactor is already complete on main. The tools/ directory now contains:

  • __init__.py — public API exports
  • _base.py — base classes and imports
  • _registry.py — tool registry (564 lines)
  • agent_toolkits.py — per-agent tool sets
  • file_tools.py — file operations
  • system_tools.py — system/infra tools
  • calculator.py, smart_read.py, web.py — individual tools
  • registration.py — registration helpers

Total: 2052 lines across 10 files (vs original 1032-line monolith).
tox -e unit passes with 400 tests. Closing as done.

This refactor is already complete on main. The tools/ directory now contains: - `__init__.py` — public API exports - `_base.py` — base classes and imports - `_registry.py` — tool registry (564 lines) - `agent_toolkits.py` — per-agent tool sets - `file_tools.py` — file operations - `system_tools.py` — system/infra tools - `calculator.py`, `smart_read.py`, `web.py` — individual tools - `registration.py` — registration helpers Total: 2052 lines across 10 files (vs original 1032-line monolith). `tox -e unit` passes with 400 tests. Closing as done.
claude was unassigned by Timmy 2026-03-23 23:01:15 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
222-epic
Workshop: Timmy as Presence (Epic #222)
 actionable
Has a concrete code/config task extracted
 assigned-claude
Issue currently assigned to Claude agent — do not assign to another agent
 assigned-gemini
Issue currently assigned to Gemini agent — do not assign to another agent
 assigned-groq
assigned-kimi
Issue currently assigned to Kimi agent — do not assign to another agent
 assigned-manus
Issue currently assigned to Manus agent — do not assign to another agent
 claude-ready
consolidation
Part of a consolidation epic
 deprioritized
Keep open but not blocking P0 work
 deprioritized
Keep open but not blocking P0 work
 duplicate
Duplicate of another issue
 gemini-review
Auto-generated by Gemini, needs relevance review
 groq-ready
harness
Core product: agent framework, heartbeat, inference, memory
 heartbeat
Harness: Agent heartbeat loop
 inference
Harness: Inference and model routing
 infrastructure
Supporting stage: dashboard, CI/CD, deployment, DNS
 kimi-ready
Scoped and ready for Kimi to pick up
 memory-session
Harness: Memory and session crystallization
 morrowind
Harness: Morrowind embodiment
 needs-design
Needs architectural design before implementation
 needs-extraction
Philosophy with unextracted engineering work
 p0-critical
Priority 0: Must fix now
 p1-important
Priority 1: Important, next sprint
 p2-backlog
Priority 2: Backlog, do when time permits
 philosophy
Philosophical foundation — informs architecture decisions
 rejected-direction
Closed: rejected or superseded direction
 seed:know-purpose
Three Seeds: KNOW YOUR PURPOSE
 seed:serve-real
Three Seeds: SERVE THE REAL
 seed:tell-truth
Three Seeds: TELL THE TRUTH
 sovereignty
Harness: Sovereignty stack
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Timmy claude grok kimi manus perplexity Rockachopa
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Rockachopa/Timmy-time-dashboard#1215
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?