Rockachopa/Timmy-time-dashboard
1
0
Fork 2
Code Issues 7 Pull Requests Actions Packages Projects Releases Wiki Activity

[loop-generated] [bug] Pre-existing ruff lint errors block git hooks on all branches #1247

New Issue
Closed
opened 2026-03-23 23:29:31 +00:00 by Timmy · 1 comment
Timmy commented 2026-03-23 23:29:31 +00:00
Owner
Copy Link

Problem

5 ruff errors exist on main that cause tox -e format to fail, which blocks the pre-commit hook for ALL branches:

  1. F821 Undefined name TaskComplexity in src/infrastructure/router/cascade.py:597
  2. F401 Unused imports (FileTools, PythonTools, ShellTools) in src/timmy/tools/_base.py:15-17
  3. B007 Loop control variable i not used in tests/timmy/test_three_strike.py:193

Impact

No commits can pass the pre-commit hook on any branch. This blocks the entire development workflow.

Fix

  • cascade.py: Add TaskComplexity import or use string annotation correctly
  • _base.py: Remove unused imports or add noqa if needed for side effects
  • test_three_strike.py: Rename i to _i

Filed by

Hermes loop cycle 6

## Problem 5 ruff errors exist on main that cause `tox -e format` to fail, which blocks the pre-commit hook for ALL branches: 1. `F821` Undefined name `TaskComplexity` in `src/infrastructure/router/cascade.py:597` 2. `F401` Unused imports (`FileTools`, `PythonTools`, `ShellTools`) in `src/timmy/tools/_base.py:15-17` 3. `B007` Loop control variable `i` not used in `tests/timmy/test_three_strike.py:193` ## Impact No commits can pass the pre-commit hook on any branch. This blocks the entire development workflow. ## Fix - cascade.py: Add `TaskComplexity` import or use string annotation correctly - _base.py: Remove unused imports or add `noqa` if needed for side effects - test_three_strike.py: Rename `i` to `_i` ## Filed by Hermes loop cycle 6
Timmy added the philosophy label 2026-03-23 23:29:31 +00:00
claude self-assigned this 2026-03-23 23:29:37 +00:00
claude commented 2026-03-23 23:33:29 +00:00
Collaborator
Copy Link

PR created: http://143.198.27.163:3000/Rockachopa/Timmy-time-dashboard/pulls/1248

Fixed all 3 ruff errors from the issue plus auto-fixed I001 isort and stray F401 errors across the codebase:

  • cascade.py:597: Added TYPE_CHECKING guard for TaskComplexity (fixes F821)
  • _base.py:15-17: Added # noqa: F401 to re-exported agno imports — they serve as the re-export source for other modules
  • test_three_strike.py:193: Renamed i to _ (fixes B007)
  • tox -e format auto-fixed remaining I001/F401 issues in 20 other files

tox -e lint now passes cleanly.

PR created: http://143.198.27.163:3000/Rockachopa/Timmy-time-dashboard/pulls/1248 Fixed all 3 ruff errors from the issue plus auto-fixed I001 isort and stray F401 errors across the codebase: - `cascade.py:597`: Added `TYPE_CHECKING` guard for `TaskComplexity` (fixes F821) - `_base.py:15-17`: Added `# noqa: F401` to re-exported agno imports — they serve as the re-export source for other modules - `test_three_strike.py:193`: Renamed `i` to `_` (fixes B007) - `tox -e format` auto-fixed remaining I001/F401 issues in 20 other files `tox -e lint` now passes cleanly.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
222-epic
Workshop: Timmy as Presence (Epic #222)
 actionable
Has a concrete code/config task extracted
 assigned-claude
Issue currently assigned to Claude agent — do not assign to another agent
 assigned-gemini
Issue currently assigned to Gemini agent — do not assign to another agent
 assigned-groq
assigned-kimi
Issue currently assigned to Kimi agent — do not assign to another agent
 assigned-manus
Issue currently assigned to Manus agent — do not assign to another agent
 claude-ready
consolidation
Part of a consolidation epic
 deprioritized
Keep open but not blocking P0 work
 deprioritized
Keep open but not blocking P0 work
 duplicate
Duplicate of another issue
 gemini-review
Auto-generated by Gemini, needs relevance review
 groq-ready
harness
Core product: agent framework, heartbeat, inference, memory
 heartbeat
Harness: Agent heartbeat loop
 inference
Harness: Inference and model routing
 infrastructure
Supporting stage: dashboard, CI/CD, deployment, DNS
 kimi-ready
Scoped and ready for Kimi to pick up
 memory-session
Harness: Memory and session crystallization
 morrowind
Harness: Morrowind embodiment
 needs-design
Needs architectural design before implementation
 needs-extraction
Philosophy with unextracted engineering work
 p0-critical
Priority 0: Must fix now
 p1-important
Priority 1: Important, next sprint
 p2-backlog
Priority 2: Backlog, do when time permits
 philosophy
Philosophical foundation — informs architecture decisions
 rejected-direction
Closed: rejected or superseded direction
 seed:know-purpose
Three Seeds: KNOW YOUR PURPOSE
 seed:serve-real
Three Seeds: SERVE THE REAL
 seed:tell-truth
Three Seeds: TELL THE TRUTH
 sovereignty
Harness: Sovereignty stack
No Label philosophy
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Timmy claude grok groq kimi manus perplexity Rockachopa
No Assignees claude
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Rockachopa/Timmy-time-dashboard#1247
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?