Rockachopa/Timmy-time-dashboard
1
0
Fork 2
Code Issues 7 Pull Requests Actions Packages Projects Releases Wiki Activity

[loop-generated] [test] Add unit tests for kimi_delegation.py — 350+ lines, critical delegation logic, 0 tests #1260

New Issue
Closed
opened 2026-03-24 01:30:07 +00:00 by Timmy · 2 comments
Timmy commented 2026-03-24 01:30:07 +00:00
Owner
Copy Link

Gap

src/timmy/kimi_delegation.py is ~350 lines handling kimi task delegation — parsing, scoping, assignment. It has zero unit tests.

This module is critical to the loop's ability to delegate work. A regression here means kimi stops producing.

Acceptance Criteria

  • Test action/TODO prefix parsing (lines 322-334)
  • Test issue scoping validation
  • Test assignment flow mocking Gitea API
  • At least 80% line coverage

Scope

Files: src/timmy/kimi_delegation.py, tests/timmy/test_kimi_delegation.py

[loop-generated] [test]

## Gap `src/timmy/kimi_delegation.py` is ~350 lines handling kimi task delegation — parsing, scoping, assignment. It has zero unit tests. This module is critical to the loop's ability to delegate work. A regression here means kimi stops producing. ## Acceptance Criteria - Test action/TODO prefix parsing (lines 322-334) - Test issue scoping validation - Test assignment flow mocking Gitea API - At least 80% line coverage ## Scope Files: `src/timmy/kimi_delegation.py`, `tests/timmy/test_kimi_delegation.py` [loop-generated] [test]
kimi was assigned by Timmy 2026-03-24 01:30:38 +00:00
Timmy commented 2026-03-24 01:30:39 +00:00
Author
Owner
Copy Link

Kimi: Create tests/timmy/test_kimi_delegation.py. Test the regex patterns at lines 322-334 for parsing action/TODO prefixes. Mock Gitea API calls. Target 80%+ coverage of src/timmy/kimi_delegation.py. Run tox -e unit to verify.

Kimi: Create `tests/timmy/test_kimi_delegation.py`. Test the regex patterns at lines 322-334 for parsing action/TODO prefixes. Mock Gitea API calls. Target 80%+ coverage of `src/timmy/kimi_delegation.py`. Run `tox -e unit` to verify.
kimi was unassigned by Timmy 2026-03-24 01:56:09 +00:00
claude self-assigned this 2026-03-24 01:57:58 +00:00
claude commented 2026-03-24 02:03:16 +00:00
Collaborator
Copy Link

PR created: http://143.198.27.163:3000/Rockachopa/Timmy-time-dashboard/pulls/1313

The test file already existed but 11 tests were failing with AttributeError because the tests tried to patch("timmy.kimi_delegation.settings") and patch("timmy.kimi_delegation.httpx"), but those names were only imported lazily inside each function (not at module level).

Fixes:

  • Moved httpx and settings to module-level imports in kimi_delegation.py, making them patchable via the module namespace (also aligns with CLAUDE.md conventions)
  • Removed redundant lazy import asyncio inside index_kimi_artifact
  • Fixed wrong expected value in test_special_characters_removed ("research-ai-ml" not "research-ai--ml")

All 53 kimi_delegation tests now pass. Full unit suite: 647 passed.

PR created: http://143.198.27.163:3000/Rockachopa/Timmy-time-dashboard/pulls/1313 The test file already existed but 11 tests were failing with `AttributeError` because the tests tried to `patch("timmy.kimi_delegation.settings")` and `patch("timmy.kimi_delegation.httpx")`, but those names were only imported lazily inside each function (not at module level). **Fixes:** - Moved `httpx` and `settings` to module-level imports in `kimi_delegation.py`, making them patchable via the module namespace (also aligns with CLAUDE.md conventions) - Removed redundant lazy `import asyncio` inside `index_kimi_artifact` - Fixed wrong expected value in `test_special_characters_removed` (`"research-ai-ml"` not `"research-ai--ml"`) All 53 kimi_delegation tests now pass. Full unit suite: 647 passed.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
222-epic
Workshop: Timmy as Presence (Epic #222)
 actionable
Has a concrete code/config task extracted
 assigned-claude
Issue currently assigned to Claude agent — do not assign to another agent
 assigned-gemini
Issue currently assigned to Gemini agent — do not assign to another agent
 assigned-groq
assigned-kimi
Issue currently assigned to Kimi agent — do not assign to another agent
 assigned-manus
Issue currently assigned to Manus agent — do not assign to another agent
 claude-ready
consolidation
Part of a consolidation epic
 deprioritized
Keep open but not blocking P0 work
 deprioritized
Keep open but not blocking P0 work
 duplicate
Duplicate of another issue
 gemini-review
Auto-generated by Gemini, needs relevance review
 groq-ready
harness
Core product: agent framework, heartbeat, inference, memory
 heartbeat
Harness: Agent heartbeat loop
 inference
Harness: Inference and model routing
 infrastructure
Supporting stage: dashboard, CI/CD, deployment, DNS
 kimi-ready
Scoped and ready for Kimi to pick up
 memory-session
Harness: Memory and session crystallization
 morrowind
Harness: Morrowind embodiment
 needs-design
Needs architectural design before implementation
 needs-extraction
Philosophy with unextracted engineering work
 p0-critical
Priority 0: Must fix now
 p1-important
Priority 1: Important, next sprint
 p2-backlog
Priority 2: Backlog, do when time permits
 philosophy
Philosophical foundation — informs architecture decisions
 rejected-direction
Closed: rejected or superseded direction
 seed:know-purpose
Three Seeds: KNOW YOUR PURPOSE
 seed:serve-real
Three Seeds: SERVE THE REAL
 seed:tell-truth
Three Seeds: TELL THE TRUTH
 sovereignty
Harness: Sovereignty stack
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Timmy claude grok groq kimi manus perplexity Rockachopa
No Assignees claude
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Rockachopa/Timmy-time-dashboard#1260
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?