[loop-generated] [bug] Kimi produces empty commits — git add not called before commit #1268
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Bug
Multiple Kimi PRs have been closed because the branch has commits with 0 file changes.
Evidence
Root Cause
Kimi's workflow likely runs
git commit -m ...without first runninggit add .orgit add <files>. The commit succeeds (empty commit) and the PR is created, but there's no actual diff.Fix
The kimi-loop.sh or kimi's instructions need to ensure:
git add .or explicit file staging before commitgit diff --cached --statis non-empty before committingImpact
Wasted review cycles. Issues stay open but appear worked on.
PR #1288 created: http://143.198.27.163:3000/Rockachopa/Timmy-time-dashboard/pulls/1288
Root cause:
build_prompt()inkimi-loop.shsaid "COMMIT" but never said "git add first".Fixes applied:
.kimi/AGENTS.md— Added CRITICAL rule requiringgit add .+git diff --cached --statcheck before any commitkimi-loop.shharness (applied to~/.hermes/bin/andhermes-config/):git add .+ diff check before the commit command/filesAPI — rejects PRs with 0 changed files, closes them, comments explaining the problem, and adds issue to skip list for 2h retryThree layers of defense now prevent empty PRs from merging.