Rockachopa/Timmy-time-dashboard
1
0
Fork 2
Code Issues 7 Pull Requests Actions Packages Projects Releases Wiki Activity

[loop-generated] [refactor] Split memory_system.py — 1543 lines, extract subsystems #1277

New Issue
Closed
opened 2026-03-24 01:43:22 +00:00 by Timmy · 1 comment
Timmy commented 2026-03-24 01:43:22 +00:00
Owner
Copy Link

Problem

src/timmy/memory_system.py is 1543 lines — the largest module in the codebase. This makes it hard to test, review, and modify safely.

Proposed Split

  1. Extract chain memory operations into src/timmy/memory/chain.py
  2. Extract semantic search into src/timmy/memory/semantic.py
  3. Extract memory consolidation into src/timmy/memory/consolidation.py
  4. Keep memory_system.py as thin orchestrator importing from submodules

Acceptance Criteria

  • No module exceeds 400 lines after split
  • All existing tests still pass (tox -e unit)
  • No new dependencies introduced
  • Imports from other modules unchanged (re-export from memory_system.py)

Files

  • src/timmy/memory_system.py (primary)
  • src/timmy/memory/ (new package)

Lines of code is a liability. Delete as much as you create.

## Problem `src/timmy/memory_system.py` is 1543 lines — the largest module in the codebase. This makes it hard to test, review, and modify safely. ## Proposed Split 1. Extract chain memory operations into `src/timmy/memory/chain.py` 2. Extract semantic search into `src/timmy/memory/semantic.py` 3. Extract memory consolidation into `src/timmy/memory/consolidation.py` 4. Keep `memory_system.py` as thin orchestrator importing from submodules ## Acceptance Criteria - [ ] No module exceeds 400 lines after split - [ ] All existing tests still pass (`tox -e unit`) - [ ] No new dependencies introduced - [ ] Imports from other modules unchanged (re-export from `memory_system.py`) ## Files - `src/timmy/memory_system.py` (primary) - `src/timmy/memory/` (new package) Lines of code is a liability. Delete as much as you create.
claude was assigned by Timmy 2026-03-24 01:46:44 +00:00
claude was unassigned by Timmy 2026-03-24 01:56:11 +00:00
claude was assigned by Timmy 2026-03-24 01:59:28 +00:00
Timmy closed this issue 2026-03-24 02:21:44 +00:00
Timmy commented 2026-03-24 02:34:35 +00:00
Author
Owner
Copy Link

Closing — this refactor is already complete on main.

  • memory_system.py is 178 lines (thin orchestrator) ✓
  • src/timmy/memory/semantic.py — 300 lines ✓
  • src/timmy/memory/consolidation.py — 301 lines ✓
  • src/timmy/memory/ package has 8 modules (crud, db, embeddings, tools, unified, vector_store) ✓
  • No module exceeds 400 lines ✓

All acceptance criteria met. The split was done in a previous cycle.

Closing — this refactor is already complete on main. - `memory_system.py` is 178 lines (thin orchestrator) ✓ - `src/timmy/memory/semantic.py` — 300 lines ✓ - `src/timmy/memory/consolidation.py` — 301 lines ✓ - `src/timmy/memory/` package has 8 modules (crud, db, embeddings, tools, unified, vector_store) ✓ - No module exceeds 400 lines ✓ All acceptance criteria met. The split was done in a previous cycle.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
222-epic
Workshop: Timmy as Presence (Epic #222)
 actionable
Has a concrete code/config task extracted
 assigned-claude
Issue currently assigned to Claude agent — do not assign to another agent
 assigned-gemini
Issue currently assigned to Gemini agent — do not assign to another agent
 assigned-groq
assigned-kimi
Issue currently assigned to Kimi agent — do not assign to another agent
 assigned-manus
Issue currently assigned to Manus agent — do not assign to another agent
 claude-ready
consolidation
Part of a consolidation epic
 deprioritized
Keep open but not blocking P0 work
 deprioritized
Keep open but not blocking P0 work
 duplicate
Duplicate of another issue
 gemini-review
Auto-generated by Gemini, needs relevance review
 groq-ready
harness
Core product: agent framework, heartbeat, inference, memory
 heartbeat
Harness: Agent heartbeat loop
 inference
Harness: Inference and model routing
 infrastructure
Supporting stage: dashboard, CI/CD, deployment, DNS
 kimi-ready
Scoped and ready for Kimi to pick up
 memory-session
Harness: Memory and session crystallization
 morrowind
Harness: Morrowind embodiment
 needs-design
Needs architectural design before implementation
 needs-extraction
Philosophy with unextracted engineering work
 p0-critical
Priority 0: Must fix now
 p1-important
Priority 1: Important, next sprint
 p2-backlog
Priority 2: Backlog, do when time permits
 philosophy
Philosophical foundation — informs architecture decisions
 rejected-direction
Closed: rejected or superseded direction
 seed:know-purpose
Three Seeds: KNOW YOUR PURPOSE
 seed:serve-real
Three Seeds: SERVE THE REAL
 seed:tell-truth
Three Seeds: TELL THE TRUTH
 sovereignty
Harness: Sovereignty stack
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Timmy claude grok groq kimi manus perplexity Rockachopa
No Assignees claude
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Rockachopa/Timmy-time-dashboard#1277
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?