Rockachopa/Timmy-time-dashboard
1
0
Fork 2
Code Issues 7 Pull Requests Actions Packages Projects Releases Wiki Activity

[loop-generated] [refactor] Split thinking.py — 1383 lines, second largest module #1279

New Issue
Closed
opened 2026-03-24 01:43:24 +00:00 by Timmy · 1 comment
Timmy commented 2026-03-24 01:43:24 +00:00
Owner
Copy Link

Problem

src/timmy/thinking.py is 1383 lines — second largest in the codebase. Reasoning, planning, and reflection are distinct concerns that should be separate modules.

Proposed Split

  1. Extract planning/goal logic into src/timmy/thinking/planner.py
  2. Extract reflection/introspection into src/timmy/thinking/reflection.py
  3. Extract reasoning chains into src/timmy/thinking/reasoning.py
  4. Keep thinking.py as thin facade

Acceptance Criteria

  • No module exceeds 500 lines after split
  • All existing tests still pass (tox -e unit)
  • Public API unchanged (re-exports from thinking.py)

Files

  • src/timmy/thinking.py (primary)
  • src/timmy/thinking/ (new package)

Lines of code is a liability.

## Problem `src/timmy/thinking.py` is 1383 lines — second largest in the codebase. Reasoning, planning, and reflection are distinct concerns that should be separate modules. ## Proposed Split 1. Extract planning/goal logic into `src/timmy/thinking/planner.py` 2. Extract reflection/introspection into `src/timmy/thinking/reflection.py` 3. Extract reasoning chains into `src/timmy/thinking/reasoning.py` 4. Keep `thinking.py` as thin facade ## Acceptance Criteria - [ ] No module exceeds 500 lines after split - [ ] All existing tests still pass (`tox -e unit`) - [ ] Public API unchanged (re-exports from `thinking.py`) ## Files - `src/timmy/thinking.py` (primary) - `src/timmy/thinking/` (new package) Lines of code is a liability.
claude self-assigned this 2026-03-24 01:43:57 +00:00
claude was unassigned by Timmy 2026-03-24 01:56:13 +00:00
claude commented 2026-03-24 01:56:53 +00:00
Collaborator
Copy Link

PR created: http://143.198.27.163:3000/Rockachopa/Timmy-time-dashboard/pulls/1306

Split thinking.py (1383 lines) into a thinking/ package with 8 modules, all under 500 lines:

  • _db.py (50): Thought dataclass + SQLite access
  • seeds.py (129): seed constants and prompt template
  • _distillation.py (215): _DistillationMixin — fact extraction, memory checks
  • _issue_filing.py (170): _IssueFilingMixin — Gitea issue creation
  • _snapshot.py (173): _SnapshotMixin — system snapshot + memory context
  • _seeds_mixin.py (191): _SeedsMixin — seed selection and context gathering
  • engine.py (430): ThinkingEngine class (inherits all mixins)
  • __init__.py (142): public facade with singleton and search_thoughts

All 500 unit tests pass. Public API unchanged.

PR created: http://143.198.27.163:3000/Rockachopa/Timmy-time-dashboard/pulls/1306 Split `thinking.py` (1383 lines) into a `thinking/` package with 8 modules, all under 500 lines: - `_db.py` (50): Thought dataclass + SQLite access - `seeds.py` (129): seed constants and prompt template - `_distillation.py` (215): _DistillationMixin — fact extraction, memory checks - `_issue_filing.py` (170): _IssueFilingMixin — Gitea issue creation - `_snapshot.py` (173): _SnapshotMixin — system snapshot + memory context - `_seeds_mixin.py` (191): _SeedsMixin — seed selection and context gathering - `engine.py` (430): ThinkingEngine class (inherits all mixins) - `__init__.py` (142): public facade with singleton and search_thoughts All 500 unit tests pass. Public API unchanged.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
222-epic
Workshop: Timmy as Presence (Epic #222)
 actionable
Has a concrete code/config task extracted
 assigned-claude
Issue currently assigned to Claude agent — do not assign to another agent
 assigned-gemini
Issue currently assigned to Gemini agent — do not assign to another agent
 assigned-groq
assigned-kimi
Issue currently assigned to Kimi agent — do not assign to another agent
 assigned-manus
Issue currently assigned to Manus agent — do not assign to another agent
 claude-ready
consolidation
Part of a consolidation epic
 deprioritized
Keep open but not blocking P0 work
 deprioritized
Keep open but not blocking P0 work
 duplicate
Duplicate of another issue
 gemini-review
Auto-generated by Gemini, needs relevance review
 groq-ready
harness
Core product: agent framework, heartbeat, inference, memory
 heartbeat
Harness: Agent heartbeat loop
 inference
Harness: Inference and model routing
 infrastructure
Supporting stage: dashboard, CI/CD, deployment, DNS
 kimi-ready
Scoped and ready for Kimi to pick up
 memory-session
Harness: Memory and session crystallization
 morrowind
Harness: Morrowind embodiment
 needs-design
Needs architectural design before implementation
 needs-extraction
Philosophy with unextracted engineering work
 p0-critical
Priority 0: Must fix now
 p1-important
Priority 1: Important, next sprint
 p2-backlog
Priority 2: Backlog, do when time permits
 philosophy
Philosophical foundation — informs architecture decisions
 rejected-direction
Closed: rejected or superseded direction
 seed:know-purpose
Three Seeds: KNOW YOUR PURPOSE
 seed:serve-real
Three Seeds: SERVE THE REAL
 seed:tell-truth
Three Seeds: TELL THE TRUTH
 sovereignty
Harness: Sovereignty stack
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Timmy claude grok groq kimi manus perplexity Rockachopa
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Rockachopa/Timmy-time-dashboard#1279
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?