Rockachopa/Timmy-time-dashboard
1
0
Fork 2
Code Issues 7 Pull Requests Actions Packages Projects Releases Wiki Activity

chore: enforce "Normal Developer" discipline — tighten lint, type-check, and pre-push gates #1285

New Issue
Closed
opened 2026-03-24 01:44:36 +00:00 by claude · 0 comments
claude commented 2026-03-24 01:44:36 +00:00
Collaborator
Copy Link

Context

From screenshot triage (issue #1275) — visual inspiration from the "Vibe Coder vs Normal Developer" meme.

The meme contrasts two approaches:

Vibe Coder Normal Developer
Copy-paste, ChatGPT, trial-and-error Plan → Code → Test → Deploy
npm everything, 50 plugins Understand fundamentals
BRO TRUST ME Write clean code
Constant errors Think before building
Use right tools, Scale & Maintain

Applied to this project: we have the infrastructure for disciplined development (tox, mypy, bandit, black, isort, coverage gates), but some of these gates are not enforced consistently.

Tasks

  • mypy coverage — run tox -e typecheck in CI and fix all current mypy errors
  • bandit — ensure all bandit findings are resolved or suppressed with justification (no blanket # noqa)
  • Coverage gate — raise the fail_under threshold from 73% to 80% incrementally as new tests are added
  • Pre-push hook — add a git pre-push hook (via tox or Makefile) that runs tox -e pre-push automatically so agents and developers can’t push broken code
  • Dead code — run vulture or similar to identify unreachable code
  • Update CLAUDE.md to reference the 80% coverage target once it is set

Acceptance Criteria

  • tox -e typecheck exits 0 in CI
  • Coverage threshold raised to 80%
  • Pre-push hook documented in CLAUDE.md under “Development Environments”
  • tox -e ci passes
## Context From screenshot triage (issue #1275) — visual inspiration from the "Vibe Coder vs Normal Developer" meme. The meme contrasts two approaches: | Vibe Coder | Normal Developer | |---|---| | Copy-paste, ChatGPT, trial-and-error | Plan → Code → Test → Deploy | | `npm everything`, 50 plugins | Understand fundamentals | | `BRO TRUST ME` | Write clean code | | Constant errors | Think before building | | | Use right tools, Scale & Maintain | Applied to this project: we have the infrastructure for disciplined development (tox, mypy, bandit, black, isort, coverage gates), but some of these gates are not enforced consistently. ## Tasks - [ ] **mypy coverage** — run `tox -e typecheck` in CI and fix all current mypy errors - [ ] **bandit** — ensure all bandit findings are resolved or suppressed with justification (no blanket `# noqa`) - [ ] **Coverage gate** — raise the `fail_under` threshold from 73% to 80% incrementally as new tests are added - [ ] **Pre-push hook** — add a git pre-push hook (via tox or Makefile) that runs `tox -e pre-push` automatically so agents and developers can’t push broken code - [ ] **Dead code** — run `vulture` or similar to identify unreachable code - [ ] Update CLAUDE.md to reference the 80% coverage target once it is set ## Acceptance Criteria - `tox -e typecheck` exits 0 in CI - Coverage threshold raised to 80% - Pre-push hook documented in CLAUDE.md under “Development Environments” - `tox -e ci` passes
claude was assigned by Timmy 2026-03-24 01:46:44 +00:00
claude was unassigned by Timmy 2026-03-24 01:56:17 +00:00
claude was assigned by Timmy 2026-03-24 01:59:27 +00:00
claude was unassigned by Timmy 2026-03-24 19:33:41 +00:00
Timmy closed this issue 2026-03-24 21:54:37 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
222-epic
Workshop: Timmy as Presence (Epic #222)
 actionable
Has a concrete code/config task extracted
 assigned-claude
Issue currently assigned to Claude agent — do not assign to another agent
 assigned-gemini
Issue currently assigned to Gemini agent — do not assign to another agent
 assigned-groq
assigned-kimi
Issue currently assigned to Kimi agent — do not assign to another agent
 assigned-manus
Issue currently assigned to Manus agent — do not assign to another agent
 claude-ready
consolidation
Part of a consolidation epic
 deprioritized
Keep open but not blocking P0 work
 deprioritized
Keep open but not blocking P0 work
 duplicate
Duplicate of another issue
 gemini-review
Auto-generated by Gemini, needs relevance review
 groq-ready
harness
Core product: agent framework, heartbeat, inference, memory
 heartbeat
Harness: Agent heartbeat loop
 inference
Harness: Inference and model routing
 infrastructure
Supporting stage: dashboard, CI/CD, deployment, DNS
 kimi-ready
Scoped and ready for Kimi to pick up
 memory-session
Harness: Memory and session crystallization
 morrowind
Harness: Morrowind embodiment
 needs-design
Needs architectural design before implementation
 needs-extraction
Philosophy with unextracted engineering work
 p0-critical
Priority 0: Must fix now
 p1-important
Priority 1: Important, next sprint
 p2-backlog
Priority 2: Backlog, do when time permits
 philosophy
Philosophical foundation — informs architecture decisions
 rejected-direction
Closed: rejected or superseded direction
 seed:know-purpose
Three Seeds: KNOW YOUR PURPOSE
 seed:serve-real
Three Seeds: SERVE THE REAL
 seed:tell-truth
Three Seeds: TELL THE TRUTH
 sovereignty
Harness: Sovereignty stack
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Timmy claude grok groq kimi manus perplexity Rockachopa
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Rockachopa/Timmy-time-dashboard#1285
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?