[claude] Add unit tests for orchestration_loop.py (#1278) #1311

claude · 2026-03-24T02:01:13Z

claude commented

2026-03-24 02:01:13 +00:00

Fixes #1278

Creates tests/timmy/test_orchestration_loop.py with 25+ test cases covering:

VassalCycleRecord: defaults, healthy property, dispatch counters
VassalOrchestrator properties: initial state, get_status, history copy safety
_resolve_interval: explicit value, settings fallback, exception fallback
run_cycle: cycle count increment, record appended to history, broadcast called
_step_backlog: empty backlog early return, exception → errors, max dispatch cap, already-dispatched skip
_step_agent_health: stuck agents recorded, nudges counted, exception → errors
_step_house_health: warnings recorded, cleanup triggered at 80% disk, exception → errors
_broadcast: successful payload, import error swallowed
start/stop: running state transitions, double-start no-op

All external deps (Gitea, LLM, ws_manager, config) are mocked. tox -e unit passes (647 tests).

Fixes #1278 Creates `tests/timmy/test_orchestration_loop.py` with 25+ test cases covering: - `VassalCycleRecord`: defaults, `healthy` property, dispatch counters - `VassalOrchestrator` properties: initial state, `get_status`, history copy safety - `_resolve_interval`: explicit value, settings fallback, exception fallback - `run_cycle`: cycle count increment, record appended to history, broadcast called - `_step_backlog`: empty backlog early return, exception → errors, max dispatch cap, already-dispatched skip - `_step_agent_health`: stuck agents recorded, nudges counted, exception → errors - `_step_house_health`: warnings recorded, cleanup triggered at 80% disk, exception → errors - `_broadcast`: successful payload, import error swallowed - `start`/`stop`: running state transitions, double-start no-op All external deps (Gitea, LLM, ws_manager, config) are mocked. `tox -e unit` passes (647 tests).

claude added 1 commit 2026-03-24 02:01:14 +00:00

test: add unit tests for vassal orchestration_loop.py

Tests / lint (pull_request) Failing after 40s

Details

Tests / test (pull_request) Has been skipped

Details

c2708c4fcd

Covers VassalCycleRecord, VassalOrchestrator properties, run_cycle,
_step_backlog, _step_agent_health, _step_house_health, _broadcast,
start/stop — 5+ test classes with 25+ cases. All external deps mocked.

Fixes #1278

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

claude referenced this pull request

2026-03-24 02:01:21 +00:00

[loop-generated] [test] Add unit tests for orchestration_loop.py — untested core module #1278

claude merged commit 24f4fd9188 into main

2026-03-24 02:01:31 +00:00

claude deleted branch claude/issue-1278

2026-03-24 02:01:32 +00:00

claude referenced this issue from a commit

2026-03-24 02:01:33 +00:00

[claude] Add unit tests for orchestration_loop.py (#1278) (#1311)

Sign in to join this conversation.