Rockachopa/Timmy-time-dashboard
1
0
Fork 2
Code Issues 7 Pull Requests Actions Packages Projects Releases Wiki Activity

[claude] Add unit tests for tools/system_tools.py (#1345) #1354

Merged
claude merged 1 commits from claude/issue-1345 into main 2026-03-24 02:56:35 +00:00
Conversation 0 Commits 1 Files Changed 1 +617
claude commented 2026-03-24 02:56:14 +00:00
Collaborator
Copy Link

Fixes #1345

Creates tests/timmy/test_system_tools.py with 67 unit tests covering all core functions in src/timmy/tools/system_tools.py:

  • _safe_eval: constants, arithmetic ops, math functions/attributes, injection prevention (strings, unknown names, unsupported ops/syntax)
  • calculator: basic operations, error handling, injection prevention
  • consult_grok: unavailable path, free mode, spark logging failures, paid mode lightning failures
  • web_fetch: URL validation, missing packages, truncation, HTTP errors, timeout, request exceptions
  • AiderTool: success/failure/timeout/os-error paths, model/flag/cwd arg validation
  • Toolkit factories (create_code_tools, create_security_tools, create_devops_tools): ImportError paths and happy paths

All tests pass tox -e unit (821 passed, 3 skipped).

Fixes #1345 Creates `tests/timmy/test_system_tools.py` with 67 unit tests covering all core functions in `src/timmy/tools/system_tools.py`: - **`_safe_eval`**: constants, arithmetic ops, math functions/attributes, injection prevention (strings, unknown names, unsupported ops/syntax) - **`calculator`**: basic operations, error handling, injection prevention - **`consult_grok`**: unavailable path, free mode, spark logging failures, paid mode lightning failures - **`web_fetch`**: URL validation, missing packages, truncation, HTTP errors, timeout, request exceptions - **`AiderTool`**: success/failure/timeout/os-error paths, model/flag/cwd arg validation - **Toolkit factories** (`create_code_tools`, `create_security_tools`, `create_devops_tools`): ImportError paths and happy paths All tests pass `tox -e unit` (821 passed, 3 skipped).
claude added 1 commit 2026-03-24 02:56:15 +00:00
test: add unit tests for tools/system_tools.py
Some checks failed
Tests / lint (pull_request) Failing after 31s
Details
Tests / test (pull_request) Has been skipped
Details
5251dda8e7 
Creates tests/timmy/test_system_tools.py with 67 tests covering:
- _safe_eval: constants, arithmetic ops, math functions, injection
  prevention, unsupported syntax
- calculator: basic operations, error handling, injection prevention
- consult_grok: unavailable path, free mode, spark logging failures,
  paid mode lightning failures
- web_fetch: URL validation, missing packages, truncation, HTTP errors,
  timeout, request exceptions
- AiderTool: success/failure/timeout/os-error paths, model/flag/cwd
  args validation
- toolkit factories: ImportError paths and happy paths for code/security/devops

Fixes #1345

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
claude merged commit 36f3f1b3a7 into main 2026-03-24 02:56:35 +00:00
claude deleted branch claude/issue-1345 2026-03-24 02:56:36 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
222-epic
Workshop: Timmy as Presence (Epic #222)
 actionable
Has a concrete code/config task extracted
 assigned-claude
Issue currently assigned to Claude agent — do not assign to another agent
 assigned-gemini
Issue currently assigned to Gemini agent — do not assign to another agent
 assigned-groq
assigned-kimi
Issue currently assigned to Kimi agent — do not assign to another agent
 assigned-manus
Issue currently assigned to Manus agent — do not assign to another agent
 claude-ready
consolidation
Part of a consolidation epic
 deprioritized
Keep open but not blocking P0 work
 deprioritized
Keep open but not blocking P0 work
 duplicate
Duplicate of another issue
 gemini-review
Auto-generated by Gemini, needs relevance review
 groq-ready
harness
Core product: agent framework, heartbeat, inference, memory
 heartbeat
Harness: Agent heartbeat loop
 inference
Harness: Inference and model routing
 infrastructure
Supporting stage: dashboard, CI/CD, deployment, DNS
 kimi-ready
Scoped and ready for Kimi to pick up
 memory-session
Harness: Memory and session crystallization
 morrowind
Harness: Morrowind embodiment
 needs-design
Needs architectural design before implementation
 needs-extraction
Philosophy with unextracted engineering work
 p0-critical
Priority 0: Must fix now
 p1-important
Priority 1: Important, next sprint
 p2-backlog
Priority 2: Backlog, do when time permits
 philosophy
Philosophical foundation — informs architecture decisions
 rejected-direction
Closed: rejected or superseded direction
 seed:know-purpose
Three Seeds: KNOW YOUR PURPOSE
 seed:serve-real
Three Seeds: SERVE THE REAL
 seed:tell-truth
Three Seeds: TELL THE TRUTH
 sovereignty
Harness: Sovereignty stack
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Timmy claude grok groq kimi manus perplexity Rockachopa
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Rockachopa/Timmy-time-dashboard#1354
Delete Branch "claude/issue-1345"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?