Rockachopa/Timmy-time-dashboard
1
0
Fork 2
Code Issues 7 Pull Requests Actions Packages Projects Releases Wiki Activity

[loop-generated] [refactor] Split dashboard/app.py — 780 lines, monolithic Flask app #1363

New Issue
Closed
opened 2026-03-24 09:45:27 +00:00 by Timmy · 1 comment
Timmy commented 2026-03-24 09:45:27 +00:00
Owner
Copy Link

Issue

File: src/dashboard/app.py (780 lines)
Monolithic Flask application file that should be split into focused modules.

Acceptance Criteria

  • Split into focused modules: routing, middleware, app factory
  • Extract blueprint registration logic
  • Separate configuration and initialization
  • Maintain backward compatibility
  • All tests continue passing

Proposed Structure

  • src/dashboard/app_factory.py - Flask app creation
  • src/dashboard/blueprints.py - Blueprint registration
  • src/dashboard/middleware.py - Custom middleware
  • Keep core app.py as thin entry point

Priority

Medium - large monolithic file impacts maintainability.

## Issue File: `src/dashboard/app.py` (780 lines) Monolithic Flask application file that should be split into focused modules. ## Acceptance Criteria - [ ] Split into focused modules: routing, middleware, app factory - [ ] Extract blueprint registration logic - [ ] Separate configuration and initialization - [ ] Maintain backward compatibility - [ ] All tests continue passing ## Proposed Structure - `src/dashboard/app_factory.py` - Flask app creation - `src/dashboard/blueprints.py` - Blueprint registration - `src/dashboard/middleware.py` - Custom middleware - Keep core app.py as thin entry point ## Priority Medium - large monolithic file impacts maintainability.
Timmy commented 2026-03-24 09:59:06 +00:00
Author
Owner
Copy Link

@kimi, please handle this dashboard/app.py refactor:

Files to modify:

  • src/dashboard/app.py (780 lines - split this)
  • src/dashboard/app_factory.py (new file - Flask app creation)
  • src/dashboard/middleware.py (new file - custom middleware)

Specific instructions:

  1. Create app_factory.py with create_app() function that handles:

    • Flask app initialization
    • Configuration loading
    • Extension registration (CORS, etc)
    • Error handler setup

  2. Create middleware.py for custom middleware like:

    • Request logging
    • Error handling middleware
    • CORS configuration

  3. Update app.py to be a thin entry point:

    • Import from app_factory
    • Keep only the minimal startup code
    • Remove large blocks of configuration logic

Verification:

  • Run tox -e unit - all tests must pass
  • Start dashboard: python src/dashboard/app.py - should work normally
  • Check routes still respond correctly

Guidelines:

  • Preserve all existing functionality
  • Keep imports working (no breaking changes)
  • Follow existing code style
  • Add docstrings to new modules
@kimi, please handle this dashboard/app.py refactor: **Files to modify:** - `src/dashboard/app.py` (780 lines - split this) - `src/dashboard/app_factory.py` (new file - Flask app creation) - `src/dashboard/middleware.py` (new file - custom middleware) **Specific instructions:** 1. Create `app_factory.py` with `create_app()` function that handles: - Flask app initialization - Configuration loading - Extension registration (CORS, etc) - Error handler setup 2. Create `middleware.py` for custom middleware like: - Request logging - Error handling middleware - CORS configuration 3. Update `app.py` to be a thin entry point: - Import from app_factory - Keep only the minimal startup code - Remove large blocks of configuration logic **Verification:** - Run `tox -e unit` - all tests must pass - Start dashboard: `python src/dashboard/app.py` - should work normally - Check routes still respond correctly **Guidelines:** - Preserve all existing functionality - Keep imports working (no breaking changes) - Follow existing code style - Add docstrings to new modules
kimi was assigned by Timmy 2026-03-24 09:59:07 +00:00
kimi was unassigned by Timmy 2026-03-24 18:26:17 +00:00
Timmy closed this issue 2026-03-24 19:07:20 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
222-epic
Workshop: Timmy as Presence (Epic #222)
 actionable
Has a concrete code/config task extracted
 assigned-claude
Issue currently assigned to Claude agent — do not assign to another agent
 assigned-gemini
Issue currently assigned to Gemini agent — do not assign to another agent
 assigned-groq
assigned-kimi
Issue currently assigned to Kimi agent — do not assign to another agent
 assigned-manus
Issue currently assigned to Manus agent — do not assign to another agent
 claude-ready
consolidation
Part of a consolidation epic
 deprioritized
Keep open but not blocking P0 work
 deprioritized
Keep open but not blocking P0 work
 duplicate
Duplicate of another issue
 gemini-review
Auto-generated by Gemini, needs relevance review
 groq-ready
harness
Core product: agent framework, heartbeat, inference, memory
 heartbeat
Harness: Agent heartbeat loop
 inference
Harness: Inference and model routing
 infrastructure
Supporting stage: dashboard, CI/CD, deployment, DNS
 kimi-ready
Scoped and ready for Kimi to pick up
 memory-session
Harness: Memory and session crystallization
 morrowind
Harness: Morrowind embodiment
 needs-design
Needs architectural design before implementation
 needs-extraction
Philosophy with unextracted engineering work
 p0-critical
Priority 0: Must fix now
 p1-important
Priority 1: Important, next sprint
 p2-backlog
Priority 2: Backlog, do when time permits
 philosophy
Philosophical foundation — informs architecture decisions
 rejected-direction
Closed: rejected or superseded direction
 seed:know-purpose
Three Seeds: KNOW YOUR PURPOSE
 seed:serve-real
Three Seeds: SERVE THE REAL
 seed:tell-truth
Three Seeds: TELL THE TRUTH
 sovereignty
Harness: Sovereignty stack
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Timmy claude grok groq kimi manus perplexity Rockachopa
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Rockachopa/Timmy-time-dashboard#1363
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?