Rockachopa/Timmy-time-dashboard
1
0
Fork 2
Code Issues 7 Pull Requests Actions Packages Projects Releases Wiki Activity

[loop-generated] [refactor] Split timmy/cli.py — 693 lines, monolithic CLI interface #1369

New Issue
Closed
opened 2026-03-24 10:08:39 +00:00 by Timmy · 2 comments
Timmy commented 2026-03-24 10:08:39 +00:00
Owner
Copy Link

Priority: High
Impact: Developer experience, CLI maintainability
Size: 693 lines

Problem

src/timmy/cli.py is a monolithic 693-line CLI interface that handles multiple responsibilities:

  • Chat interface
  • Think command
  • Status reporting
  • Session management
  • Tool safety checks

Proposed Split

src/timmy/cli/
├── __init__.py         # Main app entry point
├── chat.py            # Chat command implementation
├── think.py           # Think command implementation
├── status.py          # Status reporting
└── safety.py          # Tool safety checking

Acceptance Criteria

  • Split into 4-5 focused modules
  • Maintain exact same CLI interface
  • All existing tests pass
  • No import cycle issues
  • Clear separation of concerns

Files to Modify

  • src/timmy/cli.py → src/timmy/cli/__init__.py
  • Create new modules as outlined above
  • Update any imports in other files

Estimated effort: 2-3 hours

**Priority**: High **Impact**: Developer experience, CLI maintainability **Size**: 693 lines ## Problem `src/timmy/cli.py` is a monolithic 693-line CLI interface that handles multiple responsibilities: - Chat interface - Think command - Status reporting - Session management - Tool safety checks ## Proposed Split ``` src/timmy/cli/ ├── __init__.py # Main app entry point ├── chat.py # Chat command implementation ├── think.py # Think command implementation ├── status.py # Status reporting └── safety.py # Tool safety checking ``` ## Acceptance Criteria - [ ] Split into 4-5 focused modules - [ ] Maintain exact same CLI interface - [ ] All existing tests pass - [ ] No import cycle issues - [ ] Clear separation of concerns ## Files to Modify - `src/timmy/cli.py` → `src/timmy/cli/__init__.py` - Create new modules as outlined above - Update any imports in other files Estimated effort: 2-3 hours
Timmy commented 2026-03-24 10:21:45 +00:00
Author
Owner
Copy Link

Kimi Task Instructions

Files to work with:

  • src/timmy/cli.py (693 lines - split this)
  • Create new files:
    • src/timmy/cli/__init__.py
    • src/timmy/cli/chat.py (Chat interface, interactive commands)
    • src/timmy/cli/commands.py (Think, status, session management)
    • src/timmy/cli/safety.py (Tool safety checks, validation)
    • src/timmy/cli/interface.py (Main CLI entry point, argument parsing)

Refactor approach:

  1. Create cli/ package directory
  2. Extract chat-related functionality → chat.py
  3. Extract think/status/session commands → commands.py
  4. Extract tool safety logic → safety.py
  5. Keep main entry point and arg parsing in interface.py
  6. Update __init__.py to expose main entry point
  7. Update imports and entry points

Key functionality to preserve:

  • Main CLI entry point: timmy_cli() function
  • Chat interface with streaming responses
  • Think command with session management
  • Tool safety validation
  • Status reporting and diagnostics

Import compatibility:
Ensure these work after refactor:

from timmy.cli import timmy_cli
# Entry point in setup.py should still work

How to verify:

  1. tox -e unit - all tests pass
  2. tox -e lint - no import errors
  3. CLI commands still work: python -m timmy.cli chat
  4. Entry point works if defined

Split guidelines:

  • Each file 150-200 lines max
  • Keep related UI/UX together
  • Separate concerns: interface vs commands vs safety
  • Maintain clean command flow

This improves CLI maintainability and makes it easier to add new commands.

## Kimi Task Instructions **Files to work with:** - `src/timmy/cli.py` (693 lines - split this) - Create new files: - `src/timmy/cli/__init__.py` - `src/timmy/cli/chat.py` (Chat interface, interactive commands) - `src/timmy/cli/commands.py` (Think, status, session management) - `src/timmy/cli/safety.py` (Tool safety checks, validation) - `src/timmy/cli/interface.py` (Main CLI entry point, argument parsing) **Refactor approach:** 1. Create cli/ package directory 2. Extract chat-related functionality → `chat.py` 3. Extract think/status/session commands → `commands.py` 4. Extract tool safety logic → `safety.py` 5. Keep main entry point and arg parsing in `interface.py` 6. Update `__init__.py` to expose main entry point 7. Update imports and entry points **Key functionality to preserve:** - Main CLI entry point: `timmy_cli()` function - Chat interface with streaming responses - Think command with session management - Tool safety validation - Status reporting and diagnostics **Import compatibility:** Ensure these work after refactor: ```python from timmy.cli import timmy_cli # Entry point in setup.py should still work ``` **How to verify:** 1. `tox -e unit` - all tests pass 2. `tox -e lint` - no import errors 3. CLI commands still work: `python -m timmy.cli chat` 4. Entry point works if defined **Split guidelines:** - Each file 150-200 lines max - Keep related UI/UX together - Separate concerns: interface vs commands vs safety - Maintain clean command flow This improves CLI maintainability and makes it easier to add new commands.
kimi was assigned by Timmy 2026-03-24 10:21:46 +00:00
kimi was unassigned by Timmy 2026-03-24 19:18:22 +00:00
Timmy commented 2026-03-24 20:08:52 +00:00
Author
Owner
Copy Link

[triage] Duplicate of #1401 (split cli.py). Closing to reduce queue noise.

[triage] Duplicate of #1401 (split cli.py). Closing to reduce queue noise.
Timmy closed this issue 2026-03-24 20:08:53 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
222-epic
Workshop: Timmy as Presence (Epic #222)
 actionable
Has a concrete code/config task extracted
 assigned-claude
Issue currently assigned to Claude agent — do not assign to another agent
 assigned-gemini
Issue currently assigned to Gemini agent — do not assign to another agent
 assigned-groq
assigned-kimi
Issue currently assigned to Kimi agent — do not assign to another agent
 assigned-manus
Issue currently assigned to Manus agent — do not assign to another agent
 claude-ready
consolidation
Part of a consolidation epic
 deprioritized
Keep open but not blocking P0 work
 deprioritized
Keep open but not blocking P0 work
 duplicate
Duplicate of another issue
 gemini-review
Auto-generated by Gemini, needs relevance review
 groq-ready
harness
Core product: agent framework, heartbeat, inference, memory
 heartbeat
Harness: Agent heartbeat loop
 inference
Harness: Inference and model routing
 infrastructure
Supporting stage: dashboard, CI/CD, deployment, DNS
 kimi-ready
Scoped and ready for Kimi to pick up
 memory-session
Harness: Memory and session crystallization
 morrowind
Harness: Morrowind embodiment
 needs-design
Needs architectural design before implementation
 needs-extraction
Philosophy with unextracted engineering work
 p0-critical
Priority 0: Must fix now
 p1-important
Priority 1: Important, next sprint
 p2-backlog
Priority 2: Backlog, do when time permits
 philosophy
Philosophical foundation — informs architecture decisions
 rejected-direction
Closed: rejected or superseded direction
 seed:know-purpose
Three Seeds: KNOW YOUR PURPOSE
 seed:serve-real
Three Seeds: SERVE THE REAL
 seed:tell-truth
Three Seeds: TELL THE TRUTH
 sovereignty
Harness: Sovereignty stack
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Timmy claude grok groq kimi manus perplexity Rockachopa
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Rockachopa/Timmy-time-dashboard#1369
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?