Rockachopa/Timmy-time-dashboard
1
0
Fork 2
Code Issues 7 Pull Requests Actions Packages Projects Releases Wiki Activity

[loop-generated] [security] Split moderation.py — 497 lines, content filtering system #1407

New Issue
Closed
opened 2026-03-24 12:54:03 +00:00 by Timmy · 1 comment
Timmy commented 2026-03-24 12:54:03 +00:00
Owner
Copy Link

Problem

src/infrastructure/guards/moderation.py is 497 lines handling critical security functions:

  • Content filtering and safety checks
  • Prompt injection detection
  • Response sanitization
  • Policy enforcement
  • Threat pattern matching

Proposed Split

  1. Extract content filters into src/infrastructure/guards/filters/content.py
  2. Extract injection detection into src/infrastructure/guards/filters/injection.py
  3. Extract sanitization into src/infrastructure/guards/filters/sanitizer.py
  4. Extract policy engine into src/infrastructure/guards/policy.py
  5. Keep moderation.py as orchestrator

Benefits

  • Isolated testing of security components
  • Clear separation of security concerns
  • Easier security auditing
  • Pluggable filter architecture
  • Better maintainability of critical security code

Security Considerations

  • All existing security guarantees must be preserved
  • No relaxation of current safety checks
  • Comprehensive test coverage for all security components
  • Performance must not degrade (security is performance-critical)

Acceptance Criteria

  • No module exceeds 200 lines after split
  • ALL existing security functionality preserved
  • All tests pass (tox -e unit)
  • Security benchmarks pass
  • No performance regression in moderation pipeline
  • Clean separation of security concerns

Files

  • src/infrastructure/guards/moderation.py (primary, 497 lines)

Lines of code is a liability. Delete as much as you create.

## Problem `src/infrastructure/guards/moderation.py` is 497 lines handling critical security functions: - Content filtering and safety checks - Prompt injection detection - Response sanitization - Policy enforcement - Threat pattern matching ## Proposed Split 1. Extract content filters into `src/infrastructure/guards/filters/content.py` 2. Extract injection detection into `src/infrastructure/guards/filters/injection.py` 3. Extract sanitization into `src/infrastructure/guards/filters/sanitizer.py` 4. Extract policy engine into `src/infrastructure/guards/policy.py` 5. Keep `moderation.py` as orchestrator ## Benefits - Isolated testing of security components - Clear separation of security concerns - Easier security auditing - Pluggable filter architecture - Better maintainability of critical security code ## Security Considerations - All existing security guarantees must be preserved - No relaxation of current safety checks - Comprehensive test coverage for all security components - Performance must not degrade (security is performance-critical) ## Acceptance Criteria - [ ] No module exceeds 200 lines after split - [ ] ALL existing security functionality preserved - [ ] All tests pass (`tox -e unit`) - [ ] Security benchmarks pass - [ ] No performance regression in moderation pipeline - [ ] Clean separation of security concerns ## Files - `src/infrastructure/guards/moderation.py` (primary, 497 lines) Lines of code is a liability. Delete as much as you create.
Timmy commented 2026-03-24 12:54:22 +00:00
Author
Owner
Copy Link

Implementation Instructions

This is a SECURITY-CRITICAL refactor. All existing security guarantees must be preserved.

Step-by-Step Implementation:

  1. Create package structure:

    src/infrastructure/guards/
├── moderation.py (orchestrator - keep thin)
├── policy.py (policy engine)
└── filters/
    ├── __init__.py
    ├── content.py (content filtering)
    ├── injection.py (prompt injection detection)
    └── sanitizer.py (response sanitization)

  2. Security Components to Extract:

    • content.py: Text analysis, keyword detection, content classification
    • injection.py: Prompt injection patterns, escape sequence detection
    • sanitizer.py: Output cleaning, HTML/script stripping, safe formatting
    • policy.py: Rule evaluation, policy configuration, enforcement logic

  3. Keep in moderation.py (orchestrator):

    • Main moderate_content() function
    • Component coordination
    • Error handling and logging
    • Public API surface

  4. Testing Requirements:

    • Run full security test suite
    • Verify ALL existing security checks still work
    • No performance regression
    • All existing import paths continue to work

  5. Validation:

    tox -e unit  # Must pass 100%
# Verify security benchmarks pass
# Check performance metrics

CRITICAL: This module protects against malicious input. Any mistake could create security vulnerabilities. Test thoroughly.

## Implementation Instructions This is a SECURITY-CRITICAL refactor. All existing security guarantees must be preserved. ### Step-by-Step Implementation: 1. **Create package structure:** ``` src/infrastructure/guards/ ├── moderation.py (orchestrator - keep thin) ├── policy.py (policy engine) └── filters/ ├── __init__.py ├── content.py (content filtering) ├── injection.py (prompt injection detection) └── sanitizer.py (response sanitization) ``` 2. **Security Components to Extract:** - **content.py**: Text analysis, keyword detection, content classification - **injection.py**: Prompt injection patterns, escape sequence detection - **sanitizer.py**: Output cleaning, HTML/script stripping, safe formatting - **policy.py**: Rule evaluation, policy configuration, enforcement logic 3. **Keep in moderation.py (orchestrator):** - Main `moderate_content()` function - Component coordination - Error handling and logging - Public API surface 4. **Testing Requirements:** - Run full security test suite - Verify ALL existing security checks still work - No performance regression - All existing import paths continue to work 5. **Validation:** ```bash tox -e unit # Must pass 100% # Verify security benchmarks pass # Check performance metrics ``` **CRITICAL**: This module protects against malicious input. Any mistake could create security vulnerabilities. Test thoroughly.
kimi was assigned by Timmy 2026-03-24 12:54:28 +00:00
kimi was unassigned by Timmy 2026-03-24 19:32:24 +00:00
Timmy closed this issue 2026-03-24 21:54:13 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
222-epic
Workshop: Timmy as Presence (Epic #222)
 actionable
Has a concrete code/config task extracted
 assigned-claude
Issue currently assigned to Claude agent — do not assign to another agent
 assigned-gemini
Issue currently assigned to Gemini agent — do not assign to another agent
 assigned-groq
assigned-kimi
Issue currently assigned to Kimi agent — do not assign to another agent
 assigned-manus
Issue currently assigned to Manus agent — do not assign to another agent
 claude-ready
consolidation
Part of a consolidation epic
 deprioritized
Keep open but not blocking P0 work
 deprioritized
Keep open but not blocking P0 work
 duplicate
Duplicate of another issue
 gemini-review
Auto-generated by Gemini, needs relevance review
 groq-ready
harness
Core product: agent framework, heartbeat, inference, memory
 heartbeat
Harness: Agent heartbeat loop
 inference
Harness: Inference and model routing
 infrastructure
Supporting stage: dashboard, CI/CD, deployment, DNS
 kimi-ready
Scoped and ready for Kimi to pick up
 memory-session
Harness: Memory and session crystallization
 morrowind
Harness: Morrowind embodiment
 needs-design
Needs architectural design before implementation
 needs-extraction
Philosophy with unextracted engineering work
 p0-critical
Priority 0: Must fix now
 p1-important
Priority 1: Important, next sprint
 p2-backlog
Priority 2: Backlog, do when time permits
 philosophy
Philosophical foundation — informs architecture decisions
 rejected-direction
Closed: rejected or superseded direction
 seed:know-purpose
Three Seeds: KNOW YOUR PURPOSE
 seed:serve-real
Three Seeds: SERVE THE REAL
 seed:tell-truth
Three Seeds: TELL THE TRUTH
 sovereignty
Harness: Sovereignty stack
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Timmy claude grok groq kimi manus perplexity Rockachopa
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Rockachopa/Timmy-time-dashboard#1407
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?