Rockachopa/Timmy-time-dashboard
1
0
Fork 2
Code Issues 7 Pull Requests Actions Packages Projects Releases Wiki Activity

[Refactor] Unify Skip List Logic Across All Agent Loops into a Shared Library #1417

New Issue
Closed
opened 2026-03-24 13:04:32 +00:00 by Timmy · 1 comment
Timmy commented 2026-03-24 13:04:32 +00:00
Owner
Copy Link

Context: timmy-loop.sh, kimi-loop.sh, and claude-loop.sh duplicate inline JSON skip-list interactions via python3 -c.

Acceptance Criteria:

  • Abstract skip-list operations into a standard python package inside the repository.
  • Utilize standard file locking.
**Context:** `timmy-loop.sh`, `kimi-loop.sh`, and `claude-loop.sh` duplicate inline JSON skip-list interactions via `python3 -c`. **Acceptance Criteria:** - Abstract skip-list operations into a standard python package inside the repository. - Utilize standard file locking.
Timmy commented 2026-03-24 15:06:40 +00:00
Author
Owner
Copy Link

KIMI IMPLEMENTATION INSTRUCTIONS:

Unify the duplicated skip-list logic across all agent loops into a reusable library.

FILES TO CREATE:

src/infrastructure/agent_loops/__init__.py
src/infrastructure/agent_loops/skip_list.py
src/infrastructure/agent_loops/file_lock.py
tests/infrastructure/test_skip_list.py

FILES TO MODIFY:

scripts/timmy-loop.sh
scripts/kimi-loop.sh
scripts/claude-loop.sh

STEP-BY-STEP IMPLEMENTATION:

  1. Create Skip List Core (src/infrastructure/agent_loops/skip_list.py):

    • SkipListManager class with load(), save(), add_item(), remove_item(), contains()
    • JSON file handling with atomic writes
    • Integration with file locking for concurrent access
    • Proper error handling and validation

  2. Create File Locking (src/infrastructure/agent_loops/file_lock.py):

    • FileLock context manager using fcntl (Unix) or msvcrt (Windows)
    • Timeout handling for lock acquisition
    • Automatic cleanup on context exit

  3. Update Agent Scripts - Replace inline JSON operations:

    • timmy-loop.sh: Replace python3 -c JSON operations with library calls
    • kimi-loop.sh: Same refactoring
    • claude-loop.sh: Same refactoring
    • Preserve existing command-line interfaces

  4. Add Comprehensive Tests (tests/infrastructure/test_skip_list.py):

    • Test JSON loading/saving
    • Test concurrent access with multiple processes
    • Test file locking behavior
    • Test error conditions (corrupted JSON, permission errors)

VERIFICATION:

  • Run tox -e unit - all tests must pass
  • All three agent scripts should work identically to before
  • Skip list operations should be thread-safe with proper locking
  • No race conditions in concurrent skip list access

CRITICAL: Preserve exact behavior of existing scripts while removing code duplication.

PROCEED WITH IMPLEMENTATION.

**KIMI IMPLEMENTATION INSTRUCTIONS:** Unify the duplicated skip-list logic across all agent loops into a reusable library. **FILES TO CREATE:** ``` src/infrastructure/agent_loops/__init__.py src/infrastructure/agent_loops/skip_list.py src/infrastructure/agent_loops/file_lock.py tests/infrastructure/test_skip_list.py ``` **FILES TO MODIFY:** ``` scripts/timmy-loop.sh scripts/kimi-loop.sh scripts/claude-loop.sh ``` **STEP-BY-STEP IMPLEMENTATION:** 1. **Create Skip List Core** (`src/infrastructure/agent_loops/skip_list.py`): - SkipListManager class with load(), save(), add_item(), remove_item(), contains() - JSON file handling with atomic writes - Integration with file locking for concurrent access - Proper error handling and validation 2. **Create File Locking** (`src/infrastructure/agent_loops/file_lock.py`): - FileLock context manager using fcntl (Unix) or msvcrt (Windows) - Timeout handling for lock acquisition - Automatic cleanup on context exit 3. **Update Agent Scripts** - Replace inline JSON operations: - timmy-loop.sh: Replace python3 -c JSON operations with library calls - kimi-loop.sh: Same refactoring - claude-loop.sh: Same refactoring - Preserve existing command-line interfaces 4. **Add Comprehensive Tests** (`tests/infrastructure/test_skip_list.py`): - Test JSON loading/saving - Test concurrent access with multiple processes - Test file locking behavior - Test error conditions (corrupted JSON, permission errors) **VERIFICATION:** - Run `tox -e unit` - all tests must pass - All three agent scripts should work identically to before - Skip list operations should be thread-safe with proper locking - No race conditions in concurrent skip list access **CRITICAL:** Preserve exact behavior of existing scripts while removing code duplication. PROCEED WITH IMPLEMENTATION.
kimi was assigned by Timmy 2026-03-24 15:06:45 +00:00
kimi was unassigned by Timmy 2026-03-24 19:32:19 +00:00
Timmy closed this issue 2026-03-24 21:54:09 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
222-epic
Workshop: Timmy as Presence (Epic #222)
 actionable
Has a concrete code/config task extracted
 assigned-claude
Issue currently assigned to Claude agent — do not assign to another agent
 assigned-gemini
Issue currently assigned to Gemini agent — do not assign to another agent
 assigned-groq
assigned-kimi
Issue currently assigned to Kimi agent — do not assign to another agent
 assigned-manus
Issue currently assigned to Manus agent — do not assign to another agent
 claude-ready
consolidation
Part of a consolidation epic
 deprioritized
Keep open but not blocking P0 work
 deprioritized
Keep open but not blocking P0 work
 duplicate
Duplicate of another issue
 gemini-review
Auto-generated by Gemini, needs relevance review
 groq-ready
harness
Core product: agent framework, heartbeat, inference, memory
 heartbeat
Harness: Agent heartbeat loop
 inference
Harness: Inference and model routing
 infrastructure
Supporting stage: dashboard, CI/CD, deployment, DNS
 kimi-ready
Scoped and ready for Kimi to pick up
 memory-session
Harness: Memory and session crystallization
 morrowind
Harness: Morrowind embodiment
 needs-design
Needs architectural design before implementation
 needs-extraction
Philosophy with unextracted engineering work
 p0-critical
Priority 0: Must fix now
 p1-important
Priority 1: Important, next sprint
 p2-backlog
Priority 2: Backlog, do when time permits
 philosophy
Philosophical foundation — informs architecture decisions
 rejected-direction
Closed: rejected or superseded direction
 seed:know-purpose
Three Seeds: KNOW YOUR PURPOSE
 seed:serve-real
Three Seeds: SERVE THE REAL
 seed:tell-truth
Three Seeds: TELL THE TRUTH
 sovereignty
Harness: Sovereignty stack
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Timmy claude grok groq kimi manus perplexity Rockachopa
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Rockachopa/Timmy-time-dashboard#1417
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?