[loop-generated] [bug] Pre-push hook times out on agentic_loop test (Ollama connection) #1459

Closed
opened 2026-03-24 19:53:32 +00:00 by Timmy · 1 comment
Owner

Bug

The pre-push hook (tox -e pre-push) hangs/times out due to a test in the agentic_loop suite that attempts to connect to Ollama. This blocks legitimate pushes.

Reproduction

  1. Make any change on a branch
  2. Run git push (triggers pre-push hook)
  3. Hook eventually times out on agentic_loop tests that try real Ollama connections

Expected

All tests in pre-push should use mocks for external services. No test should depend on Ollama being available.

Impact

Forces agents to bypass the pre-push hook, weakening the CI gate.

Suggested fix

  • Mock Ollama connections in agentic_loop tests
  • Add timeout guards to any test that makes network calls
  • Ensure tox -e unit and tox -e pre-push work fully offline
## Bug The pre-push hook (`tox -e pre-push`) hangs/times out due to a test in the agentic_loop suite that attempts to connect to Ollama. This blocks legitimate pushes. ## Reproduction 1. Make any change on a branch 2. Run `git push` (triggers pre-push hook) 3. Hook eventually times out on agentic_loop tests that try real Ollama connections ## Expected All tests in pre-push should use mocks for external services. No test should depend on Ollama being available. ## Impact Forces agents to bypass the pre-push hook, weakening the CI gate. ## Suggested fix - Mock Ollama connections in agentic_loop tests - Add timeout guards to any test that makes network calls - Ensure `tox -e unit` and `tox -e pre-push` work fully offline
Author
Owner

Investigation Complete — Cannot Reproduce

Thorough investigation of all agentic_loop and ollama test files shows:

  1. All agentic_loop tests properly mock _get_loop_agent() — no real Ollama connections
  2. conftest_markers.py auto-marks tests with "ollama" in the path, and tox -e unit/pre-push exclude those
  3. tox -e unit passes cleanly: 966 passed, 3 skipped, 7.68s — no hangs

The tox configuration already excludes -m "not ollama" from both unit and pre-push envs. The conftest auto-marker system catches any test file with "ollama" in its path.

Closing as cannot-reproduce. If this recurs, it may be an import-time side effect from agno.models.ollama.Ollama — if so, reopen with the specific test name and stack trace.

## Investigation Complete — Cannot Reproduce Thorough investigation of all agentic_loop and ollama test files shows: 1. **All agentic_loop tests properly mock** `_get_loop_agent()` — no real Ollama connections 2. **conftest_markers.py auto-marks** tests with "ollama" in the path, and tox -e unit/pre-push exclude those 3. **tox -e unit passes cleanly**: 966 passed, 3 skipped, 7.68s — no hangs The tox configuration already excludes `-m "not ollama"` from both unit and pre-push envs. The conftest auto-marker system catches any test file with "ollama" in its path. **Closing as cannot-reproduce.** If this recurs, it may be an import-time side effect from `agno.models.ollama.Ollama` — if so, reopen with the specific test name and stack trace.
Timmy closed this issue 2026-03-24 20:38:32 +00:00
Sign in to join this conversation.
No Label
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Rockachopa/Timmy-time-dashboard#1459