Rockachopa/Timmy-time-dashboard
1
0
Fork 2
Code Issues 7 Pull Requests Actions Packages Projects Releases Wiki Activity

[loop-generated] [refactor] Break up oversized functions (100+ lines) #151

New Issue
Closed
opened 2026-03-15 14:27:12 +00:00 by hermes · 0 comments
hermes commented 2026-03-15 14:27:12 +00:00
Collaborator
Copy Link

Problem

Several functions exceed 100 lines, making them hard to test, debug, and maintain:

Function File Lines
run_agentic_loop() src/timmy/agentic_loop.py 215
get_all_available_tools() src/timmy/tools.py 157
create_full_toolkit() src/timmy/tools.py 141
capture_error() src/infrastructure/error_capture.py 141
create_timmy() src/timmy/agent.py 126
lifespan() src/dashboard/app.py 122
complete() src/infrastructure/router/cascade.py 121
_maybe_distill() src/timmy/thinking.py 109
think_once() src/timmy/thinking.py 103
get_memory_status() src/timmy/tools_intro/__init__.py 98

tools.py alone is 879 lines.

Proposed fix

Extract logical sub-steps into named helper functions. Each function should do one thing. Target max 50 lines per function where practical.

Prioritize tools.py — the two 140+ line functions are just building dict/list structures that could be split by category.

Impact

  • Easier to test individual behaviors
  • Easier to read and review
  • Lines removed >= lines added (extract, don't duplicate)
## Problem Several functions exceed 100 lines, making them hard to test, debug, and maintain: | Function | File | Lines | |---|---|---| | `run_agentic_loop()` | `src/timmy/agentic_loop.py` | 215 | | `get_all_available_tools()` | `src/timmy/tools.py` | 157 | | `create_full_toolkit()` | `src/timmy/tools.py` | 141 | | `capture_error()` | `src/infrastructure/error_capture.py` | 141 | | `create_timmy()` | `src/timmy/agent.py` | 126 | | `lifespan()` | `src/dashboard/app.py` | 122 | | `complete()` | `src/infrastructure/router/cascade.py` | 121 | | `_maybe_distill()` | `src/timmy/thinking.py` | 109 | | `think_once()` | `src/timmy/thinking.py` | 103 | | `get_memory_status()` | `src/timmy/tools_intro/__init__.py` | 98 | `tools.py` alone is 879 lines. ## Proposed fix Extract logical sub-steps into named helper functions. Each function should do one thing. Target max 50 lines per function where practical. Prioritize `tools.py` — the two 140+ line functions are just building dict/list structures that could be split by category. ## Impact - Easier to test individual behaviors - Easier to read and review - Lines removed >= lines added (extract, don't duplicate)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
222-epic
Workshop: Timmy as Presence (Epic #222)
 actionable
Has a concrete code/config task extracted
 assigned-claude
Issue currently assigned to Claude agent — do not assign to another agent
 assigned-gemini
Issue currently assigned to Gemini agent — do not assign to another agent
 assigned-groq
assigned-kimi
Issue currently assigned to Kimi agent — do not assign to another agent
 assigned-manus
Issue currently assigned to Manus agent — do not assign to another agent
 claude-ready
consolidation
Part of a consolidation epic
 deprioritized
Keep open but not blocking P0 work
 deprioritized
Keep open but not blocking P0 work
 duplicate
Duplicate of another issue
 gemini-review
Auto-generated by Gemini, needs relevance review
 groq-ready
harness
Core product: agent framework, heartbeat, inference, memory
 heartbeat
Harness: Agent heartbeat loop
 inference
Harness: Inference and model routing
 infrastructure
Supporting stage: dashboard, CI/CD, deployment, DNS
 kimi-ready
Scoped and ready for Kimi to pick up
 memory-session
Harness: Memory and session crystallization
 morrowind
Harness: Morrowind embodiment
 needs-design
Needs architectural design before implementation
 needs-extraction
Philosophy with unextracted engineering work
 p0-critical
Priority 0: Must fix now
 p1-important
Priority 1: Important, next sprint
 p2-backlog
Priority 2: Backlog, do when time permits
 philosophy
Philosophical foundation — informs architecture decisions
 rejected-direction
Closed: rejected or superseded direction
 seed:know-purpose
Three Seeds: KNOW YOUR PURPOSE
 seed:serve-real
Three Seeds: SERVE THE REAL
 seed:tell-truth
Three Seeds: TELL THE TRUTH
 sovereignty
Harness: Sovereignty stack
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Timmy claude grok groq kimi manus perplexity Rockachopa
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Rockachopa/Timmy-time-dashboard#151
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?