Rockachopa/Timmy-time-dashboard
1
0
Fork 2
Code Issues 7 Pull Requests Actions Packages Projects Releases Wiki Activity

[loop-generated] [refactor] Narrow broad except Exception catches — batch 1 (top 20) #158

New Issue
Closed
opened 2026-03-15 15:08:34 +00:00 by hermes · 1 comment
hermes commented 2026-03-15 15:08:34 +00:00
Collaborator
Copy Link

206 except Exception catches across src/. Most swallow errors silently or catch too broadly.

SOUL.md demands honesty and traceability. Silent exception swallowing is the opposite.

Batch 1 scope: narrow the 20 most dangerous cases (in routes, agent logic, and infrastructure).

Rules:

  • Replace except Exception with specific exceptions
  • Add logging to any catch that was silent
  • Do NOT remove error handling — narrow it
206 `except Exception` catches across src/. Most swallow errors silently or catch too broadly. SOUL.md demands honesty and traceability. Silent exception swallowing is the opposite. Batch 1 scope: narrow the 20 most dangerous cases (in routes, agent logic, and infrastructure). Rules: - Replace `except Exception` with specific exceptions - Add logging to any catch that was silent - Do NOT remove error handling — narrow it
hermes commented 2026-03-15 15:39:55 +00:00
Author
Collaborator
Copy Link

Triage Refinement — Specific Top 20 Catches

Deep triage identified the most dangerous except Exception catches. Here are the top 20 to fix in batch 1, prioritized by risk (route/agent logic first):

Agent core (highest risk — swallowed errors hide bugs):

  1. src/timmy/agent.py:82
  2. src/timmy/agent.py:169
  3. src/timmy/agent.py:286
  4. src/timmy/agent.py:306

Agentic loop (drives all autonomous work):
5. src/timmy/agentic_loop.py:139
6. src/timmy/agentic_loop.py:220
7. src/timmy/agentic_loop.py:268
8. src/timmy/agentic_loop.py:328

Tools (user-facing operations):
9. src/timmy/tools.py:185
10. src/timmy/tools.py:321
11. src/timmy/tools.py:448
12. src/timmy/tools.py:462
13. src/timmy/tools.py:503
14. src/timmy/tools.py:517
15. src/timmy/tools.py:566
16. src/timmy/tools.py:585
17. src/timmy/tools.py:598

Delegation (inter-agent comms):
18. src/timmy/tools_delegation/__init__.py:83
19. src/timmy/tools_delegation/__init__.py:155

Sub-agents:
20. src/timmy/agents/base.py:139

For each: inspect what exceptions that code path actually throws, narrow the catch, and ensure the except block logs the error (not silently swallows).

[triage-generated]

## Triage Refinement — Specific Top 20 Catches Deep triage identified the most dangerous `except Exception` catches. Here are the top 20 to fix in batch 1, prioritized by risk (route/agent logic first): **Agent core (highest risk — swallowed errors hide bugs):** 1. `src/timmy/agent.py:82` 2. `src/timmy/agent.py:169` 3. `src/timmy/agent.py:286` 4. `src/timmy/agent.py:306` **Agentic loop (drives all autonomous work):** 5. `src/timmy/agentic_loop.py:139` 6. `src/timmy/agentic_loop.py:220` 7. `src/timmy/agentic_loop.py:268` 8. `src/timmy/agentic_loop.py:328` **Tools (user-facing operations):** 9. `src/timmy/tools.py:185` 10. `src/timmy/tools.py:321` 11. `src/timmy/tools.py:448` 12. `src/timmy/tools.py:462` 13. `src/timmy/tools.py:503` 14. `src/timmy/tools.py:517` 15. `src/timmy/tools.py:566` 16. `src/timmy/tools.py:585` 17. `src/timmy/tools.py:598` **Delegation (inter-agent comms):** 18. `src/timmy/tools_delegation/__init__.py:83` 19. `src/timmy/tools_delegation/__init__.py:155` **Sub-agents:** 20. `src/timmy/agents/base.py:139` For each: inspect what exceptions that code path actually throws, narrow the catch, and ensure the except block logs the error (not silently swallows). [triage-generated]
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
222-epic
Workshop: Timmy as Presence (Epic #222)
 actionable
Has a concrete code/config task extracted
 assigned-claude
Issue currently assigned to Claude agent — do not assign to another agent
 assigned-gemini
Issue currently assigned to Gemini agent — do not assign to another agent
 assigned-groq
assigned-kimi
Issue currently assigned to Kimi agent — do not assign to another agent
 assigned-manus
Issue currently assigned to Manus agent — do not assign to another agent
 claude-ready
consolidation
Part of a consolidation epic
 deprioritized
Keep open but not blocking P0 work
 deprioritized
Keep open but not blocking P0 work
 duplicate
Duplicate of another issue
 gemini-review
Auto-generated by Gemini, needs relevance review
 groq-ready
harness
Core product: agent framework, heartbeat, inference, memory
 heartbeat
Harness: Agent heartbeat loop
 inference
Harness: Inference and model routing
 infrastructure
Supporting stage: dashboard, CI/CD, deployment, DNS
 kimi-ready
Scoped and ready for Kimi to pick up
 memory-session
Harness: Memory and session crystallization
 morrowind
Harness: Morrowind embodiment
 needs-design
Needs architectural design before implementation
 needs-extraction
Philosophy with unextracted engineering work
 p0-critical
Priority 0: Must fix now
 p1-important
Priority 1: Important, next sprint
 p2-backlog
Priority 2: Backlog, do when time permits
 philosophy
Philosophical foundation — informs architecture decisions
 rejected-direction
Closed: rejected or superseded direction
 seed:know-purpose
Three Seeds: KNOW YOUR PURPOSE
 seed:serve-real
Three Seeds: SERVE THE REAL
 seed:tell-truth
Three Seeds: TELL THE TRUTH
 sovereignty
Harness: Sovereignty stack
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Timmy claude grok groq kimi manus perplexity Rockachopa
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Rockachopa/Timmy-time-dashboard#158
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?