Rockachopa/Timmy-time-dashboard
1
0
Fork 2
Code Issues 7 Pull Requests Actions Packages Projects Releases Wiki Activity

Consolidate memory systems: 3 overlapping implementations #27

New Issue
Closed
opened 2026-03-14 13:33:34 +00:00 by Rockachopa · 1 comment
Rockachopa commented 2026-03-14 13:33:34 +00:00
Owner
Copy Link

What

There are at least 3 separate memory implementations that overlap:

  1. timmy/memory_system.py (519 lines) — Three-tier: MEMORY.md hot memory + vault markdown + semantic search. The "official" system.

  2. timmy/semantic_memory.py (244 lines) — Standalone vector search with SQLite + cosine similarity. Has its own chunking, embedding, search.

  3. timmy/memory/vector_store.py (153 lines) + unified.py (25 lines) — Yet another memory abstraction layer.

  4. brain/memory.py (227 lines) — Distributed brain memory for rqlite. Dead if brain module is deleted.

Plus Agno's built-in SQLite conversation history via SqliteDb(db_file=db_file).

Why

Three+ systems doing the same thing means bugs get fixed in one but not others, memory is fragmented, and the codebase is confusing.

What to do

  1. Pick ONE memory system. memory_system.py (three-tier) is the most complete.
  2. Merge any unique features from semantic_memory.py into it (vector search is useful)
  3. Delete memory/vector_store.py, memory/unified.py if they're just wrappers
  4. Delete brain/memory.py if brain module is removed
  5. Update all callers to use the single system

Files

  • src/timmy/memory_system.py — KEEP, consolidate into
  • src/timmy/semantic_memory.py — MERGE useful parts, then delete
  • src/timmy/memory/ — evaluate, likely delete
  • src/brain/memory.py — DELETE with brain module

Estimated effort: 3-4 hours

## What There are at least 3 separate memory implementations that overlap: 1. **`timmy/memory_system.py`** (519 lines) — Three-tier: MEMORY.md hot memory + vault markdown + semantic search. The "official" system. 2. **`timmy/semantic_memory.py`** (244 lines) — Standalone vector search with SQLite + cosine similarity. Has its own chunking, embedding, search. 3. **`timmy/memory/vector_store.py`** (153 lines) + `unified.py` (25 lines) — Yet another memory abstraction layer. 4. **`brain/memory.py`** (227 lines) — Distributed brain memory for rqlite. Dead if brain module is deleted. Plus Agno's built-in SQLite conversation history via `SqliteDb(db_file=db_file)`. ## Why Three+ systems doing the same thing means bugs get fixed in one but not others, memory is fragmented, and the codebase is confusing. ## What to do 1. Pick ONE memory system. `memory_system.py` (three-tier) is the most complete. 2. Merge any unique features from `semantic_memory.py` into it (vector search is useful) 3. Delete `memory/vector_store.py`, `memory/unified.py` if they're just wrappers 4. Delete `brain/memory.py` if brain module is removed 5. Update all callers to use the single system ## Files - `src/timmy/memory_system.py` — KEEP, consolidate into - `src/timmy/semantic_memory.py` — MERGE useful parts, then delete - `src/timmy/memory/` — evaluate, likely delete - `src/brain/memory.py` — DELETE with brain module ## Estimated effort: 3-4 hours
hermes commented 2026-03-14 16:48:07 +00:00
Collaborator
Copy Link

Closing and replacing with sharper, investigation-backed issues after full code review of the memory landscape. — Hermes

Closing and replacing with sharper, investigation-backed issues after full code review of the memory landscape. — Hermes
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
222-epic
Workshop: Timmy as Presence (Epic #222)
 actionable
Has a concrete code/config task extracted
 assigned-claude
Issue currently assigned to Claude agent — do not assign to another agent
 assigned-gemini
Issue currently assigned to Gemini agent — do not assign to another agent
 assigned-groq
assigned-kimi
Issue currently assigned to Kimi agent — do not assign to another agent
 assigned-manus
Issue currently assigned to Manus agent — do not assign to another agent
 claude-ready
consolidation
Part of a consolidation epic
 deprioritized
Keep open but not blocking P0 work
 deprioritized
Keep open but not blocking P0 work
 duplicate
Duplicate of another issue
 gemini-review
Auto-generated by Gemini, needs relevance review
 groq-ready
harness
Core product: agent framework, heartbeat, inference, memory
 heartbeat
Harness: Agent heartbeat loop
 inference
Harness: Inference and model routing
 infrastructure
Supporting stage: dashboard, CI/CD, deployment, DNS
 kimi-ready
Scoped and ready for Kimi to pick up
 memory-session
Harness: Memory and session crystallization
 morrowind
Harness: Morrowind embodiment
 needs-design
Needs architectural design before implementation
 needs-extraction
Philosophy with unextracted engineering work
 p0-critical
Priority 0: Must fix now
 p1-important
Priority 1: Important, next sprint
 p2-backlog
Priority 2: Backlog, do when time permits
 philosophy
Philosophical foundation — informs architecture decisions
 rejected-direction
Closed: rejected or superseded direction
 seed:know-purpose
Three Seeds: KNOW YOUR PURPOSE
 seed:serve-real
Three Seeds: SERVE THE REAL
 seed:tell-truth
Three Seeds: TELL THE TRUTH
 sovereignty
Harness: Sovereignty stack
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Timmy claude grok groq kimi manus perplexity Rockachopa
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Rockachopa/Timmy-time-dashboard#27
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?