Rockachopa/Timmy-time-dashboard
1
0
Fork 2
Code Issues 7 Pull Requests Actions Packages Projects Releases Wiki Activity

[loop-generated] [test] Add unit tests for jot_note and log_decision artifact tools #340

New Issue
Closed
opened 2026-03-19 00:37:50 +00:00 by hermes · 1 comment
hermes commented 2026-03-19 00:37:50 +00:00
Collaborator
Copy Link

Context

PR #337 added jot_note and log_decision tools to src/timmy/memory_system.py and wired them in src/timmy/tools.py. No unit tests were included.

What to test

  1. jot_note(title, body) — writes timestamped markdown to ~/.timmy/notes/

    • Happy path: creates file with correct content
    • Empty title returns error
    • Empty body returns error
    • Slug generation from title
    • Directory creation (uses tmp_path fixture)

  2. log_decision(decision, rationale) — appends to ~/.timmy/decisions.md

    • Happy path: appends entry
    • Creates file with header if not exists
    • Empty decision returns error
    • Rationale is optional
    • Multiple decisions append correctly

  3. Registration: create_full_toolkit() includes both tools

Files

  • Test file: tests/timmy/test_artifact_tools.py (new)
  • Source: src/timmy/memory_system.py (read-only, for reference)

Notes

Patch Path.home() or NOTES_DIR/DECISION_LOG constants to use tmp_path fixture so tests dont write to real home directory.

## Context PR #337 added `jot_note` and `log_decision` tools to `src/timmy/memory_system.py` and wired them in `src/timmy/tools.py`. No unit tests were included. ## What to test 1. `jot_note(title, body)` — writes timestamped markdown to `~/.timmy/notes/` - Happy path: creates file with correct content - Empty title returns error - Empty body returns error - Slug generation from title - Directory creation (uses `tmp_path` fixture) 2. `log_decision(decision, rationale)` — appends to `~/.timmy/decisions.md` - Happy path: appends entry - Creates file with header if not exists - Empty decision returns error - Rationale is optional - Multiple decisions append correctly 3. Registration: `create_full_toolkit()` includes both tools ## Files - Test file: `tests/timmy/test_artifact_tools.py` (new) - Source: `src/timmy/memory_system.py` (read-only, for reference) ## Notes Patch `Path.home()` or `NOTES_DIR`/`DECISION_LOG` constants to use `tmp_path` fixture so tests dont write to real home directory.
kimi was assigned by hermes 2026-03-19 00:41:17 +00:00
hermes commented 2026-03-19 00:41:27 +00:00
Author
Collaborator
Copy Link

Instructions for Kimi

Create tests/timmy/test_artifact_tools.py with unit tests for both artifact tools.

Source files to read first

  • src/timmy/memory_system.py — contains jot_note() and log_decision() implementations
  • src/timmy/tools.py — contains create_full_toolkit() registration

Tests needed

jot_note tests:

  1. Happy path: jot_note("Test Title", "some body") creates file in notes dir with correct content
  2. Slug generation: title "My Cool Note" creates file named with slug like my-cool-note.md
  3. Empty title returns error dict
  4. Empty body returns error dict
  5. Auto-creates directory if missing

log_decision tests:

  1. Happy path: log_decision("use Redis", "faster than file IO") appends to decisions.md
  2. Creates file with header if it does not exist
  3. Empty decision returns error dict
  4. Rationale is optional (None/empty ok)
  5. Multiple calls append correctly (call twice, verify both entries present)

Registration test:

  1. create_full_toolkit() result includes "jot_note" and "log_decision" tool names

IMPORTANT: Use tmp_path

Patch NOTES_DIR and DECISION_LOG constants (or Path.home()) to point at tmp_path fixture. Do NOT write to real home directory.

Verify

tox -e unit -- tests/timmy/test_artifact_tools.py -v

All tests must pass.

## Instructions for Kimi Create `tests/timmy/test_artifact_tools.py` with unit tests for both artifact tools. ### Source files to read first - `src/timmy/memory_system.py` — contains `jot_note()` and `log_decision()` implementations - `src/timmy/tools.py` — contains `create_full_toolkit()` registration ### Tests needed **jot_note tests:** 1. Happy path: `jot_note("Test Title", "some body")` creates file in notes dir with correct content 2. Slug generation: title "My Cool Note" creates file named with slug like `my-cool-note.md` 3. Empty title returns error dict 4. Empty body returns error dict 5. Auto-creates directory if missing **log_decision tests:** 1. Happy path: `log_decision("use Redis", "faster than file IO")` appends to decisions.md 2. Creates file with header if it does not exist 3. Empty decision returns error dict 4. Rationale is optional (None/empty ok) 5. Multiple calls append correctly (call twice, verify both entries present) **Registration test:** 1. `create_full_toolkit()` result includes "jot_note" and "log_decision" tool names ### IMPORTANT: Use tmp_path Patch `NOTES_DIR` and `DECISION_LOG` constants (or `Path.home()`) to point at `tmp_path` fixture. Do NOT write to real home directory. ### Verify ``` tox -e unit -- tests/timmy/test_artifact_tools.py -v ``` All tests must pass.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
222-epic
Workshop: Timmy as Presence (Epic #222)
 actionable
Has a concrete code/config task extracted
 assigned-claude
Issue currently assigned to Claude agent — do not assign to another agent
 assigned-gemini
Issue currently assigned to Gemini agent — do not assign to another agent
 assigned-groq
assigned-kimi
Issue currently assigned to Kimi agent — do not assign to another agent
 assigned-manus
Issue currently assigned to Manus agent — do not assign to another agent
 claude-ready
consolidation
Part of a consolidation epic
 deprioritized
Keep open but not blocking P0 work
 deprioritized
Keep open but not blocking P0 work
 duplicate
Duplicate of another issue
 gemini-review
Auto-generated by Gemini, needs relevance review
 groq-ready
harness
Core product: agent framework, heartbeat, inference, memory
 heartbeat
Harness: Agent heartbeat loop
 inference
Harness: Inference and model routing
 infrastructure
Supporting stage: dashboard, CI/CD, deployment, DNS
 kimi-ready
Scoped and ready for Kimi to pick up
 memory-session
Harness: Memory and session crystallization
 morrowind
Harness: Morrowind embodiment
 needs-design
Needs architectural design before implementation
 needs-extraction
Philosophy with unextracted engineering work
 p0-critical
Priority 0: Must fix now
 p1-important
Priority 1: Important, next sprint
 p2-backlog
Priority 2: Backlog, do when time permits
 philosophy
Philosophical foundation — informs architecture decisions
 rejected-direction
Closed: rejected or superseded direction
 seed:know-purpose
Three Seeds: KNOW YOUR PURPOSE
 seed:serve-real
Three Seeds: SERVE THE REAL
 seed:tell-truth
Three Seeds: TELL THE TRUTH
 sovereignty
Harness: Sovereignty stack
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Timmy claude grok groq kimi manus perplexity Rockachopa
No Assignees kimi
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Rockachopa/Timmy-time-dashboard#340
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?