Rockachopa/Timmy-time-dashboard
1
0
Fork 2
Code Issues 7 Pull Requests Actions Packages Projects Releases Wiki Activity

[loop-generated] [test] Add unit tests for tools.py — 988 lines of untested tool integration code #346

New Issue
Closed
opened 2026-03-19 00:54:27 +00:00 by hermes · 3 comments
hermes commented 2026-03-19 00:54:27 +00:00
Collaborator
Copy Link

Problem

src/timmy/tools.py is 988 lines with ZERO test coverage. It provides the tool integration layer for the agent swarm:

  • ToolStats dataclass for usage tracking
  • Tool usage recording and reporting
  • Creative pipeline tools (image, music, video generation)
  • Git operations wrapper
  • Shell/File/Python tool constructors
  • MCP tool wrappers

Acceptance criteria

  • Create tests/timmy/test_tools.py
  • Cover ToolStats dataclass fields and defaults
  • Cover record_tool_usage() and get_tool_stats()
  • Cover tool factory functions with mocked agno imports
  • Cover creative pipeline functions with mocked subprocess/API calls
  • All tests use tmp_path or mocks — no real filesystem/API calls
  • Target: 15+ test cases

Files

  • Source: src/timmy/tools.py
  • Test: tests/timmy/test_tools.py (create new)

Notes

  • agno imports are lazy and may not be available — test both paths
  • Creative tools call external processes — mock subprocess.run
## Problem `src/timmy/tools.py` is 988 lines with ZERO test coverage. It provides the tool integration layer for the agent swarm: - `ToolStats` dataclass for usage tracking - Tool usage recording and reporting - Creative pipeline tools (image, music, video generation) - Git operations wrapper - Shell/File/Python tool constructors - MCP tool wrappers ## Acceptance criteria - Create `tests/timmy/test_tools.py` - Cover `ToolStats` dataclass fields and defaults - Cover `record_tool_usage()` and `get_tool_stats()` - Cover tool factory functions with mocked agno imports - Cover creative pipeline functions with mocked subprocess/API calls - All tests use `tmp_path` or mocks — no real filesystem/API calls - Target: 15+ test cases ## Files - Source: `src/timmy/tools.py` - Test: `tests/timmy/test_tools.py` (create new) ## Notes - `agno` imports are lazy and may not be available — test both paths - Creative tools call external processes — mock `subprocess.run`
hermes commented 2026-03-19 00:54:50 +00:00
Author
Collaborator
Copy Link

Instructions for Kimi

Create tests/timmy/test_tools.py with unit tests.

Source to read first

  • src/timmy/tools.py (988 lines)

Key mocking patterns

  • agno.tools imports are lazy — test both _AGNO_TOOLS_AVAILABLE = True and False paths
  • Creative tools call subprocess — mock subprocess.run
  • Use tmp_path for any file-based tests
  • Mock config.settings for paths

Priority test targets

  1. ToolStats dataclass: fields, defaults
  2. record_tool_usage(tool_name, agent_id): adds usage entry
  3. get_tool_stats(): returns accumulated stats
  4. Tool factory functions: test they handle missing agno gracefully
  5. Creative pipeline functions: test with mocked subprocess

Run tests

tox -e unit -- tests/timmy/test_tools.py -v
## Instructions for Kimi Create `tests/timmy/test_tools.py` with unit tests. ### Source to read first - `src/timmy/tools.py` (988 lines) ### Key mocking patterns - `agno.tools` imports are lazy — test both `_AGNO_TOOLS_AVAILABLE = True` and `False` paths - Creative tools call subprocess — mock `subprocess.run` - Use `tmp_path` for any file-based tests - Mock `config.settings` for paths ### Priority test targets 1. `ToolStats` dataclass: fields, defaults 2. `record_tool_usage(tool_name, agent_id)`: adds usage entry 3. `get_tool_stats()`: returns accumulated stats 4. Tool factory functions: test they handle missing agno gracefully 5. Creative pipeline functions: test with mocked subprocess ### Run tests ```bash tox -e unit -- tests/timmy/test_tools.py -v ```
kimi was assigned by hermes 2026-03-19 00:54:50 +00:00
hermes commented 2026-03-19 01:22:37 +00:00
Author
Collaborator
Copy Link

Obsolete: tools.py belongs to old codebase being retired in Claude Code pivot.

Obsolete: tools.py belongs to old codebase being retired in Claude Code pivot.
hermes commented 2026-03-19 01:26:09 +00:00
Author
Collaborator
Copy Link

Kimi instructions:

Add unit tests for src/timmy/tools.py (currently at 63.4% coverage, 445 stmts / 163 missed).

Files to modify:

  • tests/timmy/test_tools.py (create or extend)

What to test:

  1. ToolRegistry class — register, lookup, list tools
  2. create_tools_for_agent() — tool creation with different personas
  3. execute_tool() — tool execution, error handling, timeout
  4. Individual tool functions: web_search_tool, shell_tool, file_read_tool, file_write_tool, python_tool
  5. Edge cases: unknown tool names, invalid arguments, permission denied

Key missed lines: 248-273, 321-348, 356-412, 448-464, 501-519, 540-642, 687-732, 900-966

How to verify:

tox -e unit -- tests/timmy/test_tools.py -v

Target: raise coverage from 63% to at least 80%. Mock external calls (ollama, subprocess, filesystem).

**Kimi instructions:** Add unit tests for `src/timmy/tools.py` (currently at 63.4% coverage, 445 stmts / 163 missed). **Files to modify:** - `tests/timmy/test_tools.py` (create or extend) **What to test:** 1. `ToolRegistry` class — register, lookup, list tools 2. `create_tools_for_agent()` — tool creation with different personas 3. `execute_tool()` — tool execution, error handling, timeout 4. Individual tool functions: `web_search_tool`, `shell_tool`, `file_read_tool`, `file_write_tool`, `python_tool` 5. Edge cases: unknown tool names, invalid arguments, permission denied **Key missed lines:** 248-273, 321-348, 356-412, 448-464, 501-519, 540-642, 687-732, 900-966 **How to verify:** ``` tox -e unit -- tests/timmy/test_tools.py -v ``` Target: raise coverage from 63% to at least 80%. Mock external calls (ollama, subprocess, filesystem).
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
222-epic
Workshop: Timmy as Presence (Epic #222)
 actionable
Has a concrete code/config task extracted
 assigned-claude
Issue currently assigned to Claude agent — do not assign to another agent
 assigned-gemini
Issue currently assigned to Gemini agent — do not assign to another agent
 assigned-groq
assigned-kimi
Issue currently assigned to Kimi agent — do not assign to another agent
 assigned-manus
Issue currently assigned to Manus agent — do not assign to another agent
 claude-ready
consolidation
Part of a consolidation epic
 deprioritized
Keep open but not blocking P0 work
 deprioritized
Keep open but not blocking P0 work
 duplicate
Duplicate of another issue
 gemini-review
Auto-generated by Gemini, needs relevance review
 groq-ready
harness
Core product: agent framework, heartbeat, inference, memory
 heartbeat
Harness: Agent heartbeat loop
 inference
Harness: Inference and model routing
 infrastructure
Supporting stage: dashboard, CI/CD, deployment, DNS
 kimi-ready
Scoped and ready for Kimi to pick up
 memory-session
Harness: Memory and session crystallization
 morrowind
Harness: Morrowind embodiment
 needs-design
Needs architectural design before implementation
 needs-extraction
Philosophy with unextracted engineering work
 p0-critical
Priority 0: Must fix now
 p1-important
Priority 1: Important, next sprint
 p2-backlog
Priority 2: Backlog, do when time permits
 philosophy
Philosophical foundation — informs architecture decisions
 rejected-direction
Closed: rejected or superseded direction
 seed:know-purpose
Three Seeds: KNOW YOUR PURPOSE
 seed:serve-real
Three Seeds: SERVE THE REAL
 seed:tell-truth
Three Seeds: TELL THE TRUTH
 sovereignty
Harness: Sovereignty stack
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Timmy claude grok groq kimi manus perplexity Rockachopa
No Assignees kimi
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Rockachopa/Timmy-time-dashboard#346
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?