Rockachopa/Timmy-time-dashboard
1
0
Fork 2
Code Issues 7 Pull Requests Actions Packages Projects Releases Wiki Activity

[loop-generated] [test] Add unit tests for agents/loader.py — 249 lines of untested agent factory code #347

New Issue
Closed
opened 2026-03-19 00:54:28 +00:00 by hermes · 2 comments
hermes commented 2026-03-19 00:54:28 +00:00
Collaborator
Copy Link

Problem

src/timmy/agents/loader.py is 249 lines with ZERO test coverage. It's the YAML-driven agent factory — core to config-over-code architecture.

Key functions to test

  • _find_config_path() — locates agents.yaml
  • _load_config() — loads and caches YAML
  • load_agents() — builds agent instances from config
  • get_agent() — single agent lookup
  • list_agents() — all agent IDs
  • get_routing_config() — routing patterns
  • route_request() — pattern-based routing

Acceptance criteria

  • Create tests/timmy/test_agent_loader.py
  • Cover all 7 public functions
  • Test config caching behavior
  • Test missing config error handling
  • Test routing pattern matching
  • Use tmp_path for config files, mock settings.repo_root
  • Target: 12+ test cases

Files

  • Source: src/timmy/agents/loader.py
  • Test: tests/timmy/test_agent_loader.py (create new)
## Problem `src/timmy/agents/loader.py` is 249 lines with ZERO test coverage. It's the YAML-driven agent factory — core to config-over-code architecture. ## Key functions to test - `_find_config_path()` — locates agents.yaml - `_load_config()` — loads and caches YAML - `load_agents()` — builds agent instances from config - `get_agent()` — single agent lookup - `list_agents()` — all agent IDs - `get_routing_config()` — routing patterns - `route_request()` — pattern-based routing ## Acceptance criteria - Create `tests/timmy/test_agent_loader.py` - Cover all 7 public functions - Test config caching behavior - Test missing config error handling - Test routing pattern matching - Use `tmp_path` for config files, mock `settings.repo_root` - Target: 12+ test cases ## Files - Source: `src/timmy/agents/loader.py` - Test: `tests/timmy/test_agent_loader.py` (create new)
hermes commented 2026-03-19 01:03:22 +00:00
Author
Collaborator
Copy Link

Instructions for Kimi

Create tests/timmy/test_loader.py with unit tests for src/timmy/agents/loader.py.

Source to read first

  • src/timmy/agents/loader.py (249 lines)
  • src/timmy/agents/base.py (254 lines) — the base class that loader instantiates

Key things to test

  1. AgentLoader.__init__ — config parsing, default values
  2. AgentLoader.load_agent() — agent instantiation with different config combinations
  3. AgentLoader.load_all_agents() — loading multiple agents from config
  4. Error handling — missing config keys, invalid agent types, import failures
  5. Config merging/override logic if present

Mocking patterns

  • Mock importlib or any dynamic imports the loader uses
  • Mock file I/O for config loading
  • Use unittest.mock.patch for external dependencies
  • Follow patterns from existing tests in tests/timmy/

Verification

tox -e unit

All existing tests must still pass. New tests should add at least 15 test cases.

## Instructions for Kimi Create `tests/timmy/test_loader.py` with unit tests for `src/timmy/agents/loader.py`. ### Source to read first - `src/timmy/agents/loader.py` (249 lines) - `src/timmy/agents/base.py` (254 lines) — the base class that loader instantiates ### Key things to test 1. `AgentLoader.__init__` — config parsing, default values 2. `AgentLoader.load_agent()` — agent instantiation with different config combinations 3. `AgentLoader.load_all_agents()` — loading multiple agents from config 4. Error handling — missing config keys, invalid agent types, import failures 5. Config merging/override logic if present ### Mocking patterns - Mock `importlib` or any dynamic imports the loader uses - Mock file I/O for config loading - Use `unittest.mock.patch` for external dependencies - Follow patterns from existing tests in `tests/timmy/` ### Verification ``` tox -e unit ``` All existing tests must still pass. New tests should add at least 15 test cases.
kimi was assigned by hermes 2026-03-19 01:03:22 +00:00
hermes commented 2026-03-19 01:26:29 +00:00
Author
Collaborator
Copy Link

Closing — src/timmy/agents/loader.py is already at 100% coverage (112 stmts, 0 missed) per the latest CI run. The existing tests in tests/timmy/agents/test_loader.py fully cover the module including routing, config loading, prompt building, and model resolution.

Closing — `src/timmy/agents/loader.py` is already at **100% coverage** (112 stmts, 0 missed) per the latest CI run. The existing tests in `tests/timmy/agents/test_loader.py` fully cover the module including routing, config loading, prompt building, and model resolution.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
222-epic
Workshop: Timmy as Presence (Epic #222)
 actionable
Has a concrete code/config task extracted
 assigned-claude
Issue currently assigned to Claude agent — do not assign to another agent
 assigned-gemini
Issue currently assigned to Gemini agent — do not assign to another agent
 assigned-groq
assigned-kimi
Issue currently assigned to Kimi agent — do not assign to another agent
 assigned-manus
Issue currently assigned to Manus agent — do not assign to another agent
 claude-ready
consolidation
Part of a consolidation epic
 deprioritized
Keep open but not blocking P0 work
 deprioritized
Keep open but not blocking P0 work
 duplicate
Duplicate of another issue
 gemini-review
Auto-generated by Gemini, needs relevance review
 groq-ready
harness
Core product: agent framework, heartbeat, inference, memory
 heartbeat
Harness: Agent heartbeat loop
 inference
Harness: Inference and model routing
 infrastructure
Supporting stage: dashboard, CI/CD, deployment, DNS
 kimi-ready
Scoped and ready for Kimi to pick up
 memory-session
Harness: Memory and session crystallization
 morrowind
Harness: Morrowind embodiment
 needs-design
Needs architectural design before implementation
 needs-extraction
Philosophy with unextracted engineering work
 p0-critical
Priority 0: Must fix now
 p1-important
Priority 1: Important, next sprint
 p2-backlog
Priority 2: Backlog, do when time permits
 philosophy
Philosophical foundation — informs architecture decisions
 rejected-direction
Closed: rejected or superseded direction
 seed:know-purpose
Three Seeds: KNOW YOUR PURPOSE
 seed:serve-real
Three Seeds: SERVE THE REAL
 seed:tell-truth
Three Seeds: TELL THE TRUTH
 sovereignty
Harness: Sovereignty stack
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Timmy claude grok groq kimi manus perplexity Rockachopa
No Assignees kimi
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Rockachopa/Timmy-time-dashboard#347
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?