Rockachopa/Timmy-time-dashboard
1
0
Fork 2
Code Issues 7 Pull Requests Actions Packages Projects Releases Wiki Activity

[loop-generated] [test] Add unit tests for memory/unified.py — 201 lines at 36% coverage #351

New Issue
Closed
opened 2026-03-19 01:10:25 +00:00 by hermes · 2 comments
hermes commented 2026-03-19 01:10:25 +00:00
Collaborator
Copy Link

Problem

src/timmy/memory/unified.py has 201 lines and only 36.4% test coverage (56 lines missed). It handles unified memory access — a critical path for Timmy's memory system.

What to test

  • Initialization and config loading
  • Memory read/write operations
  • Query and search functionality
  • Error handling for missing/corrupted data
  • Integration with the broader memory system

Source files

  • src/timmy/memory/unified.py (201 lines)
  • Reference: tests/timmy/test_memory_system.py for patterns

Verification

tox -e unit

All existing 1744 tests must pass. Target: 15+ new tests, coverage above 80%.

## Problem `src/timmy/memory/unified.py` has 201 lines and only 36.4% test coverage (56 lines missed). It handles unified memory access — a critical path for Timmy's memory system. ## What to test - Initialization and config loading - Memory read/write operations - Query and search functionality - Error handling for missing/corrupted data - Integration with the broader memory system ## Source files - `src/timmy/memory/unified.py` (201 lines) - Reference: `tests/timmy/test_memory_system.py` for patterns ## Verification ``` tox -e unit ``` All existing 1744 tests must pass. Target: 15+ new tests, coverage above 80%.
hermes commented 2026-03-19 01:22:37 +00:00
Author
Collaborator
Copy Link

Obsolete: memory/unified.py belongs to old codebase being retired in Claude Code pivot.

Obsolete: memory/unified.py belongs to old codebase being retired in Claude Code pivot.
hermes commented 2026-03-19 01:26:09 +00:00
Author
Collaborator
Copy Link

Kimi instructions:

Add unit tests for src/timmy/memory/unified.py (currently at 36.4% coverage, 88 stmts / 56 missed).

Files to modify:

  • tests/timmy/test_memory_system.py (add tests for UnifiedMemory)

What to test:

  1. UnifiedMemory.__init__() — initialization with config
  2. store() — storing memories with different types
  3. search() — searching across tiers (hot, vault, semantic)
  4. get_context() — context assembly for queries
  5. forget() — memory deletion
  6. Integration between tiers

Key missed lines: 27-33, 38-67, 78-155, 160-161

How to verify:

tox -e unit -- tests/timmy/test_memory_system.py -v

Target: raise coverage from 36% to at least 75%. Mock database and embedding calls.

**Kimi instructions:** Add unit tests for `src/timmy/memory/unified.py` (currently at 36.4% coverage, 88 stmts / 56 missed). **Files to modify:** - `tests/timmy/test_memory_system.py` (add tests for UnifiedMemory) **What to test:** 1. `UnifiedMemory.__init__()` — initialization with config 2. `store()` — storing memories with different types 3. `search()` — searching across tiers (hot, vault, semantic) 4. `get_context()` — context assembly for queries 5. `forget()` — memory deletion 6. Integration between tiers **Key missed lines:** 27-33, 38-67, 78-155, 160-161 **How to verify:** ``` tox -e unit -- tests/timmy/test_memory_system.py -v ``` Target: raise coverage from 36% to at least 75%. Mock database and embedding calls.
kimi was assigned by hermes 2026-03-19 01:26:10 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
222-epic
Workshop: Timmy as Presence (Epic #222)
 actionable
Has a concrete code/config task extracted
 assigned-claude
Issue currently assigned to Claude agent — do not assign to another agent
 assigned-gemini
Issue currently assigned to Gemini agent — do not assign to another agent
 assigned-groq
assigned-kimi
Issue currently assigned to Kimi agent — do not assign to another agent
 assigned-manus
Issue currently assigned to Manus agent — do not assign to another agent
 claude-ready
consolidation
Part of a consolidation epic
 deprioritized
Keep open but not blocking P0 work
 deprioritized
Keep open but not blocking P0 work
 duplicate
Duplicate of another issue
 gemini-review
Auto-generated by Gemini, needs relevance review
 groq-ready
harness
Core product: agent framework, heartbeat, inference, memory
 heartbeat
Harness: Agent heartbeat loop
 inference
Harness: Inference and model routing
 infrastructure
Supporting stage: dashboard, CI/CD, deployment, DNS
 kimi-ready
Scoped and ready for Kimi to pick up
 memory-session
Harness: Memory and session crystallization
 morrowind
Harness: Morrowind embodiment
 needs-design
Needs architectural design before implementation
 needs-extraction
Philosophy with unextracted engineering work
 p0-critical
Priority 0: Must fix now
 p1-important
Priority 1: Important, next sprint
 p2-backlog
Priority 2: Backlog, do when time permits
 philosophy
Philosophical foundation — informs architecture decisions
 rejected-direction
Closed: rejected or superseded direction
 seed:know-purpose
Three Seeds: KNOW YOUR PURPOSE
 seed:serve-real
Three Seeds: SERVE THE REAL
 seed:tell-truth
Three Seeds: TELL THE TRUTH
 sovereignty
Harness: Sovereignty stack
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Timmy claude grok groq kimi manus perplexity Rockachopa
No Assignees kimi
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Rockachopa/Timmy-time-dashboard#351
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?