Rockachopa/Timmy-time-dashboard
1
0
Fork 2
Code Issues 7 Pull Requests Actions Packages Projects Releases Wiki Activity

[loop-generated] [refactor] DRY violation — confidence visibility code repeated 3x in session.py #369

New Issue
Closed
opened 2026-03-19 01:56:33 +00:00 by hermes · 0 comments
hermes commented 2026-03-19 01:56:33 +00:00
Collaborator
Copy Link

What

src/timmy/session.py has the same confidence visibility logic duplicated in 3 places:

  • Lines 116-118 (process_message)
  • Lines 162-164 (agentic path)
  • Lines 208-210 (fallback path)
if confidence is not None and confidence < 0.7:
    response_text += f'\n\n[confidence: {confidence:.0%}]'

Fix

Extract to a helper function _annotate_confidence(text, confidence, threshold=0.7) -> str and call it in all three places. 3 lines changed, 0 new behavior.

Files

  • src/timmy/session.py (modify)
  • tests/timmy/test_session.py (add test for helper)

Acceptance

  • No code duplication of confidence annotation
  • All existing tests pass
  • New unit test for the helper function
## What `src/timmy/session.py` has the same confidence visibility logic duplicated in 3 places: - Lines 116-118 (`process_message`) - Lines 162-164 (agentic path) - Lines 208-210 (fallback path) ```python if confidence is not None and confidence < 0.7: response_text += f'\n\n[confidence: {confidence:.0%}]' ``` ## Fix Extract to a helper function `_annotate_confidence(text, confidence, threshold=0.7) -> str` and call it in all three places. 3 lines changed, 0 new behavior. ## Files - `src/timmy/session.py` (modify) - `tests/timmy/test_session.py` (add test for helper) ## Acceptance - [ ] No code duplication of confidence annotation - [ ] All existing tests pass - [ ] New unit test for the helper function
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
222-epic
Workshop: Timmy as Presence (Epic #222)
 actionable
Has a concrete code/config task extracted
 assigned-claude
Issue currently assigned to Claude agent — do not assign to another agent
 assigned-gemini
Issue currently assigned to Gemini agent — do not assign to another agent
 assigned-groq
assigned-kimi
Issue currently assigned to Kimi agent — do not assign to another agent
 assigned-manus
Issue currently assigned to Manus agent — do not assign to another agent
 claude-ready
consolidation
Part of a consolidation epic
 deprioritized
Keep open but not blocking P0 work
 deprioritized
Keep open but not blocking P0 work
 duplicate
Duplicate of another issue
 gemini-review
Auto-generated by Gemini, needs relevance review
 groq-ready
harness
Core product: agent framework, heartbeat, inference, memory
 heartbeat
Harness: Agent heartbeat loop
 inference
Harness: Inference and model routing
 infrastructure
Supporting stage: dashboard, CI/CD, deployment, DNS
 kimi-ready
Scoped and ready for Kimi to pick up
 memory-session
Harness: Memory and session crystallization
 morrowind
Harness: Morrowind embodiment
 needs-design
Needs architectural design before implementation
 needs-extraction
Philosophy with unextracted engineering work
 p0-critical
Priority 0: Must fix now
 p1-important
Priority 1: Important, next sprint
 p2-backlog
Priority 2: Backlog, do when time permits
 philosophy
Philosophical foundation — informs architecture decisions
 rejected-direction
Closed: rejected or superseded direction
 seed:know-purpose
Three Seeds: KNOW YOUR PURPOSE
 seed:serve-real
Three Seeds: SERVE THE REAL
 seed:tell-truth
Three Seeds: TELL THE TRUTH
 sovereignty
Harness: Sovereignty stack
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Timmy claude grok groq kimi manus perplexity Rockachopa
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Rockachopa/Timmy-time-dashboard#369
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?