Rockachopa/Timmy-time-dashboard
1
0
Fork 2
Code Issues 7 Pull Requests Actions Packages Projects Releases Wiki Activity

[loop-generated] [refactor] DRY violation: PRESENCE_FILE path defined in 3 files #381

New Issue
Closed
opened 2026-03-19 02:25:24 +00:00 by hermes · 0 comments
hermes commented 2026-03-19 02:25:24 +00:00
Collaborator
Copy Link

What

The path ~/.timmy/presence.json is defined as a module-level constant in 3 separate files:

  1. src/timmy/workshop_state.py:19 — PRESENCE_FILE
  2. src/dashboard/app.py:193 — _PRESENCE_FILE
  3. src/dashboard/routes/world.py:26 — _PRESENCE_FILE

Why it matters

If the path ever changes (e.g. moving from ~/.timmy/ to ~/.tower/), 3 files need updating. Classic shotgun surgery.

Fix

Import PRESENCE_FILE from timmy.workshop_state in the two consumer files instead of redefining it.

Files to change

  • src/dashboard/app.py — replace _PRESENCE_FILE with import from workshop_state
  • src/dashboard/routes/world.py — replace _PRESENCE_FILE with import from workshop_state

Scope

3 lines changed, 2 lines deleted. Tiny refactor.

## What The path `~/.timmy/presence.json` is defined as a module-level constant in 3 separate files: 1. `src/timmy/workshop_state.py:19` — `PRESENCE_FILE` 2. `src/dashboard/app.py:193` — `_PRESENCE_FILE` 3. `src/dashboard/routes/world.py:26` — `_PRESENCE_FILE` ## Why it matters If the path ever changes (e.g. moving from `~/.timmy/` to `~/.tower/`), 3 files need updating. Classic shotgun surgery. ## Fix Import `PRESENCE_FILE` from `timmy.workshop_state` in the two consumer files instead of redefining it. ## Files to change - `src/dashboard/app.py` — replace `_PRESENCE_FILE` with import from `workshop_state` - `src/dashboard/routes/world.py` — replace `_PRESENCE_FILE` with import from `workshop_state` ## Scope 3 lines changed, 2 lines deleted. Tiny refactor.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
222-epic
Workshop: Timmy as Presence (Epic #222)
 actionable
Has a concrete code/config task extracted
 assigned-claude
Issue currently assigned to Claude agent — do not assign to another agent
 assigned-gemini
Issue currently assigned to Gemini agent — do not assign to another agent
 assigned-groq
assigned-kimi
Issue currently assigned to Kimi agent — do not assign to another agent
 assigned-manus
Issue currently assigned to Manus agent — do not assign to another agent
 claude-ready
consolidation
Part of a consolidation epic
 deprioritized
Keep open but not blocking P0 work
 deprioritized
Keep open but not blocking P0 work
 duplicate
Duplicate of another issue
 gemini-review
Auto-generated by Gemini, needs relevance review
 groq-ready
harness
Core product: agent framework, heartbeat, inference, memory
 heartbeat
Harness: Agent heartbeat loop
 inference
Harness: Inference and model routing
 infrastructure
Supporting stage: dashboard, CI/CD, deployment, DNS
 kimi-ready
Scoped and ready for Kimi to pick up
 memory-session
Harness: Memory and session crystallization
 morrowind
Harness: Morrowind embodiment
 needs-design
Needs architectural design before implementation
 needs-extraction
Philosophy with unextracted engineering work
 p0-critical
Priority 0: Must fix now
 p1-important
Priority 1: Important, next sprint
 p2-backlog
Priority 2: Backlog, do when time permits
 philosophy
Philosophical foundation — informs architecture decisions
 rejected-direction
Closed: rejected or superseded direction
 seed:know-purpose
Three Seeds: KNOW YOUR PURPOSE
 seed:serve-real
Three Seeds: SERVE THE REAL
 seed:tell-truth
Three Seeds: TELL THE TRUTH
 sovereignty
Harness: Sovereignty stack
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Timmy claude grok groq kimi manus perplexity Rockachopa
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Rockachopa/Timmy-time-dashboard#381
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?