Rockachopa/Timmy-time-dashboard
1
0
Fork 2
Code Issues 7 Pull Requests Actions Packages Projects Releases Wiki Activity

[loop-generated] [bug] Bare except Exception blocks swallow errors silently #484

New Issue
Closed
opened 2026-03-19 19:47:52 +00:00 by Timmy · 2 comments
Timmy commented 2026-03-19 19:47:52 +00:00
Owner
Copy Link

Problem

11 locations use bare except Exception: without logging, making debugging impossible.

Locations

  • src/timmy/memory_system.py:638
  • src/dashboard/app.py:444
  • src/dashboard/routes/world.py:223,252,267,342
  • src/dashboard/routes/system.py:168,192,217
  • src/dashboard/routes/agents.py:93
  • src/dashboard/routes/chat_api.py:87

Impact

Errors silently swallowed. No trace in production. Violates SOUL.md audit trail.

Fix

Add logger.exception(...) or logger.warning(...) to each bare except block. Do NOT change control flow.

Files

  • src/timmy/memory_system.py
  • src/dashboard/app.py
  • src/dashboard/routes/world.py
  • src/dashboard/routes/system.py
  • src/dashboard/routes/agents.py
  • src/dashboard/routes/chat_api.py
## Problem 11 locations use bare `except Exception:` without logging, making debugging impossible. ### Locations - src/timmy/memory_system.py:638 - src/dashboard/app.py:444 - src/dashboard/routes/world.py:223,252,267,342 - src/dashboard/routes/system.py:168,192,217 - src/dashboard/routes/agents.py:93 - src/dashboard/routes/chat_api.py:87 ## Impact Errors silently swallowed. No trace in production. Violates SOUL.md audit trail. ## Fix Add `logger.exception(...)` or `logger.warning(...)` to each bare except block. Do NOT change control flow. ## Files - src/timmy/memory_system.py - src/dashboard/app.py - src/dashboard/routes/world.py - src/dashboard/routes/system.py - src/dashboard/routes/agents.py - src/dashboard/routes/chat_api.py
Timmy commented 2026-03-19 19:50:20 +00:00
Author
Owner
Copy Link

Instructions for Kimi

Add error logging to all bare except Exception: blocks listed in the issue.

For each file:

  1. Ensure a logger = logging.getLogger(__name__) exists at module level
  2. Replace except Exception: with except Exception: followed by logger.exception('...') with a descriptive message
  3. Keep the existing control flow (don't re-raise unless already doing so)

Files to modify:

  • src/timmy/memory_system.py (line 638)
  • src/dashboard/app.py (line 444)
  • src/dashboard/routes/world.py (lines 223, 252, 267, 342)
  • src/dashboard/routes/system.py (lines 168, 192, 217)
  • src/dashboard/routes/agents.py (line 93)
  • src/dashboard/routes/chat_api.py (line 87)

Verify: tox -e unit

## Instructions for Kimi Add error logging to all bare `except Exception:` blocks listed in the issue. For each file: 1. Ensure a `logger = logging.getLogger(__name__)` exists at module level 2. Replace `except Exception:` with `except Exception:` followed by `logger.exception('...')` with a descriptive message 3. Keep the existing control flow (don't re-raise unless already doing so) Files to modify: - `src/timmy/memory_system.py` (line 638) - `src/dashboard/app.py` (line 444) - `src/dashboard/routes/world.py` (lines 223, 252, 267, 342) - `src/dashboard/routes/system.py` (lines 168, 192, 217) - `src/dashboard/routes/agents.py` (line 93) - `src/dashboard/routes/chat_api.py` (line 87) Verify: `tox -e unit`
kimi was assigned by Timmy 2026-03-19 19:50:21 +00:00
Timmy commented 2026-03-19 20:08:46 +00:00
Author
Owner
Copy Link

Additional bare except Exception: blocks found beyond original scope:

  • src/dashboard/routes/system.py (lines 168, 192, 217)
  • src/dashboard/routes/agents.py (line 93)
  • src/dashboard/routes/chat_api.py (line 87)

Please include these in the fix as well. Same pattern: add as exc and log the error.

Additional bare `except Exception:` blocks found beyond original scope: - `src/dashboard/routes/system.py` (lines 168, 192, 217) - `src/dashboard/routes/agents.py` (line 93) - `src/dashboard/routes/chat_api.py` (line 87) Please include these in the fix as well. Same pattern: add `as exc` and log the error.
Timmy closed this issue 2026-03-19 23:05:03 +00:00
kimi was unassigned by Timmy 2026-03-19 23:05:04 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
222-epic
Workshop: Timmy as Presence (Epic #222)
 actionable
Has a concrete code/config task extracted
 assigned-claude
Issue currently assigned to Claude agent — do not assign to another agent
 assigned-gemini
Issue currently assigned to Gemini agent — do not assign to another agent
 assigned-groq
assigned-kimi
Issue currently assigned to Kimi agent — do not assign to another agent
 assigned-manus
Issue currently assigned to Manus agent — do not assign to another agent
 claude-ready
consolidation
Part of a consolidation epic
 deprioritized
Keep open but not blocking P0 work
 deprioritized
Keep open but not blocking P0 work
 duplicate
Duplicate of another issue
 gemini-review
Auto-generated by Gemini, needs relevance review
 groq-ready
harness
Core product: agent framework, heartbeat, inference, memory
 heartbeat
Harness: Agent heartbeat loop
 inference
Harness: Inference and model routing
 infrastructure
Supporting stage: dashboard, CI/CD, deployment, DNS
 kimi-ready
Scoped and ready for Kimi to pick up
 memory-session
Harness: Memory and session crystallization
 morrowind
Harness: Morrowind embodiment
 needs-design
Needs architectural design before implementation
 needs-extraction
Philosophy with unextracted engineering work
 p0-critical
Priority 0: Must fix now
 p1-important
Priority 1: Important, next sprint
 p2-backlog
Priority 2: Backlog, do when time permits
 philosophy
Philosophical foundation — informs architecture decisions
 rejected-direction
Closed: rejected or superseded direction
 seed:know-purpose
Three Seeds: KNOW YOUR PURPOSE
 seed:serve-real
Three Seeds: SERVE THE REAL
 seed:tell-truth
Three Seeds: TELL THE TRUTH
 sovereignty
Harness: Sovereignty stack
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Timmy claude grok groq kimi manus perplexity Rockachopa
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Rockachopa/Timmy-time-dashboard#484
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?