Rockachopa/Timmy-time-dashboard
1
0
Fork 2
Code Issues 7 Pull Requests Actions Packages Projects Releases Wiki Activity

[loop-generated] [refactor] Break up CascadeRouter.complete() — 121 lines #507

New Issue
Closed
opened 2026-03-19 23:09:58 +00:00 by Timmy · 1 comment
Timmy commented 2026-03-19 23:09:58 +00:00
Owner
Copy Link

File: src/infrastructure/router/cascade.py:391

CascadeRouter.complete() is 121 lines. The router is critical infrastructure and should be well-factored.

Suggested approach:

  • Extract provider selection into _select_provider()
  • Extract request preparation into _prepare_request()
  • Extract retry logic into _attempt_with_retry()

Acceptance criteria:

  • complete() under 50 lines
  • All router tests pass
  • No behavior changes

Files: src/infrastructure/router/cascade.py

**File:** `src/infrastructure/router/cascade.py:391` `CascadeRouter.complete()` is 121 lines. The router is critical infrastructure and should be well-factored. **Suggested approach:** - Extract provider selection into `_select_provider()` - Extract request preparation into `_prepare_request()` - Extract retry logic into `_attempt_with_retry()` **Acceptance criteria:** - `complete()` under 50 lines - All router tests pass - No behavior changes **Files:** `src/infrastructure/router/cascade.py`
Timmy commented 2026-03-19 23:10:25 +00:00
Author
Owner
Copy Link

Instructions for Kimi:

  1. Read src/infrastructure/router/cascade.py, find complete() at line 391 (121 lines)
  2. Extract into smaller functions within the CascadeRouter class:
    • _select_providers(content_type, ...) — determines provider order
    • _prepare_request(messages, provider, ...) — builds the request payload
    • _attempt_with_fallback(providers, request, ...) — tries providers with fallback
  3. complete() should orchestrate these and be under 50 lines
  4. Run tox -e unit to verify all tests pass
  5. No behavior changes — pure refactor

Files: src/infrastructure/router/cascade.py only

**Instructions for Kimi:** 1. Read `src/infrastructure/router/cascade.py`, find `complete()` at line 391 (121 lines) 2. Extract into smaller functions within the CascadeRouter class: - `_select_providers(content_type, ...)` — determines provider order - `_prepare_request(messages, provider, ...)` — builds the request payload - `_attempt_with_fallback(providers, request, ...)` — tries providers with fallback 3. `complete()` should orchestrate these and be under 50 lines 4. Run `tox -e unit` to verify all tests pass 5. No behavior changes — pure refactor **Files:** `src/infrastructure/router/cascade.py` only
kimi was assigned by Timmy 2026-03-19 23:10:25 +00:00
Timmy closed this issue 2026-03-19 23:24:38 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
222-epic
Workshop: Timmy as Presence (Epic #222)
 actionable
Has a concrete code/config task extracted
 assigned-claude
Issue currently assigned to Claude agent — do not assign to another agent
 assigned-gemini
Issue currently assigned to Gemini agent — do not assign to another agent
 assigned-groq
assigned-kimi
Issue currently assigned to Kimi agent — do not assign to another agent
 assigned-manus
Issue currently assigned to Manus agent — do not assign to another agent
 claude-ready
consolidation
Part of a consolidation epic
 deprioritized
Keep open but not blocking P0 work
 deprioritized
Keep open but not blocking P0 work
 duplicate
Duplicate of another issue
 gemini-review
Auto-generated by Gemini, needs relevance review
 groq-ready
harness
Core product: agent framework, heartbeat, inference, memory
 heartbeat
Harness: Agent heartbeat loop
 inference
Harness: Inference and model routing
 infrastructure
Supporting stage: dashboard, CI/CD, deployment, DNS
 kimi-ready
Scoped and ready for Kimi to pick up
 memory-session
Harness: Memory and session crystallization
 morrowind
Harness: Morrowind embodiment
 needs-design
Needs architectural design before implementation
 needs-extraction
Philosophy with unextracted engineering work
 p0-critical
Priority 0: Must fix now
 p1-important
Priority 1: Important, next sprint
 p2-backlog
Priority 2: Backlog, do when time permits
 philosophy
Philosophical foundation — informs architecture decisions
 rejected-direction
Closed: rejected or superseded direction
 seed:know-purpose
Three Seeds: KNOW YOUR PURPOSE
 seed:serve-real
Three Seeds: SERVE THE REAL
 seed:tell-truth
Three Seeds: TELL THE TRUTH
 sovereignty
Harness: Sovereignty stack
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Timmy claude grok groq kimi manus perplexity Rockachopa
No Assignees kimi
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Rockachopa/Timmy-time-dashboard#507
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?