Rockachopa/Timmy-time-dashboard
1
0
Fork 2
Code Issues 7 Pull Requests Actions Packages Projects Releases Wiki Activity

[MEDIUM] eval() in tools.py should use safer math evaluation #52

New Issue
Closed
opened 2026-03-14 18:47:33 +00:00 by kimi · 0 comments
kimi commented 2026-03-14 18:47:33 +00:00
Collaborator
Copy Link

Problem

src/timmy/tools.py:139 uses eval() for calculator tool:

result = eval(expression, {"__builtins__": {}}, allowed_names)

While sandboxed, eval() is still dangerous.

Impact

  • Potential security risk if sandbox is bypassed
  • Code smell - eval() is generally discouraged

Recommendation

Use a dedicated math parser like numexpr or asteval.

Acceptance Criteria

  • Replace eval() with numexpr or ast.literal_eval
  • Maintain all current math functions
  • Add tests for edge cases
  • Verify no performance regression

Priority: MEDIUM

## Problem `src/timmy/tools.py:139` uses eval() for calculator tool: ```python result = eval(expression, {"__builtins__": {}}, allowed_names) ``` While sandboxed, eval() is still dangerous. ## Impact - Potential security risk if sandbox is bypassed - Code smell - eval() is generally discouraged ## Recommendation Use a dedicated math parser like `numexpr` or `asteval`. ## Acceptance Criteria - [ ] Replace eval() with numexpr or ast.literal_eval - [ ] Maintain all current math functions - [ ] Add tests for edge cases - [ ] Verify no performance regression ## Priority: MEDIUM
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
222-epic
Workshop: Timmy as Presence (Epic #222)
 actionable
Has a concrete code/config task extracted
 assigned-claude
Issue currently assigned to Claude agent — do not assign to another agent
 assigned-gemini
Issue currently assigned to Gemini agent — do not assign to another agent
 assigned-groq
assigned-kimi
Issue currently assigned to Kimi agent — do not assign to another agent
 assigned-manus
Issue currently assigned to Manus agent — do not assign to another agent
 claude-ready
consolidation
Part of a consolidation epic
 deprioritized
Keep open but not blocking P0 work
 deprioritized
Keep open but not blocking P0 work
 duplicate
Duplicate of another issue
 gemini-review
Auto-generated by Gemini, needs relevance review
 groq-ready
harness
Core product: agent framework, heartbeat, inference, memory
 heartbeat
Harness: Agent heartbeat loop
 inference
Harness: Inference and model routing
 infrastructure
Supporting stage: dashboard, CI/CD, deployment, DNS
 kimi-ready
Scoped and ready for Kimi to pick up
 memory-session
Harness: Memory and session crystallization
 morrowind
Harness: Morrowind embodiment
 needs-design
Needs architectural design before implementation
 needs-extraction
Philosophy with unextracted engineering work
 p0-critical
Priority 0: Must fix now
 p1-important
Priority 1: Important, next sprint
 p2-backlog
Priority 2: Backlog, do when time permits
 philosophy
Philosophical foundation — informs architecture decisions
 rejected-direction
Closed: rejected or superseded direction
 seed:know-purpose
Three Seeds: KNOW YOUR PURPOSE
 seed:serve-real
Three Seeds: SERVE THE REAL
 seed:tell-truth
Three Seeds: TELL THE TRUTH
 sovereignty
Harness: Sovereignty stack
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Timmy claude grok groq kimi manus perplexity Rockachopa
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Rockachopa/Timmy-time-dashboard#52
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?