Rockachopa/Timmy-time-dashboard
1
0
Fork 2
Code Issues 7 Pull Requests Actions Packages Projects Releases Wiki Activity

[loop-generated] [refactor] Break up _handle_tool_confirmation() — 74 lines in cli.py #592

New Issue
Closed
opened 2026-03-20 16:05:01 +00:00 by Timmy · 0 comments
Timmy commented 2026-03-20 16:05:01 +00:00
Owner
Copy Link

Problem

_handle_tool_confirmation() in src/timmy/cli.py is 74 lines handling tool call display and user confirmation.

Proposed Fix

Extract into helpers:

  • _format_tool_call(call) — format a single tool call for display
  • _prompt_user_confirmation(calls) — handle the interactive Y/N flow

Files

  • src/timmy/cli.py

Acceptance

  • Each helper < 30 lines
  • tox -e unit passes
  • No net increase in LOC
## Problem `_handle_tool_confirmation()` in `src/timmy/cli.py` is 74 lines handling tool call display and user confirmation. ## Proposed Fix Extract into helpers: - `_format_tool_call(call)` — format a single tool call for display - `_prompt_user_confirmation(calls)` — handle the interactive Y/N flow ## Files - `src/timmy/cli.py` ## Acceptance - Each helper < 30 lines - `tox -e unit` passes - No net increase in LOC
Timmy self-assigned this 2026-03-20 16:23:12 +00:00
Timmy closed this issue 2026-03-20 16:32:26 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
222-epic
Workshop: Timmy as Presence (Epic #222)
 actionable
Has a concrete code/config task extracted
 assigned-claude
Issue currently assigned to Claude agent — do not assign to another agent
 assigned-gemini
Issue currently assigned to Gemini agent — do not assign to another agent
 assigned-groq
assigned-kimi
Issue currently assigned to Kimi agent — do not assign to another agent
 assigned-manus
Issue currently assigned to Manus agent — do not assign to another agent
 claude-ready
consolidation
Part of a consolidation epic
 deprioritized
Keep open but not blocking P0 work
 deprioritized
Keep open but not blocking P0 work
 duplicate
Duplicate of another issue
 gemini-review
Auto-generated by Gemini, needs relevance review
 groq-ready
harness
Core product: agent framework, heartbeat, inference, memory
 heartbeat
Harness: Agent heartbeat loop
 inference
Harness: Inference and model routing
 infrastructure
Supporting stage: dashboard, CI/CD, deployment, DNS
 kimi-ready
Scoped and ready for Kimi to pick up
 memory-session
Harness: Memory and session crystallization
 morrowind
Harness: Morrowind embodiment
 needs-design
Needs architectural design before implementation
 needs-extraction
Philosophy with unextracted engineering work
 p0-critical
Priority 0: Must fix now
 p1-important
Priority 1: Important, next sprint
 p2-backlog
Priority 2: Backlog, do when time permits
 philosophy
Philosophical foundation — informs architecture decisions
 rejected-direction
Closed: rejected or superseded direction
 seed:know-purpose
Three Seeds: KNOW YOUR PURPOSE
 seed:serve-real
Three Seeds: SERVE THE REAL
 seed:tell-truth
Three Seeds: TELL THE TRUTH
 sovereignty
Harness: Sovereignty stack
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Timmy claude grok kimi manus perplexity Rockachopa
No Assignees Timmy
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Rockachopa/Timmy-time-dashboard#592
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?