Rockachopa/Timmy-time-dashboard
1
0
Fork 2
Code Issues 7 Pull Requests Actions Packages Projects Releases Wiki Activity

[loop-generated] [bug] Lint errors on main block all commits — F821 in mcp_tools.py #598

New Issue
Closed
opened 2026-03-20 16:25:19 +00:00 by Timmy · 1 comment
Timmy commented 2026-03-20 16:25:19 +00:00
Owner
Copy Link

Bug: Pre-commit hook fails on main due to lint errors in mcp_tools.py

Problem

The pre-commit hook runs tox -e format which includes ruff check across all of src/. There are 3 F821 (undefined name) errors in src/timmy/mcp_tools.py that were introduced by the #563 refactor merge:

F821 Undefined name `ImageDraw` --> src/timmy/mcp_tools.py:317:23

These errors block ALL commits on ANY branch because the hook checks the entire src/ directory, not just staged files.

Impact

  • Critical: No new commits can land until this is fixed
  • All active development is blocked

Fix

Add the missing ImageDraw import to src/timmy/mcp_tools.py, or add the appropriate from PIL import ImageDraw where needed.

Files

  • src/timmy/mcp_tools.py
## Bug: Pre-commit hook fails on main due to lint errors in mcp_tools.py ### Problem The pre-commit hook runs `tox -e format` which includes `ruff check` across all of `src/`. There are 3 F821 (undefined name) errors in `src/timmy/mcp_tools.py` that were introduced by the #563 refactor merge: ``` F821 Undefined name `ImageDraw` --> src/timmy/mcp_tools.py:317:23 ``` These errors block ALL commits on ANY branch because the hook checks the entire `src/` directory, not just staged files. ### Impact - **Critical**: No new commits can land until this is fixed - All active development is blocked ### Fix Add the missing `ImageDraw` import to `src/timmy/mcp_tools.py`, or add the appropriate `from PIL import ImageDraw` where needed. ### Files - `src/timmy/mcp_tools.py`
Timmy self-assigned this 2026-03-20 16:25:19 +00:00
Timmy commented 2026-03-20 16:28:58 +00:00
Author
Owner
Copy Link

Fixed by PR #597 — Kimi added TYPE_CHECKING import for ImageDraw. Lint passes clean on main now.

Fixed by PR #597 — Kimi added TYPE_CHECKING import for ImageDraw. Lint passes clean on main now.
Timmy closed this issue 2026-03-20 16:28:58 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
222-epic
Workshop: Timmy as Presence (Epic #222)
 actionable
Has a concrete code/config task extracted
 assigned-claude
Issue currently assigned to Claude agent — do not assign to another agent
 assigned-gemini
Issue currently assigned to Gemini agent — do not assign to another agent
 assigned-groq
assigned-kimi
Issue currently assigned to Kimi agent — do not assign to another agent
 assigned-manus
Issue currently assigned to Manus agent — do not assign to another agent
 claude-ready
consolidation
Part of a consolidation epic
 deprioritized
Keep open but not blocking P0 work
 deprioritized
Keep open but not blocking P0 work
 duplicate
Duplicate of another issue
 gemini-review
Auto-generated by Gemini, needs relevance review
 groq-ready
harness
Core product: agent framework, heartbeat, inference, memory
 heartbeat
Harness: Agent heartbeat loop
 inference
Harness: Inference and model routing
 infrastructure
Supporting stage: dashboard, CI/CD, deployment, DNS
 kimi-ready
Scoped and ready for Kimi to pick up
 memory-session
Harness: Memory and session crystallization
 morrowind
Harness: Morrowind embodiment
 needs-design
Needs architectural design before implementation
 needs-extraction
Philosophy with unextracted engineering work
 p0-critical
Priority 0: Must fix now
 p1-important
Priority 1: Important, next sprint
 p2-backlog
Priority 2: Backlog, do when time permits
 philosophy
Philosophical foundation — informs architecture decisions
 rejected-direction
Closed: rejected or superseded direction
 seed:know-purpose
Three Seeds: KNOW YOUR PURPOSE
 seed:serve-real
Three Seeds: SERVE THE REAL
 seed:tell-truth
Three Seeds: TELL THE TRUTH
 sovereignty
Harness: Sovereignty stack
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Timmy claude grok groq kimi manus perplexity Rockachopa
No Assignees Timmy
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Rockachopa/Timmy-time-dashboard#598
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?