Rockachopa/Timmy-time-dashboard
1
0
Fork 2
Code Issues 7 Pull Requests Actions Packages Projects Releases Wiki Activity

[triage-generated] [bug] [P0] Cycle recorder never reads cycle_result.json — 300+ cycles with null data #603

New Issue
Closed
opened 2026-03-20 16:38:30 +00:00 by Timmy · 1 comment
Timmy commented 2026-03-20 16:38:30 +00:00
Owner
Copy Link

Problem

The cycle recorder has been broken for 300+ cycles (since ~cycle 939). Every cycle records:

  • issue: null
  • type: "unknown"
  • success: false
  • main_green: false
  • tests_passed: 0
  • lines_added: 0

Despite real work happening: PRs merged (#589, #595, #597, #600), issues closed, 2106 tests passing.

Root Cause Analysis

The cycle_result.json file exists and contains valid data (e.g. {"issue": 525, "type": "bug", "pr": 530, "tests_passed": 2114}), but the cycle recorder in the tmux loop wrapper never reads it. The recorder appears to write default empty values instead of reading the result file the agent produces.

Impact

  • 0% recorded success rate makes all metrics meaningless
  • Deep triage cannot identify which issues are failing vs succeeding
  • Insights/recommendations are based on garbage data
  • 3 consecutive deep triages have flagged this same issue

Acceptance Criteria

  • Cycle recorder reads .loop/cycle_result.json after each cycle
  • issue, type, pr, tests_passed fields populated from result file
  • success computed from: issue != null AND (pr merged OR tests pass)
  • main_green computed from actual test run (tox -e py exit code)
  • If cycle_result.json is missing/malformed, record reason: "no result file"
  • After fix, run 5 cycles and verify non-null issue numbers in cycles.jsonl

Files

  • The tmux loop wrapper script (wherever cycles.jsonl is written to)
  • .loop/cycle_result.json (read path)
  • .loop/retro/cycles.jsonl (write path)

Tags

[triage-generated] [bug] [P0]

## Problem The cycle recorder has been broken for 300+ cycles (since ~cycle 939). Every cycle records: - `issue: null` - `type: "unknown"` - `success: false` - `main_green: false` - `tests_passed: 0` - `lines_added: 0` Despite real work happening: PRs merged (#589, #595, #597, #600), issues closed, 2106 tests passing. ## Root Cause Analysis The `cycle_result.json` file exists and contains valid data (e.g. `{"issue": 525, "type": "bug", "pr": 530, "tests_passed": 2114}`), but the cycle recorder in the tmux loop wrapper never reads it. The recorder appears to write default empty values instead of reading the result file the agent produces. ## Impact - 0% recorded success rate makes all metrics meaningless - Deep triage cannot identify which issues are failing vs succeeding - Insights/recommendations are based on garbage data - 3 consecutive deep triages have flagged this same issue ## Acceptance Criteria - [ ] Cycle recorder reads `.loop/cycle_result.json` after each cycle - [ ] `issue`, `type`, `pr`, `tests_passed` fields populated from result file - [ ] `success` computed from: issue != null AND (pr merged OR tests pass) - [ ] `main_green` computed from actual test run (`tox -e py` exit code) - [ ] If cycle_result.json is missing/malformed, record `reason: "no result file"` - [ ] After fix, run 5 cycles and verify non-null issue numbers in cycles.jsonl ## Files - The tmux loop wrapper script (wherever `cycles.jsonl` is written to) - `.loop/cycle_result.json` (read path) - `.loop/retro/cycles.jsonl` (write path) ## Tags [triage-generated] [bug] [P0]
Timmy commented 2026-03-20 16:46:28 +00:00
Author
Owner
Copy Link

Fixed in ~/.hermes/bin/timmy-loop.sh (infrastructure, not repo code).

Root cause: The cycle_result.json file contained hermes fence markers (EOF; __hermes_rc=$?; printf __HERMES_FENCE_a9f7b3__; exit $__hermes_rc) appended after the JSON. json.load() choked on this garbage, the exception was silently swallowed (print(, file=sys.stderr)), and every cycle recorded null data.

Fix:

  1. Read raw text instead of json.load()
  2. Strip everything after the last } before parsing
  3. Log parse errors instead of silencing them

The fix is live — next cycle will record properly.

Fixed in `~/.hermes/bin/timmy-loop.sh` (infrastructure, not repo code). **Root cause:** The `cycle_result.json` file contained hermes fence markers (`EOF; __hermes_rc=$?; printf __HERMES_FENCE_a9f7b3__; exit $__hermes_rc`) appended after the JSON. `json.load()` choked on this garbage, the exception was silently swallowed (`print(, file=sys.stderr)`), and every cycle recorded null data. **Fix:** 1. Read raw text instead of `json.load()` 2. Strip everything after the last `}` before parsing 3. Log parse errors instead of silencing them The fix is live — next cycle will record properly.
Timmy closed this issue 2026-03-20 16:46:29 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
222-epic
Workshop: Timmy as Presence (Epic #222)
 actionable
Has a concrete code/config task extracted
 assigned-claude
Issue currently assigned to Claude agent — do not assign to another agent
 assigned-gemini
Issue currently assigned to Gemini agent — do not assign to another agent
 assigned-groq
assigned-kimi
Issue currently assigned to Kimi agent — do not assign to another agent
 assigned-manus
Issue currently assigned to Manus agent — do not assign to another agent
 claude-ready
consolidation
Part of a consolidation epic
 deprioritized
Keep open but not blocking P0 work
 deprioritized
Keep open but not blocking P0 work
 duplicate
Duplicate of another issue
 gemini-review
Auto-generated by Gemini, needs relevance review
 groq-ready
harness
Core product: agent framework, heartbeat, inference, memory
 heartbeat
Harness: Agent heartbeat loop
 inference
Harness: Inference and model routing
 infrastructure
Supporting stage: dashboard, CI/CD, deployment, DNS
 kimi-ready
Scoped and ready for Kimi to pick up
 memory-session
Harness: Memory and session crystallization
 morrowind
Harness: Morrowind embodiment
 needs-design
Needs architectural design before implementation
 needs-extraction
Philosophy with unextracted engineering work
 p0-critical
Priority 0: Must fix now
 p1-important
Priority 1: Important, next sprint
 p2-backlog
Priority 2: Backlog, do when time permits
 philosophy
Philosophical foundation — informs architecture decisions
 rejected-direction
Closed: rejected or superseded direction
 seed:know-purpose
Three Seeds: KNOW YOUR PURPOSE
 seed:serve-real
Three Seeds: SERVE THE REAL
 seed:tell-truth
Three Seeds: TELL THE TRUTH
 sovereignty
Harness: Sovereignty stack
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Timmy claude grok kimi manus perplexity Rockachopa
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Rockachopa/Timmy-time-dashboard#603
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?