Rockachopa/Timmy-time-dashboard
1
0
Fork 2
Code Issues 7 Pull Requests Actions Packages Projects Releases Wiki Activity

[loop-generated] [bug] Tower route /tower missing tests #614

New Issue
Closed
opened 2026-03-20 20:11:23 +00:00 by Timmy · 2 comments
Timmy commented 2026-03-20 20:11:23 +00:00
Owner
Copy Link

PR #612 added src/dashboard/routes/tower.py with GET /tower and WS /tower/ws endpoints but included zero tests.

Needed:

  • Test GET /tower returns 200 with expected HTML structure
  • Test _spark_snapshot() returns correct dict shape
  • Test WebSocket /tower/ws connects and sends initial snapshot

Files:

  • src/dashboard/routes/tower.py
  • tests/dashboard/test_tower.py (new)

Acceptance: at least 3 tests covering the route, snapshot function, and websocket.

PR #612 added `src/dashboard/routes/tower.py` with GET /tower and WS /tower/ws endpoints but included zero tests. Needed: - Test GET /tower returns 200 with expected HTML structure - Test _spark_snapshot() returns correct dict shape - Test WebSocket /tower/ws connects and sends initial snapshot Files: - `src/dashboard/routes/tower.py` - `tests/dashboard/test_tower.py` (new) Acceptance: at least 3 tests covering the route, snapshot function, and websocket.
kimi was assigned by Timmy 2026-03-20 20:11:36 +00:00
Timmy commented 2026-03-20 20:11:37 +00:00
Author
Owner
Copy Link

Instructions for Kimi

Create tests/dashboard/test_tower.py with tests for the Tower dashboard route.

Files to read:

  • src/dashboard/routes/tower.py — the route under test

Tests needed:

  1. test_tower_page_returns_200 — GET /tower returns 200 with HTML containing "TOWER"
  2. test_spark_snapshot_shape — Call _spark_snapshot() directly, verify it returns dict with keys: type, status, events, predictions, advisories
  3. test_tower_ws_connects — WebSocket /tower/ws accepts connection and sends initial JSON snapshot

Patterns to follow:

Look at tests/dashboard/test_dashboard.py for how to set up the test client with httpx.ASGITransport. Use @pytest.fixture for the async client.

Verification:

tox -e unit -- tests/dashboard/test_tower.py -v
## Instructions for Kimi Create `tests/dashboard/test_tower.py` with tests for the Tower dashboard route. ### Files to read: - `src/dashboard/routes/tower.py` — the route under test ### Tests needed: 1. **test_tower_page_returns_200** — GET /tower returns 200 with HTML containing "TOWER" 2. **test_spark_snapshot_shape** — Call `_spark_snapshot()` directly, verify it returns dict with keys: type, status, events, predictions, advisories 3. **test_tower_ws_connects** — WebSocket /tower/ws accepts connection and sends initial JSON snapshot ### Patterns to follow: Look at `tests/dashboard/test_dashboard.py` for how to set up the test client with `httpx.ASGITransport`. Use `@pytest.fixture` for the async client. ### Verification: ```bash tox -e unit -- tests/dashboard/test_tower.py -v ```
Timmy closed this issue 2026-03-20 20:22:14 +00:00
Timmy commented 2026-03-20 20:27:59 +00:00
Author
Owner
Copy Link

Kimi Instructions

Task: Add comprehensive tests for the Tower route.

Files to modify:

  • tests/dashboard/test_tower.py (create or extend)

Files to reference (read-only):

  • src/dashboard/routes/tower.py — the route being tested

What to test:

  1. GET /tower returns 200 with valid HTML
  2. Test that the template context contains expected data
  3. Test error handling paths if any exist
  4. Use the existing test patterns in tests/dashboard/ for fixtures and client setup

Verify: tox -e unit must pass with the new tests included.

## Kimi Instructions **Task**: Add comprehensive tests for the Tower route. **Files to modify**: - `tests/dashboard/test_tower.py` (create or extend) **Files to reference** (read-only): - `src/dashboard/routes/tower.py` — the route being tested **What to test**: 1. GET /tower returns 200 with valid HTML 2. Test that the template context contains expected data 3. Test error handling paths if any exist 4. Use the existing test patterns in `tests/dashboard/` for fixtures and client setup **Verify**: `tox -e unit` must pass with the new tests included.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
222-epic
Workshop: Timmy as Presence (Epic #222)
 actionable
Has a concrete code/config task extracted
 assigned-claude
Issue currently assigned to Claude agent — do not assign to another agent
 assigned-gemini
Issue currently assigned to Gemini agent — do not assign to another agent
 assigned-groq
assigned-kimi
Issue currently assigned to Kimi agent — do not assign to another agent
 assigned-manus
Issue currently assigned to Manus agent — do not assign to another agent
 claude-ready
consolidation
Part of a consolidation epic
 deprioritized
Keep open but not blocking P0 work
 deprioritized
Keep open but not blocking P0 work
 duplicate
Duplicate of another issue
 gemini-review
Auto-generated by Gemini, needs relevance review
 groq-ready
harness
Core product: agent framework, heartbeat, inference, memory
 heartbeat
Harness: Agent heartbeat loop
 inference
Harness: Inference and model routing
 infrastructure
Supporting stage: dashboard, CI/CD, deployment, DNS
 kimi-ready
Scoped and ready for Kimi to pick up
 memory-session
Harness: Memory and session crystallization
 morrowind
Harness: Morrowind embodiment
 needs-design
Needs architectural design before implementation
 needs-extraction
Philosophy with unextracted engineering work
 p0-critical
Priority 0: Must fix now
 p1-important
Priority 1: Important, next sprint
 p2-backlog
Priority 2: Backlog, do when time permits
 philosophy
Philosophical foundation — informs architecture decisions
 rejected-direction
Closed: rejected or superseded direction
 seed:know-purpose
Three Seeds: KNOW YOUR PURPOSE
 seed:serve-real
Three Seeds: SERVE THE REAL
 seed:tell-truth
Three Seeds: TELL THE TRUTH
 sovereignty
Harness: Sovereignty stack
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Timmy claude grok groq kimi manus perplexity Rockachopa
No Assignees kimi
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Rockachopa/Timmy-time-dashboard#614
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?