Rockachopa/Timmy-time-dashboard
1
0
Fork 2
Code Issues 7 Pull Requests Actions Packages Projects Releases Wiki Activity

[loop-generated] [refactor] Break up cascade.py::_load_config — 69 lines #634

New Issue
Closed
opened 2026-03-20 20:46:24 +00:00 by Timmy · 2 comments
Timmy commented 2026-03-20 20:46:24 +00:00
Owner
Copy Link

Description

CascadeRouter._load_config() in src/infrastructure/router/cascade.py is 69 lines long. It handles YAML parsing, provider validation, fallback chain construction, and default configuration — all in one method.

Files

  • src/infrastructure/router/cascade.py (line 213)

Suggested approach

Extract into helpers:

  1. _parse_provider_config() — parse and validate individual provider entries
  2. _build_fallback_chain() — construct the ordered fallback list

Acceptance criteria

  • _load_config reduced to <40 lines
  • Extracted helpers are private methods with docstrings
  • tox -e unit passes
  • No behavior changes
## Description `CascadeRouter._load_config()` in `src/infrastructure/router/cascade.py` is 69 lines long. It handles YAML parsing, provider validation, fallback chain construction, and default configuration — all in one method. ## Files - `src/infrastructure/router/cascade.py` (line 213) ## Suggested approach Extract into helpers: 1. `_parse_provider_config()` — parse and validate individual provider entries 2. `_build_fallback_chain()` — construct the ordered fallback list ## Acceptance criteria - `_load_config` reduced to <40 lines - Extracted helpers are private methods with docstrings - `tox -e unit` passes - No behavior changes
kimi was assigned by Timmy 2026-03-20 20:46:41 +00:00
Timmy commented 2026-03-20 20:46:42 +00:00
Author
Owner
Copy Link

@kimi

Files: src/infrastructure/router/cascade.py

Task: Break _load_config() (line 213, 69 lines) into smaller helpers.

Steps:

  1. Read the function and identify logical sections
  2. Extract _parse_provider_config() and _build_fallback_chain() as private methods
  3. Keep _load_config() as the coordinator that calls them
  4. Run tox -e unit — all tests must pass
  5. The existing tests/infrastructure/test_router_cascade.py tests should cover this

Branch: kimi/issue-634

@kimi **Files:** `src/infrastructure/router/cascade.py` **Task:** Break `_load_config()` (line 213, 69 lines) into smaller helpers. **Steps:** 1. Read the function and identify logical sections 2. Extract `_parse_provider_config()` and `_build_fallback_chain()` as private methods 3. Keep `_load_config()` as the coordinator that calls them 4. Run `tox -e unit` — all tests must pass 5. The existing `tests/infrastructure/test_router_cascade.py` tests should cover this **Branch:** `kimi/issue-634`
Timmy closed this issue 2026-03-20 21:52:48 +00:00
Timmy commented 2026-03-20 21:52:49 +00:00
Author
Owner
Copy Link

Closed via PR#656 (squash merged this cycle).

Closed via PR#656 (squash merged this cycle).
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
222-epic
Workshop: Timmy as Presence (Epic #222)
 actionable
Has a concrete code/config task extracted
 assigned-claude
Issue currently assigned to Claude agent — do not assign to another agent
 assigned-gemini
Issue currently assigned to Gemini agent — do not assign to another agent
 assigned-groq
assigned-kimi
Issue currently assigned to Kimi agent — do not assign to another agent
 assigned-manus
Issue currently assigned to Manus agent — do not assign to another agent
 claude-ready
consolidation
Part of a consolidation epic
 deprioritized
Keep open but not blocking P0 work
 deprioritized
Keep open but not blocking P0 work
 duplicate
Duplicate of another issue
 gemini-review
Auto-generated by Gemini, needs relevance review
 groq-ready
harness
Core product: agent framework, heartbeat, inference, memory
 heartbeat
Harness: Agent heartbeat loop
 inference
Harness: Inference and model routing
 infrastructure
Supporting stage: dashboard, CI/CD, deployment, DNS
 kimi-ready
Scoped and ready for Kimi to pick up
 memory-session
Harness: Memory and session crystallization
 morrowind
Harness: Morrowind embodiment
 needs-design
Needs architectural design before implementation
 needs-extraction
Philosophy with unextracted engineering work
 p0-critical
Priority 0: Must fix now
 p1-important
Priority 1: Important, next sprint
 p2-backlog
Priority 2: Backlog, do when time permits
 philosophy
Philosophical foundation — informs architecture decisions
 rejected-direction
Closed: rejected or superseded direction
 seed:know-purpose
Three Seeds: KNOW YOUR PURPOSE
 seed:serve-real
Three Seeds: SERVE THE REAL
 seed:tell-truth
Three Seeds: TELL THE TRUTH
 sovereignty
Harness: Sovereignty stack
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Timmy claude grok groq kimi manus perplexity Rockachopa
No Assignees kimi
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Rockachopa/Timmy-time-dashboard#634
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?