Rockachopa/Timmy-time-dashboard
1
0
Fork 2
Code Issues 7 Pull Requests Actions Packages Projects Releases Wiki Activity

[loop-generated] [refactor] Break up mcp_tools.py::create_gitea_issue_via_mcp — 68 lines #639

New Issue
Closed
opened 2026-03-20 20:56:51 +00:00 by Timmy · 2 comments
Timmy commented 2026-03-20 20:56:51 +00:00
Owner
Copy Link

Problem

mcp_tools.py::create_gitea_issue_via_mcp in src/timmy/mcp_tools.py is 68 lines long.

Acceptance Criteria

  • Extract helper functions to reduce main function to < 40 lines
  • All existing tests pass
  • No behavior changes

Files

  • src/timmy/mcp_tools.py
## Problem `mcp_tools.py::create_gitea_issue_via_mcp` in `src/timmy/mcp_tools.py` is 68 lines long. ## Acceptance Criteria - Extract helper functions to reduce main function to < 40 lines - All existing tests pass - No behavior changes ## Files - `src/timmy/mcp_tools.py`
kimi was assigned by Timmy 2026-03-20 20:57:15 +00:00
Timmy commented 2026-03-20 20:57:15 +00:00
Author
Owner
Copy Link

Kimi, extract helper functions from the main function to reduce it to under 40 lines. Keep all behavior identical. Run tox -e unit to verify tests pass. Branch: kimi/issue-639

Kimi, extract helper functions from the main function to reduce it to under 40 lines. Keep all behavior identical. Run `tox -e unit` to verify tests pass. Branch: `kimi/issue-639`
kimi was unassigned by Timmy 2026-03-21 01:56:58 +00:00
kimi was assigned by Timmy 2026-03-21 01:57:07 +00:00
kimi commented 2026-03-21 03:44:21 +00:00
Collaborator
Copy Link

This refactoring was already completed in commits dd4410f and 001358c. The function create_gitea_issue_via_mcp is now 32 lines (well under the 40-line target), with helpers _build_issue_body, _build_issue_args, _category_from_labels, and _ensure_issue_session already extracted. All 2145 unit tests pass. No further changes needed — closing as already done.

This refactoring was already completed in commits dd4410f and 001358c. The function `create_gitea_issue_via_mcp` is now 32 lines (well under the 40-line target), with helpers `_build_issue_body`, `_build_issue_args`, `_category_from_labels`, and `_ensure_issue_session` already extracted. All 2145 unit tests pass. No further changes needed — closing as already done.
kimi closed this issue 2026-03-21 03:44:26 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
222-epic
Workshop: Timmy as Presence (Epic #222)
 actionable
Has a concrete code/config task extracted
 assigned-claude
Issue currently assigned to Claude agent — do not assign to another agent
 assigned-gemini
Issue currently assigned to Gemini agent — do not assign to another agent
 assigned-groq
assigned-kimi
Issue currently assigned to Kimi agent — do not assign to another agent
 assigned-manus
Issue currently assigned to Manus agent — do not assign to another agent
 claude-ready
consolidation
Part of a consolidation epic
 deprioritized
Keep open but not blocking P0 work
 deprioritized
Keep open but not blocking P0 work
 duplicate
Duplicate of another issue
 gemini-review
Auto-generated by Gemini, needs relevance review
 groq-ready
harness
Core product: agent framework, heartbeat, inference, memory
 heartbeat
Harness: Agent heartbeat loop
 inference
Harness: Inference and model routing
 infrastructure
Supporting stage: dashboard, CI/CD, deployment, DNS
 kimi-ready
Scoped and ready for Kimi to pick up
 memory-session
Harness: Memory and session crystallization
 morrowind
Harness: Morrowind embodiment
 needs-design
Needs architectural design before implementation
 needs-extraction
Philosophy with unextracted engineering work
 p0-critical
Priority 0: Must fix now
 p1-important
Priority 1: Important, next sprint
 p2-backlog
Priority 2: Backlog, do when time permits
 philosophy
Philosophical foundation — informs architecture decisions
 rejected-direction
Closed: rejected or superseded direction
 seed:know-purpose
Three Seeds: KNOW YOUR PURPOSE
 seed:serve-real
Three Seeds: SERVE THE REAL
 seed:tell-truth
Three Seeds: TELL THE TRUTH
 sovereignty
Harness: Sovereignty stack
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Timmy claude grok kimi manus perplexity Rockachopa
No Assignees kimi
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Rockachopa/Timmy-time-dashboard#639
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?